mirror of
https://github.com/arnaucube/Nova.git
synced 2026-01-11 00:21:29 +01:00
Remove Zlib compression in public parameter computation (#182)
* test: add test for pp computation
* bench: add a digest computation bench
* refactor: Optimize digest computation and update tests
- Remove flate2 dependency from codebase
- Replace ZlibEncoder with bincode::serialize in compute_digest function
- Update test_pp_digest expected results to align with compute_digest changes
Bench results:
```
compute_digest time: [1.4451 s 1.4571 s 1.4689 s]
change: [-29.357% -27.854% -26.573%] (p = 0.00 < 0.05)
Performance has improved.
```
This commit is contained in:
committed by
GitHub
parent
bef42262d6
commit
031738de51
84
benches/compute-digest.rs
Normal file
84
benches/compute-digest.rs
Normal file
@@ -0,0 +1,84 @@
|
||||
use std::{marker::PhantomData, time::Duration};
|
||||
|
||||
use bellperson::{gadgets::num::AllocatedNum, ConstraintSystem, SynthesisError};
|
||||
use criterion::{black_box, criterion_group, criterion_main, Criterion};
|
||||
use ff::PrimeField;
|
||||
use nova_snark::{
|
||||
traits::{
|
||||
circuit::{StepCircuit, TrivialTestCircuit},
|
||||
Group,
|
||||
},
|
||||
PublicParams,
|
||||
};
|
||||
|
||||
type G1 = pasta_curves::pallas::Point;
|
||||
type G2 = pasta_curves::vesta::Point;
|
||||
type C1 = NonTrivialTestCircuit<<G1 as Group>::Scalar>;
|
||||
type C2 = TrivialTestCircuit<<G2 as Group>::Scalar>;
|
||||
|
||||
criterion_group! {
|
||||
name = compute_digest;
|
||||
config = Criterion::default().warm_up_time(Duration::from_millis(3000)).sample_size(10);
|
||||
targets = bench_compute_digest
|
||||
}
|
||||
|
||||
criterion_main!(compute_digest);
|
||||
|
||||
fn bench_compute_digest(c: &mut Criterion) {
|
||||
c.bench_function("compute_digest", |b| {
|
||||
b.iter(|| {
|
||||
PublicParams::<G1, G2, C1, C2>::setup(black_box(C1::new(10)), black_box(C2::default()))
|
||||
})
|
||||
});
|
||||
}
|
||||
|
||||
#[derive(Clone, Debug, Default)]
|
||||
struct NonTrivialTestCircuit<F: PrimeField> {
|
||||
num_cons: usize,
|
||||
_p: PhantomData<F>,
|
||||
}
|
||||
|
||||
impl<F> NonTrivialTestCircuit<F>
|
||||
where
|
||||
F: PrimeField,
|
||||
{
|
||||
pub fn new(num_cons: usize) -> Self {
|
||||
Self {
|
||||
num_cons,
|
||||
_p: Default::default(),
|
||||
}
|
||||
}
|
||||
}
|
||||
impl<F> StepCircuit<F> for NonTrivialTestCircuit<F>
|
||||
where
|
||||
F: PrimeField,
|
||||
{
|
||||
fn arity(&self) -> usize {
|
||||
1
|
||||
}
|
||||
|
||||
fn synthesize<CS: ConstraintSystem<F>>(
|
||||
&self,
|
||||
cs: &mut CS,
|
||||
z: &[AllocatedNum<F>],
|
||||
) -> Result<Vec<AllocatedNum<F>>, SynthesisError> {
|
||||
// Consider a an equation: `x^2 = y`, where `x` and `y` are respectively the input and output.
|
||||
let mut x = z[0].clone();
|
||||
let mut y = x.clone();
|
||||
for i in 0..self.num_cons {
|
||||
y = x.square(cs.namespace(|| format!("x_sq_{i}")))?;
|
||||
x = y.clone();
|
||||
}
|
||||
Ok(vec![y])
|
||||
}
|
||||
|
||||
fn output(&self, z: &[F]) -> Vec<F> {
|
||||
let mut x = z[0];
|
||||
let mut y = x;
|
||||
for _i in 0..self.num_cons {
|
||||
y = x * x;
|
||||
x = y;
|
||||
}
|
||||
vec![y]
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user