mirror of
https://github.com/arnaucube/Nova.git
synced 2026-01-11 00:21:29 +01:00
[refactorings] Leftovers (pot-pourri?) (#184)
* test: compute_path
* refactor: path computation
- Improve path concatenation by utilizing built-in `join` method
* refactor: replace `PartialEq` with derived instance
- Derive `PartialEq` for `SatisfyingAssignment` struct
- Remove redundant manual implementation of `PartialEq`
Cargo-expand generates:
```
#[automatically_derived]
impl<G: ::core::cmp::PartialEq + Group> ::core::cmp::PartialEq
for SatisfyingAssignment<G>
where
G::Scalar: PrimeField,
G::Scalar: ::core::cmp::PartialEq,
G::Scalar: ::core::cmp::PartialEq,
G::Scalar: ::core::cmp::PartialEq,
G::Scalar: ::core::cmp::PartialEq,
G::Scalar: ::core::cmp::PartialEq,
{
#[inline]
fn eq(&self, other: &SatisfyingAssignment<G>) -> bool {
self.a_aux_density == other.a_aux_density
&& self.b_input_density == other.b_input_density
&& self.b_aux_density == other.b_aux_density && self.a == other.a
&& self.b == other.b && self.c == other.c
&& self.input_assignment == other.input_assignment
&& self.aux_assignment == other.aux_assignment
}
}
```
* refactor: avoid default for PhantomData Unit type
* refactor: replace fold with sum where applicable
- Simplify code by replacing `fold` with `sum` in various instances
* refactor: decompression method in sumcheck.rs
* refactor: test functions to use slice instead of vector conversion
* refactor: use more references in functions
- Update parameter types to use references instead of owned values in various functions that do not need them
- Replace cloning instances with references
This commit is contained in:
committed by
GitHub
parent
ff0370f506
commit
1e6bf942e2
@@ -90,8 +90,8 @@ fn bench_compressed_snark(c: &mut Criterion) {
|
||||
let res = recursive_snark.verify(
|
||||
&pp,
|
||||
i + 1,
|
||||
&vec![<G1 as Group>::Scalar::from(2u64)][..],
|
||||
&vec![<G2 as Group>::Scalar::from(2u64)][..],
|
||||
&[<G1 as Group>::Scalar::from(2u64)],
|
||||
&[<G2 as Group>::Scalar::from(2u64)],
|
||||
);
|
||||
assert!(res.is_ok());
|
||||
}
|
||||
|
||||
@@ -113,8 +113,8 @@ fn bench_recursive_snark(c: &mut Criterion) {
|
||||
.verify(
|
||||
black_box(&pp),
|
||||
black_box(num_warmup_steps),
|
||||
black_box(&vec![<G1 as Group>::Scalar::from(2u64)][..]),
|
||||
black_box(&vec![<G2 as Group>::Scalar::from(2u64)][..]),
|
||||
black_box(&[<G1 as Group>::Scalar::from(2u64)]),
|
||||
black_box(&[<G2 as Group>::Scalar::from(2u64)]),
|
||||
)
|
||||
.is_ok());
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user