arnaucube/Nova
1
0
Fork 0
mirror of https://github.com/arnaucube/Nova.git synced 2026-01-12 17:11:27 +01:00
Code Issues Projects Releases Wiki Activity

Abstract the RO used in the circuit with traits (#84)

Browse Source 
* cleanup RO usage inside the circuit: use traits

* Add a note

* rename types for clarity
This commit is contained in:
Srinath Setty
2022-07-05 16:24:12 -07:00
committed by GitHub
parent 0863a732ff
commit 6667d2f8b5
7 changed files with 118 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/gadgets/r1cs.rs
View File

@@ -7,9 +7,8 @@ use crate::{
conditionally_select_bignat, le_bits_to_num,
},
},
poseidon::{PoseidonROGadget, ROConstantsCircuit},
r1cs::{R1CSInstance, RelaxedR1CSInstance},
traits::Group,
traits::{Group, HashFuncCircuitTrait, HashFuncConstantsCircuit},
};
use bellperson::{
gadgets::{boolean::Boolean, num::AllocatedNum, Assignment},
@@ -61,7 +60,7 @@ where
}
/// Absorb the provided instance in the RO
pub fn absorb_in_ro(&self, ro: &mut PoseidonROGadget<G::Base>) {
pub fn absorb_in_ro(&self, ro: &mut G::HashFuncCircuit) {
ro.absorb(self.W.x.clone());
ro.absorb(self.W.y.clone());
ro.absorb(self.W.is_infinity.clone());
@@ -208,7 +207,7 @@ where
pub fn absorb_in_ro<CS: ConstraintSystem<<G as Group>::Base>>(
&self,
mut cs: CS,
ro: &mut PoseidonROGadget<G::Base>,
ro: &mut G::HashFuncCircuit,
) -> Result<(), SynthesisError> {
ro.absorb(self.W.x.clone());
ro.absorb(self.W.y.clone());
@@ -263,12 +262,12 @@ where
params: AllocatedNum<G::Base>, // hash of R1CSShape of F'
u: AllocatedR1CSInstance<G>,
T: AllocatedPoint<G::Base>,
ro_consts: ROConstantsCircuit<G::Base>,
ro_consts: HashFuncConstantsCircuit<G>,
limb_width: usize,
n_limbs: usize,
) -> Result<AllocatedRelaxedR1CSInstance<G>, SynthesisError> {
// Compute r:
let mut ro: PoseidonROGadget<G::Base> = PoseidonROGadget::new(ro_consts);
let mut ro = G::HashFuncCircuit::new(ro_consts);
ro.absorb(params);
self.absorb_in_ro(cs.namespace(|| "absorb running instance"), &mut ro)?;
u.absorb_in_ro(&mut ro);