Sync with the recent changes in ark-algebra on pairing and testing (#116)

* Fix another typo in the Jubjub curve comment

* fix

* progress

* get_point_from_x_unchecked

* fix

* soft link

* Fix Bandersnatch

* Fix Edwards form of Bandersnatch

* Actually fix ed_on_bls12_381_bandersnatch/src/curves/mod.rs

* fix

* fix

* curve-benches

* fix the last mul_by_a; fmt

Co-authored-by: onewayfunc <onewayfunc@gmail.com>
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>

ed_on_bls12_381_bandersnatch/Cargo.toml

@@ -8,7 +8,7 @@ keywords = ["cryptography", "finite-fields", "elliptic-curves" ]
 categories = ["cryptography"]
 include = ["Cargo.toml", "src", "README.md", "LICENSE-APACHE", "LICENSE-MIT"]
 license = "MIT/Apache-2.0"
-edition = "2018"
+edition = "2021"
 
 [dependencies]
 ark-ff = { version = "^0.3.0", default-features = false }

ed_on_bls12_381_bandersnatch/LICENSE-APACHE

@@ -0,0 +1 @@
+../LICENSE-APACHE

ed_on_bls12_381_bandersnatch/LICENSE-MIT

@@ -0,0 +1 @@
+../LICENSE-MIT

ed_on_bls12_381_bandersnatch/src/curves/mod.rs

@@ -83,9 +83,8 @@ impl TECurveConfig for BandersnatchParameters {
 
     /// Multiplication by `a` is multiply by `-5`.
     #[inline(always)]
-    fn mul_by_a(elem: &Self::BaseField) -> Self::BaseField {
-        let t = (*elem).double().double();
-        -(t + *elem)
+    fn mul_by_a(elem: Self::BaseField) -> Self::BaseField {
+        elem.double().double() * elem
     }
 }
 

ed_on_bls12_381_bandersnatch/src/curves/tests.rs

@@ -1,5 +1,5 @@
 use ark_algebra_test_templates::curves::*;
-use ark_ec::{AffineCurve, ProjectiveCurve};
+use ark_ec::{AffineRepr, ProjectiveCurve};
 use ark_ff::Zero;
 use ark_std::{ops::Mul, str::FromStr};