arnaucube/ark-r1cs-std
1
0
Fork 0
mirror of https://github.com/arnaucube/ark-r1cs-std.git synced 2026-01-09 07:21:29 +01:00
Code Issues Projects Releases Wiki Activity

convert nonnative constant to little endian (#127)

Browse Source
This commit is contained in:
Chris Sosnin
2023-08-31 16:10:39 +03:00
committed by GitHub
parent 7693d58690
commit 2ca3bd7d97
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -3,6 +3,7 @@
## Pending ## Pending
- [\#117](https://github.com/arkworks-rs/r1cs-std/pull/117) Fix result of `precomputed_base_scalar_mul_le` to not discard previous value. - [\#117](https://github.com/arkworks-rs/r1cs-std/pull/117) Fix result of `precomputed_base_scalar_mul_le` to not discard previous value.
- [\#124](https://github.com/arkworks-rs/r1cs-std/pull/124) Fix `scalar_mul_le` constraints unsatisfiability when short Weierstrass point is zero. - [\#124](https://github.com/arkworks-rs/r1cs-std/pull/124) Fix `scalar_mul_le` constraints unsatisfiability when short Weierstrass point is zero.
- [\#127](https://github.com/arkworks-rs/r1cs-std/pull/127) Convert `NonNativeFieldVar` constants to little-endian bytes instead of big-endian (`ToBytesGadget`).
### Breaking changes ### Breaking changes

4
src/fields/nonnative/field_var.rs
View File

@@ -313,7 +313,7 @@ impl<TargetField: PrimeField, BaseField: PrimeField> ToBytesGadget<BaseField>
fn to_bytes(&self) -> R1CSResult<Vec<UInt8<BaseField>>> { fn to_bytes(&self) -> R1CSResult<Vec<UInt8<BaseField>>> {
match self { match self {
Self::Constant(c) => Ok(UInt8::constant_vec( Self::Constant(c) => Ok(UInt8::constant_vec(
c.into_bigint().to_bytes_be().as_slice(), c.into_bigint().to_bytes_le().as_slice(),
)), )),
Self::Var(v) => v.to_bytes(), Self::Var(v) => v.to_bytes(),
@@ -324,7 +324,7 @@ impl<TargetField: PrimeField, BaseField: PrimeField> ToBytesGadget<BaseField>
fn to_non_unique_bytes(&self) -> R1CSResult<Vec<UInt8<BaseField>>> { fn to_non_unique_bytes(&self) -> R1CSResult<Vec<UInt8<BaseField>>> {
match self { match self {
Self::Constant(c) => Ok(UInt8::constant_vec( Self::Constant(c) => Ok(UInt8::constant_vec(
c.into_bigint().to_bytes_be().as_slice(), c.into_bigint().to_bytes_le().as_slice(),
)), )),
Self::Var(v) => v.to_non_unique_bytes(), Self::Var(v) => v.to_non_unique_bytes(),
} }