arnaucube/ark-r1cs-std
1
0
Fork 0
mirror of https://github.com/arnaucube/ark-r1cs-std.git synced 2026-01-11 08:21:30 +01:00
Code Issues Projects Releases Wiki Activity

Update to use bit iterator

Browse Source
This commit is contained in:
ValarDragon
2020-02-28 16:14:54 -08:00
committed by Pratyush Mishra
parent 8cce6501b8
commit b63d255ea3
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
r1cs-std/src/fields/mod.rs
View File

@@ -1,4 +1,4 @@
use algebra::Field; use algebra::{Field, fields::BitIterator};
use core::fmt::Debug; use core::fmt::Debug;
use r1cs_core::{ConstraintSystem, SynthesisError}; use r1cs_core::{ConstraintSystem, SynthesisError};
@@ -224,22 +224,22 @@ pub trait FieldGadget<F: Field, ConstraintF: Field>:
Ok(res) Ok(res)
} }
fn pow_by_constant<CS: ConstraintSystem<ConstraintF>>( fn pow_by_constant<S: AsRef<[u64]>, CS: ConstraintSystem<ConstraintF>>(
&self, &self,
mut cs: CS, mut cs: CS,
exp: u64 exp: S
) -> Result<Self, SynthesisError> { ) -> Result<Self, SynthesisError> {
let mut res = Self::one(cs.ns(|| "Alloc result"))?; let mut res = Self::one(cs.ns(|| "Alloc result"))?;
let mut found_one = false; let mut found_one = false;
for i in (0..64).rev() for i in BitIterator::new(exp)
{ {
if found_one if found_one
{ {
res.square_in_place(cs.ns(|| format!("square for bit {:?}", i)))?; res.square_in_place(cs.ns(|| format!("square for bit {:?}", i)))?;
} }
if exp & (1 << i) != 0 if !i
{ {
found_one = true; found_one = true;
res.mul_in_place(cs.ns(|| format!("mul for bit {:?}", i)), self)?; res.mul_in_place(cs.ns(|| format!("mul for bit {:?}", i)), self)?;
@@ -431,9 +431,10 @@ pub(crate) mod tests {
.unwrap() .unwrap()
); );
// a * a * a = a^3
assert_eq!( assert_eq!(
a_native * &(a_native * &a_native), a_native * &(a_native * &a_native),
a.pow_by_constant(cs.ns(|| "test_pow"), 3) a.pow_by_constant(cs.ns(|| "test_pow"), &[3])
.unwrap() .unwrap()
.get_value() .get_value()
.unwrap() .unwrap()