cleaned up qe api (#21)

field/quadratic_extension.go

@@ -25,9 +25,7 @@ type QuadraticExtensionAPI struct {
 	ZERO_QE_ALGEBRA QEAlgebra
 }
 
-func NewQuadraticExtensionAPI(api frontend.API, fieldAPI FieldAPI, degreeBits uint64) *QuadraticExtensionAPI {
-	// TODO:  Should degreeBits be verified that it fits within the field and that degree is within uint64?
-
+func NewQuadraticExtensionAPI(api frontend.API, fieldAPI FieldAPI) *QuadraticExtensionAPI {
 	var ZERO_QE = QuadraticExtension{ZERO_F, ZERO_F}
 
 	var ZERO_QE_ALGEBRA QEAlgebra

field/quadratic_extension_test.go

@@ -20,8 +20,7 @@ type TestQuadraticExtensionMulCircuit struct {
 
 func (c *TestQuadraticExtensionMulCircuit) Define(api frontend.API) error {
 	fieldAPI := NewFieldAPI(api)
-	degreeBits := 3
-	c.qeAPI = NewQuadraticExtensionAPI(api, fieldAPI, uint64(degreeBits))
+	c.qeAPI = NewQuadraticExtensionAPI(api, fieldAPI)
 
 	actualRes := c.qeAPI.MulExtension(c.Operand1, c.Operand2)
 
@@ -54,8 +53,7 @@ type TestQuadraticExtensionDivCircuit struct {
 
 func (c *TestQuadraticExtensionDivCircuit) Define(api frontend.API) error {
 	fieldAPI := NewFieldAPI(api)
-	degreeBits := 3
-	c.qeAPI = NewQuadraticExtensionAPI(api, fieldAPI, uint64(degreeBits))
+	c.qeAPI = NewQuadraticExtensionAPI(api, fieldAPI)
 
 	actualRes := c.qeAPI.DivExtension(c.Operand1, c.Operand2)
 

poseidon/poseidon_test.go

@@ -18,7 +18,7 @@ type TestPoseidonCircuit struct {
 
 func (circuit *TestPoseidonCircuit) Define(api frontend.API) error {
 	goldilocksApi := field.NewFieldAPI(api)
-	qeAPI := field.NewQuadraticExtensionAPI(api, goldilocksApi, 3)
+	qeAPI := field.NewQuadraticExtensionAPI(api, goldilocksApi)
 
 	var input PoseidonState
 	for i := 0; i < 12; i++ {

verifier/internal/fri/fri_test.go

@@ -25,7 +25,7 @@ func (circuit *TestFriCircuit) Define(api frontend.API) error {
 	verifierOnlyCircuitData := utils.DeserializeVerifierOnlyCircuitData(circuit.verifierOnlyCircuitDataFilename)
 
 	fieldAPI := field.NewFieldAPI(api)
-	qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI, commonCircuitData.DegreeBits)
+	qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI)
 	poseidonChip := poseidon.NewPoseidonChip(api, fieldAPI, qeAPI)
 	poseidonBN128Chip := poseidon.NewPoseidonBN128Chip(api, fieldAPI)
 	friChip := fri.NewFriChip(api, fieldAPI, qeAPI, poseidonBN128Chip, &commonCircuitData.FriParams)

verifier/internal/gates/gate_test.go

@@ -688,7 +688,7 @@ func (circuit *TestGateCircuit) Define(api frontend.API) error {
 	numSelectors := commonCircuitData.SelectorsInfo.NumSelectors()
 
 	fieldAPI := field.NewFieldAPI(api)
-	qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI, commonCircuitData.DegreeBits)
+	qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI)
 
 	vars := gates.NewEvaluationVars(localConstants[numSelectors:], localWires, publicInputsHash)
 

verifier/internal/plonk/challenger_test.go

@@ -20,8 +20,7 @@ type TestChallengerCircuit struct {
 
 func (circuit *TestChallengerCircuit) Define(api frontend.API) error {
 	fieldAPI := field.NewFieldAPI(api)
-	degreeBits := 3
-	qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI, uint64(degreeBits))
+	qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI)
 	poseidonChip := poseidon.NewPoseidonChip(api, fieldAPI, qeAPI)
 	poseidonBN128Chip := poseidon.NewPoseidonBN128Chip(api, fieldAPI)
 	challengerChip := NewChallengerChip(api, fieldAPI, poseidonChip, poseidonBN128Chip)

verifier/internal/plonk/plonk_test.go

@@ -27,7 +27,7 @@ func (circuit *TestPlonkCircuit) Define(api frontend.API) error {
 	proofChallenges := verifierChip.GetChallenges(proofWithPis, publicInputsHash, commonCircuitData, verifierOnlyCircuitData)
 
 	fieldAPI := field.NewFieldAPI(api)
-	qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI, commonCircuitData.DegreeBits)
+	qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI)
 	plonkChip := plonk.NewPlonkChip(
 		api,
 		qeAPI,

verifier/verifier.go

@@ -22,7 +22,7 @@ type VerifierChip struct {
 func NewVerifierChip(api frontend.API, commonCircuitData common.CommonCircuitData) *VerifierChip {
 
 	fieldAPI := field.NewFieldAPI(api)
-	qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI, commonCircuitData.DegreeBits)
+	qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI)
 	poseidonBN128Chip := poseidon.NewPoseidonBN128Chip(api, fieldAPI)
 
 	friChip := fri.NewFriChip(api, fieldAPI, qeAPI, poseidonBN128Chip, &commonCircuitData.FriParams)