fix for V-SCT-VUL-027

This commit is contained in:
Kevin Jue
2023-12-19 12:22:19 -08:00
parent 40d71e9e29
commit f256ca69f3
6 changed files with 23 additions and 16 deletions

View File

@@ -73,11 +73,15 @@ func (f *Chip) ToOpenings(c variables.OpeningSet) Openings {
}
func (f *Chip) assertLeadingZeros(powWitness gl.Variable, friConfig types.FriConfig) {
// Asserts that powWitness'es big-endian bit representation has at least `leading_zeros` leading zeros.
// Asserts that powWitness'es big-endian bit representation has at least friConfig.ProofOfWorkBits leading zeros.
// Note that this is assuming that the Goldilocks field is being used. Specfically that the
// field is 64 bits long
maxPowWitness := uint64(math.Pow(2, float64(64-friConfig.ProofOfWorkBits))) - 1
// TODO: This does an un-nessary reduce, since powWitness is already range checked to be within GL field.
reducedPowWitness := f.gl.Reduce(powWitness)
// TODO: Can replace with with std.rangecheck.Check. Will probably be less contraints.
f.api.AssertIsLessOrEqual(reducedPowWitness.Limb, frontend.Variable(maxPowWitness))
}