Remove unnecessary structs & polsC

Merge pull request #19 from iden3/fix/pk-parse-benchmarks
Fix pk parser benchmarks
2026-02-07 03:16:46 +01:00 · 2020-05-22 13:02:30 +02:00 · 2020-05-21 16:19:07 +02:00 · 2020-05-21 13:19:45 +02:00 · 2020-05-21 11:25:53 +02:00
4 changed files with 8 additions and 39 deletions
--- a/parsers/parsers.go
+++ b/parsers/parsers.go
@@ -34,7 +34,6 @@ type PkString struct {
 	DomainSize int                 `json:"domainSize"`
 	PolsA      []map[string]string `json:"polsA"`
 	PolsB      []map[string]string `json:"polsB"`
-	PolsC      []map[string]string `json:"polsC"`
 }

 // WitnessString contains the Witness in string representation
@@ -149,10 +148,6 @@ func pkStringToPk(ps PkString) (*types.Pk, error) {
 	if err != nil {
 		return nil, err
 	}
-	p.PolsC, err = polsStringToBigInt(ps.PolsC)
-	if err != nil {
-		return nil, err
-	}

 	return &p, nil
 }
--- a/parsers/parsers_test.go
+++ b/parsers/parsers_test.go
@@ -297,17 +297,22 @@ func benchmarkParsePk(b *testing.B, circuit string) {

 	b.Run("ParsePkJson "+circuit, func(b *testing.B) {
 		for i := 0; i < b.N; i++ {
-			ParsePkBin(pkBinFile)
+			_, err = ParsePk(pkJson)
+			require.Nil(b, err)
 		}
 	})
 	b.Run("ParsePkBin "+circuit, func(b *testing.B) {
 		for i := 0; i < b.N; i++ {
-			ParsePk(pkJson)
+			pkBinFile.Seek(0, 0)
+			_, err = ParsePkBin(pkBinFile)
+			require.Nil(b, err)
 		}
 	})
 	b.Run("ParsePkGoBin "+circuit, func(b *testing.B) {
 		for i := 0; i < b.N; i++ {
-			ParsePkGoBin(pkBinFile)
+			pkGoBinFile.Seek(0, 0)
+			_, err = ParsePkGoBin(pkGoBinFile)
+			require.Nil(b, err)
 		}
 	})
 }
--- a/prover/prover.go
+++ b/prover/prover.go
@@ -13,36 +13,6 @@ import (
 	//"fmt"
 )

-// Proof is the data structure of the Groth16 zkSNARK proof
-type Proof struct {
-	A *bn256.G1
-	B *bn256.G2
-	C *bn256.G1
-}
-
-// Pk holds the data structure of the ProvingKey
-type Pk struct {
-	A          []*bn256.G1
-	B2         []*bn256.G2
-	B1         []*bn256.G1
-	C          []*bn256.G1
-	NVars      int
-	NPublic    int
-	VkAlpha1   *bn256.G1
-	VkDelta1   *bn256.G1
-	VkBeta1    *bn256.G1
-	VkBeta2    *bn256.G2
-	VkDelta2   *bn256.G2
-	HExps      []*bn256.G1
-	DomainSize int
-	PolsA      []map[int]*big.Int
-	PolsB      []map[int]*big.Int
-	PolsC      []map[int]*big.Int
-}
-
-// Witness contains the witness
-type Witness []*big.Int
-
 // Group Size
 const (
 	GSIZE = 6
--- a/types/types.go
+++ b/types/types.go
@@ -83,7 +83,6 @@ type Pk struct {
 	DomainSize int
 	PolsA      []map[int]*big.Int
 	PolsB      []map[int]*big.Int
-	PolsC      []map[int]*big.Int
 }

 // Witness contains the witness
Author	SHA1	Message	Date
arnaucube	9f2587151f	Remove unnecessary structs & polsC	2020-05-22 13:02:30 +02:00
Eduard S	e652f34753	Merge pull request #19 from iden3/fix/pk-parse-benchmarks Fix pk parser benchmarks	2020-05-21 16:19:07 +02:00
arnaucube	42961f6b94	Fix pk parser benchmarks Parsers were working correctly, but the benchmarks had errors. The benchmarks in the commit `d1b3979eb6` are incorrect, correct ones are: ``` BenchmarkParsePk/ParsePkJson_circuit1k-4 2 529437960 ns/op BenchmarkParsePk/ParsePkBin_circuit1k-4 2 607792597 ns/op BenchmarkParsePk/ParsePkGoBin_circuit1k-4 2 540594611 ns/op BenchmarkParsePk/ParsePkJson_circuit5k-4 1 2769819086 ns/op BenchmarkParsePk/ParsePkBin_circuit5k-4 1 3094913319 ns/op BenchmarkParsePk/ParsePkGoBin_circuit5k-4 1 2404651389 ns/op BenchmarkParsePk/ParsePkJson_circuit10k-4 1 5374917709 ns/op BenchmarkParsePk/ParsePkBin_circuit10k-4 1 5756633515 ns/op BenchmarkParsePk/ParsePkGoBin_circuit10k-4 1 4782081310 ns/op BenchmarkParsePk/ParsePkJson_circuit20k-4 1 10374987398 ns/op BenchmarkParsePk/ParsePkBin_circuit20k-4 1 11528361584 ns/op BenchmarkParsePk/ParsePkGoBin_circuit20k-4 1 9541829245 ns/op BenchmarkParsePk/ParsePkJson_circuit50k-4 1 25979727146 ns/op BenchmarkParsePk/ParsePkBin_circuit50k-4 1 28434810627 ns/op BenchmarkParsePk/ParsePkGoBin_circuit50k-4 1 23860248412 ns/op ``` The size of ProvingKey file for a circuit of 20k and 50k constraints: ``` circuit 20k constraints: 10097876 bytes of proving_key.go.bin 10097876 bytes of proving_key.bin 29760049 bytes of proving_key.json circuit 50k constraints: 24195028 bytes of proving_key.go.bin 24194964 bytes of proving_key.bin 71484081 bytes of proving_key.json ```	2020-05-21 13:19:45 +02:00
Eduard S	386758370e	Merge pull request #18 from iden3/feature/pk-own-format Add own go-circom ProvingKey Bin format	2020-05-21 11:25:53 +02:00