You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

543 lines
20 KiB

  1. package txselector
  2. // current: very simple version of TxSelector
  3. import (
  4. "bytes"
  5. "fmt"
  6. "math/big"
  7. "sort"
  8. ethCommon "github.com/ethereum/go-ethereum/common"
  9. "github.com/hermeznetwork/hermez-node/common"
  10. "github.com/hermeznetwork/hermez-node/db/l2db"
  11. "github.com/hermeznetwork/hermez-node/db/statedb"
  12. "github.com/hermeznetwork/hermez-node/log"
  13. "github.com/hermeznetwork/hermez-node/txprocessor"
  14. "github.com/hermeznetwork/tracerr"
  15. "github.com/iden3/go-iden3-crypto/babyjub"
  16. )
  17. // txs implements the interface Sort for an array of Tx
  18. type txs []common.PoolL2Tx
  19. func (t txs) Len() int {
  20. return len(t)
  21. }
  22. func (t txs) Swap(i, j int) {
  23. t[i], t[j] = t[j], t[i]
  24. }
  25. func (t txs) Less(i, j int) bool {
  26. return t[i].AbsoluteFee > t[j].AbsoluteFee
  27. }
  28. // CoordAccount contains the data of the Coordinator account, that will be used
  29. // to create new transactions of CreateAccountDeposit type to add new TokenID
  30. // accounts for the Coordinator to receive the fees.
  31. type CoordAccount struct {
  32. Addr ethCommon.Address
  33. BJJ babyjub.PublicKeyComp
  34. AccountCreationAuth []byte // signature in byte array format
  35. }
  36. // SelectionConfig contains the parameters of configuration of the selection of
  37. // transactions for the next batch
  38. type SelectionConfig struct {
  39. // MaxL1UserTxs is the maximum L1-user-tx for a batch
  40. MaxL1UserTxs uint64
  41. // TxProcessorConfig contains the config for ProcessTxs
  42. TxProcessorConfig txprocessor.Config
  43. }
  44. // TxSelector implements all the functionalities to select the txs for the next
  45. // batch
  46. type TxSelector struct {
  47. l2db *l2db.L2DB
  48. localAccountsDB *statedb.LocalStateDB
  49. coordAccount *CoordAccount
  50. }
  51. // NewTxSelector returns a *TxSelector
  52. func NewTxSelector(coordAccount *CoordAccount, dbpath string,
  53. synchronizerStateDB *statedb.StateDB, l2 *l2db.L2DB) (*TxSelector, error) {
  54. localAccountsDB, err := statedb.NewLocalStateDB(dbpath, 128,
  55. synchronizerStateDB, statedb.TypeTxSelector, 0) // without merkletree
  56. if err != nil {
  57. return nil, tracerr.Wrap(err)
  58. }
  59. return &TxSelector{
  60. l2db: l2,
  61. localAccountsDB: localAccountsDB,
  62. coordAccount: coordAccount,
  63. }, nil
  64. }
  65. // LocalAccountsDB returns the LocalStateDB of the TxSelector
  66. func (txsel *TxSelector) LocalAccountsDB() *statedb.LocalStateDB {
  67. return txsel.localAccountsDB
  68. }
  69. // Reset tells the TxSelector to get it's internal AccountsDB
  70. // from the required `batchNum`
  71. func (txsel *TxSelector) Reset(batchNum common.BatchNum) error {
  72. err := txsel.localAccountsDB.Reset(batchNum, true)
  73. if err != nil {
  74. return tracerr.Wrap(err)
  75. }
  76. return nil
  77. }
  78. func (txsel *TxSelector) getCoordIdx(tokenID common.TokenID) (common.Idx, error) {
  79. return txsel.localAccountsDB.GetIdxByEthAddrBJJ(txsel.coordAccount.Addr,
  80. txsel.coordAccount.BJJ, tokenID)
  81. }
  82. // coordAccountForTokenID creates a new L1CoordinatorTx to create a new
  83. // Coordinator account for the given TokenID in the case that the account does
  84. // not exist yet in the db, and does not exist a L1CoordinatorTx to creat that
  85. // account in the given array of L1CoordinatorTxs. If a new Coordinator account
  86. // needs to be created, a new L1CoordinatorTx will be returned from this
  87. // function. After calling this method, if the l1CoordinatorTx is added to the
  88. // selection, positionL1 must be increased 1.
  89. func (txsel *TxSelector) coordAccountForTokenID(l1CoordinatorTxs []common.L1Tx,
  90. tokenID common.TokenID, positionL1 int) (*common.L1Tx, int, error) {
  91. // check if CoordinatorAccount for TokenID is already pending to create
  92. if checkAlreadyPendingToCreate(l1CoordinatorTxs, tokenID,
  93. txsel.coordAccount.Addr, txsel.coordAccount.BJJ) {
  94. return nil, positionL1, nil
  95. }
  96. _, err := txsel.getCoordIdx(tokenID)
  97. if tracerr.Unwrap(err) == statedb.ErrIdxNotFound {
  98. // create L1CoordinatorTx to create new CoordAccount for
  99. // TokenID
  100. l1CoordinatorTx := common.L1Tx{
  101. Position: positionL1,
  102. UserOrigin: false,
  103. FromEthAddr: txsel.coordAccount.Addr,
  104. FromBJJ: txsel.coordAccount.BJJ,
  105. TokenID: tokenID,
  106. Amount: big.NewInt(0),
  107. DepositAmount: big.NewInt(0),
  108. Type: common.TxTypeCreateAccountDeposit,
  109. }
  110. return &l1CoordinatorTx, positionL1, nil
  111. }
  112. if err != nil {
  113. return nil, positionL1, tracerr.Wrap(err)
  114. }
  115. // CoordAccount for TokenID already exists
  116. return nil, positionL1, nil
  117. }
  118. // GetL2TxSelection returns the L1CoordinatorTxs and a selection of the L2Txs
  119. // for the next batch, from the L2DB pool.
  120. // It returns: the CoordinatorIdxs used to receive the fees of the selected
  121. // L2Txs. An array of bytearrays with the signatures of the
  122. // AccountCreationAuthorization of the accounts of the users created by the
  123. // Coordinator with L1CoordinatorTxs of those accounts that does not exist yet
  124. // but there is a transactions to them and the authorization of account
  125. // creation exists. The L1UserTxs, L1CoordinatorTxs, PoolL2Txs that will be
  126. // included in the next batch.
  127. func (txsel *TxSelector) GetL2TxSelection(selectionConfig *SelectionConfig) ([]common.Idx,
  128. [][]byte, []common.L1Tx,
  129. []common.PoolL2Tx, error) {
  130. coordIdxs, accCreationAuths, _, l1CoordinatorTxs, l2Txs, err :=
  131. txsel.GetL1L2TxSelection(selectionConfig, []common.L1Tx{})
  132. return coordIdxs, accCreationAuths, l1CoordinatorTxs, l2Txs, tracerr.Wrap(err)
  133. }
  134. // GetL1L2TxSelection returns the selection of L1 + L2 txs.
  135. // It returns: the CoordinatorIdxs used to receive the fees of the selected
  136. // L2Txs. An array of bytearrays with the signatures of the
  137. // AccountCreationAuthorization of the accounts of the users created by the
  138. // Coordinator with L1CoordinatorTxs of those accounts that does not exist yet
  139. // but there is a transactions to them and the authorization of account
  140. // creation exists. The L1UserTxs, L1CoordinatorTxs, PoolL2Txs that will be
  141. // included in the next batch.
  142. func (txsel *TxSelector) GetL1L2TxSelection(selectionConfig *SelectionConfig,
  143. l1UserTxs []common.L1Tx) ([]common.Idx, [][]byte, []common.L1Tx,
  144. []common.L1Tx, []common.PoolL2Tx, error) {
  145. // WIP.0: the TxSelector is not optimized and will need a redesign. The
  146. // current version is implemented in order to have a functional
  147. // implementation that can be used asap.
  148. //
  149. // WIP.1: this method uses a 'cherry-pick' of internal calls of the
  150. // StateDB, a refactor of the StateDB to reorganize it internally is
  151. // planned once the main functionallities are covered, with that
  152. // refactor the TxSelector will be updated also.
  153. // get pending l2-tx from tx-pool
  154. l2TxsRaw, err := txsel.l2db.GetPendingTxs()
  155. if err != nil {
  156. return nil, nil, nil, nil, nil, tracerr.Wrap(err)
  157. }
  158. txselStateDB := txsel.localAccountsDB.StateDB
  159. tp := txprocessor.NewTxProcessor(txselStateDB, selectionConfig.TxProcessorConfig)
  160. // Process L1UserTxs
  161. for i := 0; i < len(l1UserTxs); i++ {
  162. // assumption: l1usertx are sorted by L1Tx.Position
  163. _, _, _, _, err := tp.ProcessL1Tx(nil, &l1UserTxs[i])
  164. if err != nil {
  165. return nil, nil, nil, nil, nil, tracerr.Wrap(err)
  166. }
  167. }
  168. var l1CoordinatorTxs []common.L1Tx
  169. positionL1 := len(l1UserTxs)
  170. var accAuths [][]byte
  171. // sort l2TxsRaw (cropping at MaxTx at this point)
  172. l2Txs0 := txsel.getL2Profitable(l2TxsRaw, selectionConfig.TxProcessorConfig.MaxTx)
  173. noncesMap := make(map[common.Idx]common.Nonce)
  174. var l2Txs []common.PoolL2Tx
  175. // iterate over l2Txs
  176. // - if tx.TokenID does not exist at CoordsIdxDB
  177. // - create new L1CoordinatorTx creating a CoordAccount, for
  178. // Coordinator to receive the fee of the new TokenID
  179. for i := 0; i < len(l2Txs0); i++ {
  180. accSender, err := tp.StateDB().GetAccount(l2Txs0[i].FromIdx)
  181. if err != nil {
  182. return nil, nil, nil, nil, nil, tracerr.Wrap(err)
  183. }
  184. l2Txs0[i].TokenID = accSender.TokenID
  185. // populate the noncesMap used at the next iteration
  186. noncesMap[l2Txs0[i].FromIdx] = accSender.Nonce
  187. // if TokenID does not exist yet, create new L1CoordinatorTx to
  188. // create the CoordinatorAccount for that TokenID, to receive
  189. // the fees. Only in the case that there does not exist yet a
  190. // pending L1CoordinatorTx to create the account for the
  191. // Coordinator for that TokenID
  192. var newL1CoordTx *common.L1Tx
  193. newL1CoordTx, positionL1, err =
  194. txsel.coordAccountForTokenID(l1CoordinatorTxs,
  195. accSender.TokenID, positionL1)
  196. if err != nil {
  197. return nil, nil, nil, nil, nil, tracerr.Wrap(err)
  198. }
  199. if newL1CoordTx != nil {
  200. // if there is no space for the L1CoordinatorTx, discard the L2Tx
  201. if len(l1CoordinatorTxs) >= int(selectionConfig.MaxL1UserTxs)-len(l1UserTxs) {
  202. // discard L2Tx
  203. continue
  204. }
  205. // increase positionL1
  206. positionL1++
  207. l1CoordinatorTxs = append(l1CoordinatorTxs, *newL1CoordTx)
  208. accAuths = append(accAuths, txsel.coordAccount.AccountCreationAuth)
  209. }
  210. l2Txs = append(l2Txs, l2Txs0[i])
  211. }
  212. var validTxs []common.PoolL2Tx
  213. // iterate over l2TxsRaw
  214. // - check Nonces
  215. // - if needed, create new L1CoordinatorTxs for unexisting ToIdx
  216. // - keep used accAuths
  217. // - put the valid txs into validTxs array
  218. for i := 0; i < len(l2Txs); i++ {
  219. // check if Nonce is correct
  220. nonce := noncesMap[l2Txs[i].FromIdx]
  221. if l2Txs[i].Nonce == nonce {
  222. noncesMap[l2Txs[i].FromIdx]++
  223. } else {
  224. // not valid Nonce at tx
  225. continue
  226. }
  227. // If tx.ToIdx>=256, tx.ToIdx should exist to localAccountsDB,
  228. // if so, tx is used. If tx.ToIdx==0, for an L2Tx will be the
  229. // case of TxToEthAddr or TxToBJJ, check if
  230. // tx.ToEthAddr/tx.ToBJJ exist in localAccountsDB, if yes tx is
  231. // used; if not, check if tx.ToEthAddr is in
  232. // AccountCreationAuthDB, if so, tx is used and L1CoordinatorTx
  233. // of CreateAccountAndDeposit is created. If tx.ToIdx==1, is a
  234. // Exit type and is used.
  235. if l2Txs[i].ToIdx == 0 { // ToEthAddr/ToBJJ case
  236. validL2Tx, l1CoordinatorTx, accAuth, err :=
  237. txsel.processTxToEthAddrBJJ(validTxs, selectionConfig,
  238. len(l1UserTxs), l1CoordinatorTxs, positionL1, l2Txs[i])
  239. if err != nil {
  240. log.Debug(err)
  241. continue
  242. }
  243. if accAuth != nil && l1CoordinatorTx != nil {
  244. accAuths = append(accAuths, accAuth.Signature)
  245. l1CoordinatorTxs = append(l1CoordinatorTxs, *l1CoordinatorTx)
  246. positionL1++
  247. }
  248. if validL2Tx != nil {
  249. validTxs = append(validTxs, *validL2Tx)
  250. }
  251. } else if l2Txs[i].ToIdx >= common.IdxUserThreshold {
  252. receiverAcc, err := txsel.localAccountsDB.GetAccount(l2Txs[i].ToIdx)
  253. if err != nil {
  254. // tx not valid
  255. log.Debugw("invalid L2Tx: ToIdx not found in StateDB",
  256. "ToIdx", l2Txs[i].ToIdx)
  257. continue
  258. }
  259. if l2Txs[i].ToEthAddr != common.EmptyAddr {
  260. if l2Txs[i].ToEthAddr != receiverAcc.EthAddr {
  261. log.Debugw("invalid L2Tx: ToEthAddr does not correspond to the Account.EthAddr",
  262. "ToIdx", l2Txs[i].ToIdx, "tx.ToEthAddr", l2Txs[i].ToEthAddr,
  263. "account.EthAddr", receiverAcc.EthAddr)
  264. continue
  265. }
  266. }
  267. if l2Txs[i].ToBJJ != common.EmptyBJJComp {
  268. if l2Txs[i].ToBJJ != receiverAcc.BJJ {
  269. log.Debugw("invalid L2Tx: ToBJJ does not correspond to the Account.BJJ",
  270. "ToIdx", l2Txs[i].ToIdx, "tx.ToEthAddr", l2Txs[i].ToBJJ,
  271. "account.BJJ", receiverAcc.BJJ)
  272. continue
  273. }
  274. }
  275. // Account found in the DB, include the l2Tx in the selection
  276. validTxs = append(validTxs, l2Txs[i])
  277. } else if l2Txs[i].ToIdx == common.Idx(1) {
  278. // valid txs (of Exit type)
  279. validTxs = append(validTxs, l2Txs[i])
  280. }
  281. }
  282. // Process L1CoordinatorTxs
  283. for i := 0; i < len(l1CoordinatorTxs); i++ {
  284. _, _, _, _, err := tp.ProcessL1Tx(nil, &l1CoordinatorTxs[i])
  285. if err != nil {
  286. return nil, nil, nil, nil, nil, tracerr.Wrap(err)
  287. }
  288. }
  289. // get CoordIdxsMap for the TokenIDs
  290. coordIdxsMap := make(map[common.TokenID]common.Idx)
  291. for i := 0; i < len(l2Txs); i++ {
  292. // get TokenID from tx.Sender
  293. accSender, err := tp.StateDB().GetAccount(l2Txs[i].FromIdx)
  294. if err != nil {
  295. return nil, nil, nil, nil, nil, tracerr.Wrap(err)
  296. }
  297. tokenID := accSender.TokenID
  298. coordIdx, err := txsel.getCoordIdx(tokenID)
  299. if err != nil {
  300. // if err is db.ErrNotFound, should not happen, as all
  301. // the l2Txs.TokenID should have a CoordinatorIdx
  302. // created in the DB at this point
  303. return nil, nil, nil, nil, nil, tracerr.Wrap(err)
  304. }
  305. coordIdxsMap[tokenID] = coordIdx
  306. }
  307. var coordIdxs []common.Idx
  308. tp.AccumulatedFees = make(map[common.Idx]*big.Int)
  309. for _, idx := range coordIdxsMap {
  310. tp.AccumulatedFees[idx] = big.NewInt(0)
  311. coordIdxs = append(coordIdxs, idx)
  312. }
  313. // sort CoordIdxs
  314. sort.SliceStable(coordIdxs, func(i, j int) bool {
  315. return coordIdxs[i] < coordIdxs[j]
  316. })
  317. // get most profitable L2-tx
  318. maxL2Txs := int(selectionConfig.TxProcessorConfig.MaxTx) -
  319. len(l1UserTxs) - len(l1CoordinatorTxs)
  320. selectedL2Txs := l2Txs
  321. if len(l2Txs) > maxL2Txs {
  322. selectedL2Txs = selectedL2Txs[:maxL2Txs]
  323. }
  324. var finalL2Txs []common.PoolL2Tx
  325. for i := 0; i < len(selectedL2Txs); i++ {
  326. _, _, _, err = tp.ProcessL2Tx(coordIdxsMap, nil, nil, &selectedL2Txs[i])
  327. if err != nil {
  328. // the error can be due not valid tx data, or due other
  329. // cases (such as StateDB error). At this initial
  330. // version of the TxSelector, we discard the L2Tx and
  331. // log the error, assuming that this will be iterated
  332. // in a near future.
  333. log.Error(err)
  334. continue
  335. }
  336. finalL2Txs = append(finalL2Txs, selectedL2Txs[i])
  337. }
  338. // distribute the AccumulatedFees from the processed L2Txs into the
  339. // Coordinator Idxs
  340. for idx, accumulatedFee := range tp.AccumulatedFees {
  341. cmp := accumulatedFee.Cmp(big.NewInt(0))
  342. if cmp == 1 { // accumulatedFee>0
  343. // send the fee to the Idx of the Coordinator for the TokenID
  344. accCoord, err := txsel.localAccountsDB.GetAccount(idx)
  345. if err != nil {
  346. log.Errorw("Can not distribute accumulated fees to coordinator account: No coord Idx to receive fee", "idx", idx)
  347. return nil, nil, nil, nil, nil, tracerr.Wrap(err)
  348. }
  349. accCoord.Balance = new(big.Int).Add(accCoord.Balance, accumulatedFee)
  350. _, err = txsel.localAccountsDB.UpdateAccount(idx, accCoord)
  351. if err != nil {
  352. log.Error(err)
  353. return nil, nil, nil, nil, nil, tracerr.Wrap(err)
  354. }
  355. }
  356. }
  357. err = tp.StateDB().MakeCheckpoint()
  358. if err != nil {
  359. return nil, nil, nil, nil, nil, tracerr.Wrap(err)
  360. }
  361. return coordIdxs, accAuths, l1UserTxs, l1CoordinatorTxs, finalL2Txs, nil
  362. }
  363. // processTxsToEthAddrBJJ process the common.PoolL2Tx in the case where
  364. // ToIdx==0, which can be the tx type of ToEthAddr or ToBJJ. If the receiver
  365. // does not have an account yet, a new L1CoordinatorTx of type
  366. // CreateAccountDeposit (with 0 as DepositAmount) is created and added to the
  367. // l1CoordinatorTxs array, and then the PoolL2Tx is added into the validTxs
  368. // array.
  369. func (txsel *TxSelector) processTxToEthAddrBJJ(validTxs []common.PoolL2Tx,
  370. selectionConfig *SelectionConfig, nL1UserTxs int, l1CoordinatorTxs []common.L1Tx,
  371. positionL1 int, l2Tx common.PoolL2Tx) (*common.PoolL2Tx, *common.L1Tx,
  372. *common.AccountCreationAuth, error) {
  373. // if L2Tx needs a new L1CoordinatorTx of CreateAccount type, and a
  374. // previous L2Tx in the current process already created a
  375. // L1CoordinatorTx of this type, in the DB there still seem that needs
  376. // to create a new L1CoordinatorTx, but as is already created, the tx
  377. // is valid
  378. if checkAlreadyPendingToCreate(l1CoordinatorTxs, l2Tx.TokenID, l2Tx.ToEthAddr, l2Tx.ToBJJ) {
  379. return &l2Tx, nil, nil, nil
  380. }
  381. var l1CoordinatorTx *common.L1Tx
  382. var accAuth *common.AccountCreationAuth
  383. if !bytes.Equal(l2Tx.ToEthAddr.Bytes(), common.EmptyAddr.Bytes()) &&
  384. !bytes.Equal(l2Tx.ToEthAddr.Bytes(), common.FFAddr.Bytes()) {
  385. // case: ToEthAddr != 0x00 neither 0xff
  386. if l2Tx.ToBJJ != common.EmptyBJJComp {
  387. // case: ToBJJ!=0:
  388. // if idx exist for EthAddr&BJJ use it
  389. _, err := txsel.localAccountsDB.GetIdxByEthAddrBJJ(l2Tx.ToEthAddr,
  390. l2Tx.ToBJJ, l2Tx.TokenID)
  391. if err == nil {
  392. // account for ToEthAddr&ToBJJ already exist,
  393. // there is no need to create a new one.
  394. // tx valid, StateDB will use the ToIdx==0 to define the AuxToIdx
  395. return &l2Tx, nil, nil, nil
  396. }
  397. // if not, check if AccountCreationAuth exist for that
  398. // ToEthAddr
  399. accAuth, err = txsel.l2db.GetAccountCreationAuth(l2Tx.ToEthAddr)
  400. if err != nil {
  401. // not found, l2Tx will not be added in the selection
  402. return nil, nil, nil, tracerr.Wrap(fmt.Errorf("invalid L2Tx: ToIdx not found in StateDB, neither ToEthAddr found in AccountCreationAuths L2DB. ToIdx: %d, ToEthAddr: %s",
  403. l2Tx.ToIdx, l2Tx.ToEthAddr.Hex()))
  404. }
  405. if accAuth.BJJ != l2Tx.ToBJJ {
  406. // if AccountCreationAuth.BJJ is not the same
  407. // than in the tx, tx is not accepted
  408. return nil, nil, nil, tracerr.Wrap(fmt.Errorf("invalid L2Tx: ToIdx not found in StateDB, neither ToEthAddr & ToBJJ found in AccountCreationAuths L2DB. ToIdx: %d, ToEthAddr: %s, ToBJJ: %s",
  409. l2Tx.ToIdx, l2Tx.ToEthAddr.Hex(), l2Tx.ToBJJ.String()))
  410. }
  411. } else {
  412. // case: ToBJJ==0:
  413. // if idx exist for EthAddr use it
  414. _, err := txsel.localAccountsDB.GetIdxByEthAddr(l2Tx.ToEthAddr, l2Tx.TokenID)
  415. if err == nil {
  416. // account for ToEthAddr already exist,
  417. // there is no need to create a new one.
  418. // tx valid, StateDB will use the ToIdx==0 to define the AuxToIdx
  419. return &l2Tx, nil, nil, nil
  420. }
  421. // if not, check if AccountCreationAuth exist for that ToEthAddr
  422. accAuth, err = txsel.l2db.GetAccountCreationAuth(l2Tx.ToEthAddr)
  423. if err != nil {
  424. // not found, l2Tx will not be added in the selection
  425. return nil, nil, nil, tracerr.Wrap(fmt.Errorf("invalid L2Tx: ToIdx not found in StateDB, neither ToEthAddr found in AccountCreationAuths L2DB. ToIdx: %d, ToEthAddr: %s",
  426. l2Tx.ToIdx, l2Tx.ToEthAddr))
  427. }
  428. }
  429. // create L1CoordinatorTx for the accountCreation
  430. l1CoordinatorTx = &common.L1Tx{
  431. Position: positionL1,
  432. UserOrigin: false,
  433. FromEthAddr: accAuth.EthAddr,
  434. FromBJJ: accAuth.BJJ,
  435. TokenID: l2Tx.TokenID,
  436. Amount: big.NewInt(0),
  437. DepositAmount: big.NewInt(0),
  438. Type: common.TxTypeCreateAccountDeposit,
  439. }
  440. } else if bytes.Equal(l2Tx.ToEthAddr.Bytes(), common.FFAddr.Bytes()) &&
  441. l2Tx.ToBJJ != common.EmptyBJJComp {
  442. // if idx exist for EthAddr&BJJ use it
  443. _, err := txsel.localAccountsDB.GetIdxByEthAddrBJJ(l2Tx.ToEthAddr, l2Tx.ToBJJ,
  444. l2Tx.TokenID)
  445. if err == nil {
  446. // account for ToEthAddr&ToBJJ already exist, (where ToEthAddr==0xff)
  447. // there is no need to create a new one.
  448. // tx valid, StateDB will use the ToIdx==0 to define the AuxToIdx
  449. return &l2Tx, nil, nil, nil
  450. }
  451. // if idx don't exist for EthAddr&BJJ, coordinator can create a
  452. // new account without L1Authorization, as ToEthAddr==0xff
  453. // create L1CoordinatorTx for the accountCreation
  454. l1CoordinatorTx = &common.L1Tx{
  455. Position: positionL1,
  456. UserOrigin: false,
  457. FromEthAddr: l2Tx.ToEthAddr,
  458. FromBJJ: l2Tx.ToBJJ,
  459. TokenID: l2Tx.TokenID,
  460. Amount: big.NewInt(0),
  461. DepositAmount: big.NewInt(0),
  462. Type: common.TxTypeCreateAccountDeposit,
  463. }
  464. }
  465. if len(l1CoordinatorTxs) >= int(selectionConfig.MaxL1UserTxs)-nL1UserTxs {
  466. // L2Tx discarded
  467. return nil, nil, nil, tracerr.Wrap(fmt.Errorf("L2Tx discarded due not slots for L1CoordinatorTx to create a new account for receiver of L2Tx"))
  468. }
  469. return &l2Tx, l1CoordinatorTx, accAuth, nil
  470. }
  471. func checkAlreadyPendingToCreate(l1CoordinatorTxs []common.L1Tx, tokenID common.TokenID,
  472. addr ethCommon.Address, bjj babyjub.PublicKeyComp) bool {
  473. for i := 0; i < len(l1CoordinatorTxs); i++ {
  474. if bytes.Equal(l1CoordinatorTxs[i].FromEthAddr.Bytes(), addr.Bytes()) &&
  475. l1CoordinatorTxs[i].TokenID == tokenID &&
  476. l1CoordinatorTxs[i].FromBJJ == bjj {
  477. return true
  478. }
  479. }
  480. return false
  481. }
  482. // getL2Profitable returns the profitable selection of L2Txssorted by Nonce
  483. func (txsel *TxSelector) getL2Profitable(l2Txs []common.PoolL2Tx, max uint32) []common.PoolL2Tx {
  484. sort.Sort(txs(l2Txs))
  485. if len(l2Txs) < int(max) {
  486. return l2Txs
  487. }
  488. l2Txs = l2Txs[:max]
  489. // sort l2Txs by Nonce. This can be done in many different ways, what
  490. // is needed is to output the l2Txs where the Nonce of l2Txs for each
  491. // Account is sorted, but the l2Txs can not be grouped by sender Account
  492. // neither by Fee. This is because later on the Nonces will need to be
  493. // sequential for the zkproof generation.
  494. sort.SliceStable(l2Txs, func(i, j int) bool {
  495. return l2Txs[i].Nonce < l2Txs[j].Nonce
  496. })
  497. return l2Txs
  498. }