From 2d272548b2da8fbbe965ccc2be48d9476ed52208 Mon Sep 17 00:00:00 2001 From: arnaucube Date: Mon, 30 Nov 2020 14:15:02 +0100 Subject: [PATCH] Rm unused ETHCLIENT_DIAL_URL --- .github/workflows/test.yml | 1 - README.md | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 868bbc3..84e1227 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -21,6 +21,5 @@ jobs: - name: Test env: POSTGRES_PASS: ${{ secrets.POSTGRES_PASS }} - ETHCLIENT_DIAL_URL: ${{ secrets.ETHCLIENT_DIAL_URL }} GOARCH: ${{ matrix.goarch }} run: go test -p 1 ./... diff --git a/README.md b/README.md index 1121a3e..d9bbb61 100644 --- a/README.md +++ b/README.md @@ -13,14 +13,14 @@ POSTGRES_PASS=yourpasswordhere; sudo docker run --rm --name hermez-db-test -p 54 - Then, run the tests with the password as env var ``` -POSTGRES_PASS=yourpasswordhere ETHCLIENT_DIAL_URL=yourethereumurlhere go test -p 1 ./... +POSTGRES_PASS=yourpasswordhere go test -p 1 ./... ``` NOTE: `-p 1` forces execution of package test in serial. Otherwise they may be executed in paralel and the test may find unexpected entries in the SQL databse because it's shared among all tests. -- There is an extra temporal option that allows to run the API server through the Go tests. This should be removed once the API can be properly initialized, with data from the synchronizer and so on. To use this, run `FAKE_SERVER=yes POSTGRES_PASS=yourpasswordhere ETHCLIENT_DIAL_URL=yourethereumurlhere go test -timeout 0 ./api -p 1 -count 1 -v` +- There is an extra temporal option that allows to run the API server through the Go tests. This should be removed once the API can be properly initialized, with data from the synchronizer and so on. To use this, run `FAKE_SERVER=yes POSTGRES_PASS=yourpasswordhere go test -timeout 0 ./api -p 1 -count 1 -v` ## Lint