Update node and apply some fixes

- Node
	- Load Coordinator Fee Account from config
		- Sign the AccountCreationMsg to generate the
		  AccountCreationAuth
		- Resolve #465
	- Wait for synchronizer termination before stopping coordinator to avoid
	  getting stuck when closing in the following case:
		- The coordinator stops reading the synchronizer msg channel,
		  and the node gets stuck sending a message to that channel.
- Common
	- Move account creation auth signature code to common.
	- Update RollupConstInputSHAConstantBytes
- Coordinator
	- Set batch status in the debug file
	- Propagate SCVariables on reorg
	- Pipeline: Get SCVariables updates
		- Resolve #457
	- Fix off by 1 error in Pipeline.shouldL1L2Batch() (which shouldn't have
	  caused any problem, but it was not right)
- KVDB
	- Delete future checkpoints after reset
	- In `ResetFromSynchronizer`, remove all checkpoints first, and follow
	  the same logic as `reset()`.
- Cli
	- Add command to generate a BabyJubJub key pair (to be used for the
	  Coordinator Fee Account)
- Node
	- Adjust example config `Coordinator.L1BatchTimeoutPerc` to avoid
	  missing the L1Batch deadline with the following setup:
		- a block is mined every 2 seconds
		- single proof server that takes 2 seconds to calculate a proof
- TxProcessor
	- Close temporary pebble used for the exit tree after usage.
		- Resolve #463

common/accountcreationauths.go

@@ -49,12 +49,34 @@ func (a *AccountCreationAuth) HashToSign(chainID uint16,
 	return ethCrypto.Keccak256Hash(b).Bytes(), nil
 }
 
+// Sign signs the account creation authorization message using the provided
+// `signHash` function, and stores the signaure in `a.Signature`.  `signHash`
+// should do an ethereum signature using the account corresponding to
+// `a.EthAddr`.  The `signHash` function is used to make signig flexible: in
+// tests we sign directly using the private key, outside tests we sign using
+// the keystore (which never exposes the private key).
+func (a *AccountCreationAuth) Sign(signHash func(hash []byte) ([]byte, error),
+	chainID uint16, hermezContractAddr ethCommon.Address) error {
+	hash, err := a.HashToSign(chainID, hermezContractAddr)
+	if err != nil {
+		return err
+	}
+	sig, err := signHash(hash)
+	if err != nil {
+		return err
+	}
+	sig[64] += 27
+	a.Signature = sig
+	a.Timestamp = time.Now()
+	return nil
+}
+
 // VerifySignature ensures that the Signature is done with the EthAddr, for the
 // chainID and hermezContractAddress passed by parameter
 func (a *AccountCreationAuth) VerifySignature(chainID uint16,
 	hermezContractAddr ethCommon.Address) bool {
 	// Calculate hash to be signed
-	msg, err := a.HashToSign(chainID, hermezContractAddr)
+	hash, err := a.HashToSign(chainID, hermezContractAddr)
 	if err != nil {
 		return false
 	}
@@ -64,7 +86,7 @@ func (a *AccountCreationAuth) VerifySignature(chainID uint16,
 	sig[64] -= 27
 
 	// Get public key from Signature
-	pubKBytes, err := ethCrypto.Ecrecover(msg, sig[:])
+	pubKBytes, err := ethCrypto.Ecrecover(hash, sig[:])
 	if err != nil {
 		return false
 	}

common/accountcreationauths_test.go

@@ -11,7 +11,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestAccountCreationAuthVerification(t *testing.T) {
+func TestAccountCreationAuthSignVerify(t *testing.T) {
 	// Ethereum key
 	ethSk, err := ethCrypto.HexToECDSA("fad9c8855b740a0b7ed4c221dbad0f33a83a49cad6b3fe8d5817ac83d38b6a19")
 	require.NoError(t, err)
@@ -21,7 +21,7 @@ func TestAccountCreationAuthVerification(t *testing.T) {
 	var sk babyjub.PrivateKey
 	_, err = hex.Decode(sk[:],
 		[]byte("0001020304050607080900010203040506070809000102030405060708090001"))
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	chainID := uint16(0)
 	hermezContractAddr := ethCommon.HexToAddress("0xc344E203a046Da13b0B4467EB7B3629D0C99F6E6")
@@ -29,16 +29,22 @@ func TestAccountCreationAuthVerification(t *testing.T) {
 		EthAddr: ethAddr,
 		BJJ:     sk.Public().Compress(),
 	}
-	msg, err := a.HashToSign(chainID, hermezContractAddr)
-	assert.NoError(t, err)
-	assert.Equal(t, "4f8df75e96fdce1ac90bb2f8d81c42047600f85bfcef80ce3b91c2a2afc58c1e",
-		hex.EncodeToString(msg))
 
-	// sign AccountCreationAuth with eth key
-	sig, err := ethCrypto.Sign(msg, ethSk)
-	assert.NoError(t, err)
+	// Sign using the Sign function (stores signature in a.Signature)
+	err = a.Sign(func(hash []byte) ([]byte, error) {
+		return ethCrypto.Sign(hash, ethSk)
+	}, chainID, hermezContractAddr)
+	require.NoError(t, err)
+
+	// Hash and sign manually and compare the generated signature
+	hash, err := a.HashToSign(chainID, hermezContractAddr)
+	require.NoError(t, err)
+	assert.Equal(t, "4f8df75e96fdce1ac90bb2f8d81c42047600f85bfcef80ce3b91c2a2afc58c1e",
+		hex.EncodeToString(hash))
+	sig, err := ethCrypto.Sign(hash, ethSk)
+	require.NoError(t, err)
 	sig[64] += 27
-	a.Signature = sig
+	assert.Equal(t, sig, a.Signature)
 
 	assert.True(t, a.VerifySignature(chainID, hermezContractAddr))
 }
@@ -107,7 +113,7 @@ func TestAccountCreationAuthJSComp(t *testing.T) {
 		// BabyJubJub key
 		pkCompStr := tv.pkCompStr
 		pkComp, err := BJJFromStringWithChecksum(pkCompStr)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 
 		chainID := tv.chainID
 		hermezContractAddr := ethCommon.HexToAddress(tv.hermezContractAddr)
@@ -122,13 +128,13 @@ func TestAccountCreationAuthJSComp(t *testing.T) {
 		assert.Equal(t, 120+len(EthMsgPrefix)+len([]byte("120")), len(toHash))
 
 		msg, err := a.HashToSign(chainID, hermezContractAddr)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		assert.Equal(t, tv.hashExpected,
 			hex.EncodeToString(msg))
 
 		// sign AccountCreationAuth with eth key
 		sig, err := ethCrypto.Sign(msg, ethSk)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 		sig[64] += 27
 		assert.Equal(t, tv.sigExpected,
 			hex.EncodeToString(sig))

common/ethrollup.go

@@ -33,7 +33,7 @@ const (
 	// RollupConstInputSHAConstantBytes [6 bytes] lastIdx + [6 bytes] newLastIdx  + [32 bytes] stateRoot  + [32 bytes] newStRoot  + [32 bytes] newExitRoot +
 	// [_MAX_L1_TX * _L1_USER_TOTALBYTES bytes] l1TxsData + totalL2TxsDataLength + feeIdxCoordinatorLength + [2 bytes] chainID =
 	// 18542 bytes +  totalL2TxsDataLength + feeIdxCoordinatorLength
-	RollupConstInputSHAConstantBytes = 18542
+	RollupConstInputSHAConstantBytes = 18546
 	// RollupConstNumBuckets Number of buckets
 	RollupConstNumBuckets = 5
 	// RollupConstMaxWithdrawalDelay max withdrawal delay in seconds