fixed pr remarks

api/api_test.go

@@ -499,7 +499,7 @@ func TestMain(m *testing.M) {
 	// Slot 7
 	nextForgers[6].Coordinator = nonBootForger
 
-	var buckets [common.RollupConstNumBuckets]common.BucketParams
+	buckets := make([]common.BucketParams, 5)
 	for i := range buckets {
 		buckets[i].CeilUSD = big.NewInt(int64(i) * 10)
 		buckets[i].BlockStamp = big.NewInt(int64(i) * 100)

api/config.go

@@ -41,7 +41,6 @@ func newRollupConstants(publicConstants common.RollupConstants) *rollupConstants
 		MaxL1UserTx:             common.RollupConstMaxL1UserTx,
 		MaxL1Tx:                 common.RollupConstMaxL1Tx,
 		InputSHAConstantBytes:   common.RollupConstInputSHAConstantBytes,
-		NumBuckets:              common.RollupConstNumBuckets,
 		MaxWithdrawalDelay:      common.RollupConstMaxWithdrawalDelay,
 		ExchangeMultiplier:      common.RollupConstExchangeMultiplier,
 	}

api/swagger.yml

@@ -2729,11 +2729,11 @@ components:
             properties:
               ceilUSD:
                 type: string
-                description: Max USD value
+                description: Max USD value that bucket holds
                 example: "1000"
               blockStamp:
                 type: string
-                description: Block stamp
+                description: Block number of the last bucket update
                 example: "1"
               withdrawals:
                 type: string
@@ -2741,11 +2741,11 @@ components:
                 example: "4"
               rateBlocks:
                 type: string
-                description: Rate of blocks
+                description: rateBlocks every `rateBlocks` blocks add `rateWithdrawals` withdrawal
                 example: "2"
               rateWithdrawals:
                 type: string
-                description: Rate of withdrawals
+                description: add `rateWithdrawals` every `rateBlocks`
                 example: "3"
               maxWithdrawals:
                 type: string