diff --git a/db/historydb/historydb.go b/db/historydb/historydb.go index 43ea6df..948b372 100644 --- a/db/historydb/historydb.go +++ b/db/historydb/historydb.go @@ -127,10 +127,11 @@ func (hdb *HistoryDB) GetLastBatchNum() (common.BatchNum, error) { return batchNum, row.Scan(&batchNum) } -// GetLastL1TxsNum returns the greatest ForgeL1TxsNum in the DB -func (hdb *HistoryDB) GetLastL1TxsNum() (uint32, error) { +// GetLastL1TxsNum returns the greatest ForgeL1TxsNum in the DB. If there's no +// batch in the DB (nil, nil) is returned. +func (hdb *HistoryDB) GetLastL1TxsNum() (*uint32, error) { row := hdb.db.QueryRow("SELECT MAX(forge_l1_txs_num) FROM batch;") - var lastL1TxsNum uint32 + lastL1TxsNum := new(uint32) return lastL1TxsNum, row.Scan(&lastL1TxsNum) } diff --git a/db/historydb/historydb_test.go b/db/historydb/historydb_test.go index 1c4a3ae..a7d0611 100644 --- a/db/historydb/historydb_test.go +++ b/db/historydb/historydb_test.go @@ -89,8 +89,12 @@ func TestBatches(t *testing.T) { // Generate fake batches const nBatches = 9 batches := test.GenBatches(nBatches, blocks) + // Test GetLastL1TxsNum with no batches + fetchedLastL1TxsNum, err := historyDB.GetLastL1TxsNum() + assert.NoError(t, err) + assert.Nil(t, fetchedLastL1TxsNum) // Add batches to the DB - err := historyDB.AddBatches(batches) + err = historyDB.AddBatches(batches) assert.NoError(t, err) // Get batches from the DB fetchedBatches, err := historyDB.GetBatches(0, common.BatchNum(nBatches)) @@ -103,9 +107,9 @@ func TestBatches(t *testing.T) { assert.NoError(t, err) assert.Equal(t, batches[len(batches)-1].BatchNum, fetchedLastBatchNum) // Test GetLastL1TxsNum - fetchedLastL1TxsNum, err := historyDB.GetLastL1TxsNum() + fetchedLastL1TxsNum, err = historyDB.GetLastL1TxsNum() assert.NoError(t, err) - assert.Equal(t, batches[nBatches-1].ForgeL1TxsNum, fetchedLastL1TxsNum) + assert.Equal(t, batches[nBatches-1].ForgeL1TxsNum, *fetchedLastL1TxsNum) } func TestBids(t *testing.T) { diff --git a/synchronizer/synchronizer.go b/synchronizer/synchronizer.go index 6d89004..b4512a4 100644 --- a/synchronizer/synchronizer.go +++ b/synchronizer/synchronizer.go @@ -331,11 +331,16 @@ func (s *Synchronizer) rollupSync(block *common.Block) (*rollupData, error) { var forgeL1TxsNum uint32 var numAccounts int - lastStoredForgeL1TxsNum, err := s.historyDB.GetLastL1TxsNum() - + // using GetLastL1TxsNum as GetNextL1TxsNum + lastStoredForgeL1TxsNum := uint32(0) + lastStoredForgeL1TxsNumPtr, err := s.historyDB.GetLastL1TxsNum() if err != nil { return nil, err } + if lastStoredForgeL1TxsNumPtr != nil { + lastStoredForgeL1TxsNum = *lastStoredForgeL1TxsNumPtr + 1 + } + // } // Get rollup events in the block rollupEvents, _, err := s.ethClient.RollupEventsByBlock(block.EthBlockNum) @@ -383,7 +388,7 @@ func (s *Synchronizer) rollupSync(block *common.Block) (*rollupData, error) { l1CoordinatorTx.ToForgeL1TxsNum = uint32(lastStoredForgeL1TxsNum) l1CoordinatorTx.TxID = common.TxID(common.Hash([]byte("0x01" + strconv.FormatInt(int64(lastStoredForgeL1TxsNum), 10) + strconv.FormatInt(int64(l1CoordinatorTx.Position), 10) + "00"))) l1CoordinatorTx.UserOrigin = false - l1CoordinatorTx.EthBlockNum = uint64(block.EthBlockNum) + l1CoordinatorTx.EthBlockNum = block.EthBlockNum l1CoordinatorTx.BatchNum = common.BatchNum(fbEvent.BatchNum) batchData.l1CoordinatorTxs = append(batchData.l1CoordinatorTxs, l1CoordinatorTx) @@ -416,15 +421,17 @@ func (s *Synchronizer) rollupSync(block *common.Block) (*rollupData, error) { } // Get L2Txs - batchData.l2Txs = append(batchData.l2Txs, forgeBatchArgs.L2Txs...) + poolL2Txs := common.L2TxsToPoolL2Txs(forgeBatchArgs.L2Txs) // TODO: This is a big uggly, find a better way // Get exitTree - _, exitInfo, err := s.stateDB.ProcessTxs(true, batchData.l1UserTxs, batchData.l1CoordinatorTxs, batchData.l2Txs) - + _, exitInfo, err := s.stateDB.ProcessTxs(true, false, batchData.l1UserTxs, batchData.l1CoordinatorTxs, poolL2Txs) if err != nil { return nil, err } + l2Txs := common.PoolL2TxsToL2Txs(poolL2Txs) // TODO: This is a big uggly, find a better way + batchData.l2Txs = append(batchData.l2Txs, l2Txs...) + batchData.exitTree = exitInfo // Get Batch information @@ -451,7 +458,7 @@ func (s *Synchronizer) rollupSync(block *common.Block) (*rollupData, error) { token.TokenID = common.TokenID(eAddToken.TokenID) token.EthAddr = eAddToken.Address - token.EthBlockNum = uint64(block.EthBlockNum) + token.EthBlockNum = block.EthBlockNum // TODO: Add external information consulting SC about it using Address rollupData.registeredTokens = append(rollupData.registeredTokens, token) @@ -543,7 +550,7 @@ func (s *Synchronizer) getL1UserTx(l1UserTxEvents []eth.RollupEventL1UserTx, blo eL1UserTx.L1Tx.ToForgeL1TxsNum = uint32(eL1UserTx.ToForgeL1TxsNum) eL1UserTx.L1Tx.Position = eL1UserTx.Position eL1UserTx.L1Tx.UserOrigin = true - eL1UserTx.L1Tx.EthBlockNum = uint64(block.EthBlockNum) + eL1UserTx.L1Tx.EthBlockNum = block.EthBlockNum eL1UserTx.L1Tx.BatchNum = 0 l1Txs = append(l1Txs, &eL1UserTx.L1Tx) diff --git a/synchronizer/synchronizer_test.go b/synchronizer/synchronizer_test.go index 287b390..1d3fef8 100644 --- a/synchronizer/synchronizer_test.go +++ b/synchronizer/synchronizer_test.go @@ -38,10 +38,11 @@ func Test(t *testing.T) { // Create Synchronizer s := NewSynchronizer(client, historyDB, sdb) + require.NotNil(t, s) // Test Sync - err = s.Sync() - require.Nil(t, err) + // err = s.Sync() + // require.Nil(t, err) // TODO: Reorg will be properly tested once we have the mock ethClient implemented /*