mirror of
https://github.com/arnaucube/hermez-node.git
synced 2026-02-07 03:16:45 +01:00
Compare commits
13 Commits
v0.1.0
...
feature/ge
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
0511acd5e6 | ||
|
|
8d087e2727 | ||
|
|
22ffd93292 | ||
|
|
b565c9da1a | ||
|
|
7901705dfd | ||
|
|
3a706e7775 | ||
|
|
c84b3a4d0f | ||
|
|
3f643f022a | ||
|
|
b8d339d568 | ||
|
|
6c1c157bc3 | ||
|
|
f9ddf88c93 | ||
|
|
a1eea43443 | ||
|
|
2125812e90 |
1
.gitignore
vendored
1
.gitignore
vendored
@@ -1 +1,2 @@
|
|||||||
bin/
|
bin/
|
||||||
|
dist/
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
before:
|
before:
|
||||||
hooks:
|
hooks:
|
||||||
- go mod download
|
- go mod download
|
||||||
|
- make migration-pack
|
||||||
|
|
||||||
builds:
|
builds:
|
||||||
- main: ./cli/node/main.go
|
- main: ./cli/node/main.go
|
||||||
@@ -9,10 +10,8 @@ builds:
|
|||||||
goos:
|
goos:
|
||||||
- linux
|
- linux
|
||||||
- darwin
|
- darwin
|
||||||
- windows
|
goarch:
|
||||||
hooks:
|
- amd64
|
||||||
pre: make migration-pack
|
|
||||||
post: make migration-clean
|
|
||||||
|
|
||||||
archives:
|
archives:
|
||||||
- replacements:
|
- replacements:
|
||||||
|
|||||||
@@ -60,6 +60,7 @@ func NewAPI(
|
|||||||
// Transaction
|
// Transaction
|
||||||
v1.POST("/transactions-pool", a.postPoolTx)
|
v1.POST("/transactions-pool", a.postPoolTx)
|
||||||
v1.GET("/transactions-pool/:id", a.getPoolTx)
|
v1.GET("/transactions-pool/:id", a.getPoolTx)
|
||||||
|
v1.GET("/transactions-pool", a.getPoolTxs)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Add explorer endpoints
|
// Add explorer endpoints
|
||||||
|
|||||||
@@ -522,11 +522,16 @@ func TestMain(m *testing.M) {
|
|||||||
WithdrawalDelay: uint64(3000),
|
WithdrawalDelay: uint64(3000),
|
||||||
}
|
}
|
||||||
|
|
||||||
stateAPIUpdater = stateapiupdater.NewUpdater(hdb, nodeConfig, &common.SCVariables{
|
stateAPIUpdater, err = stateapiupdater.NewUpdater(hdb, nodeConfig, &common.SCVariables{
|
||||||
Rollup: rollupVars,
|
Rollup: rollupVars,
|
||||||
Auction: auctionVars,
|
Auction: auctionVars,
|
||||||
WDelayer: wdelayerVars,
|
WDelayer: wdelayerVars,
|
||||||
}, constants)
|
}, constants, &stateapiupdater.RecommendedFeePolicy{
|
||||||
|
PolicyType: stateapiupdater.RecommendedFeePolicyTypeAvgLastHour,
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
panic(err)
|
||||||
|
}
|
||||||
|
|
||||||
// Generate test data, as expected to be received/sended from/to the API
|
// Generate test data, as expected to be received/sended from/to the API
|
||||||
testCoords := genTestCoordinators(commonCoords)
|
testCoords := genTestCoordinators(commonCoords)
|
||||||
|
|||||||
@@ -109,7 +109,7 @@ func (a *API) getFullBatch(c *gin.Context) {
|
|||||||
// Fetch txs forged in the batch from historyDB
|
// Fetch txs forged in the batch from historyDB
|
||||||
maxTxsPerBatch := uint(2048) //nolint:gomnd
|
maxTxsPerBatch := uint(2048) //nolint:gomnd
|
||||||
txs, _, err := a.h.GetTxsAPI(
|
txs, _, err := a.h.GetTxsAPI(
|
||||||
nil, nil, nil, nil, batchNum, nil, nil, &maxTxsPerBatch, historydb.OrderAsc,
|
nil, nil, nil, nil, nil, batchNum, nil, nil, &maxTxsPerBatch, historydb.OrderAsc,
|
||||||
)
|
)
|
||||||
if err != nil && tracerr.Unwrap(err) != sql.ErrNoRows {
|
if err != nil && tracerr.Unwrap(err) != sql.ErrNoRows {
|
||||||
retSQLErr(err, c)
|
retSQLErr(err, c)
|
||||||
|
|||||||
@@ -96,6 +96,32 @@ func parseQueryBJJ(c querier) (*babyjub.PublicKeyComp, error) {
|
|||||||
return hezStringToBJJ(bjjStr, name)
|
return hezStringToBJJ(bjjStr, name)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func parseQueryPoolL2TxState(c querier) (*common.PoolL2TxState, error) {
|
||||||
|
const name = "state"
|
||||||
|
stateStr := c.Query(name)
|
||||||
|
if stateStr == "" {
|
||||||
|
return nil, nil
|
||||||
|
}
|
||||||
|
switch common.PoolL2TxState(stateStr) {
|
||||||
|
case common.PoolL2TxStatePending:
|
||||||
|
ret := common.PoolL2TxStatePending
|
||||||
|
return &ret, nil
|
||||||
|
case common.PoolL2TxStateForged:
|
||||||
|
ret := common.PoolL2TxStateForged
|
||||||
|
return &ret, nil
|
||||||
|
case common.PoolL2TxStateForging:
|
||||||
|
ret := common.PoolL2TxStateForging
|
||||||
|
return &ret, nil
|
||||||
|
case common.PoolL2TxStateInvalid:
|
||||||
|
ret := common.PoolL2TxStateInvalid
|
||||||
|
return &ret, nil
|
||||||
|
}
|
||||||
|
return nil, tracerr.Wrap(fmt.Errorf(
|
||||||
|
"invalid %s, %s is not a valid option. Check the valid options in the docmentation",
|
||||||
|
name, stateStr,
|
||||||
|
))
|
||||||
|
}
|
||||||
|
|
||||||
func parseQueryTxType(c querier) (*common.TxType, error) {
|
func parseQueryTxType(c querier) (*common.TxType, error) {
|
||||||
const name = "type"
|
const name = "type"
|
||||||
typeStr := c.Query(name)
|
typeStr := c.Query(name)
|
||||||
@@ -146,6 +172,18 @@ func parseIdx(c querier) (*common.Idx, error) {
|
|||||||
return stringToIdx(idxStr, name)
|
return stringToIdx(idxStr, name)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func parseFromIdx(c querier) (*common.Idx, error) {
|
||||||
|
const name = "fromAccountIndex"
|
||||||
|
idxStr := c.Query(name)
|
||||||
|
return stringToIdx(idxStr, name)
|
||||||
|
}
|
||||||
|
|
||||||
|
func parseToIdx(c querier) (*common.Idx, error) {
|
||||||
|
const name = "toAccountIndex"
|
||||||
|
idxStr := c.Query(name)
|
||||||
|
return stringToIdx(idxStr, name)
|
||||||
|
}
|
||||||
|
|
||||||
func parseExitFilters(c querier) (*common.TokenID, *ethCommon.Address, *babyjub.PublicKeyComp, *common.Idx, error) {
|
func parseExitFilters(c querier) (*common.TokenID, *ethCommon.Address, *babyjub.PublicKeyComp, *common.Idx, error) {
|
||||||
// TokenID
|
// TokenID
|
||||||
tid, err := parseQueryUint("tokenId", nil, 0, maxUint32, c)
|
tid, err := parseQueryUint("tokenId", nil, 0, maxUint32, c)
|
||||||
@@ -181,6 +219,47 @@ func parseExitFilters(c querier) (*common.TokenID, *ethCommon.Address, *babyjub.
|
|||||||
return tokenID, addr, bjj, idx, nil
|
return tokenID, addr, bjj, idx, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func parseTxsHistoryFilters(c querier) (*common.TokenID, *ethCommon.Address,
|
||||||
|
*babyjub.PublicKeyComp, *common.Idx, *common.Idx, error) {
|
||||||
|
// TokenID
|
||||||
|
tid, err := parseQueryUint("tokenId", nil, 0, maxUint32, c)
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, nil, nil, nil, tracerr.Wrap(err)
|
||||||
|
}
|
||||||
|
var tokenID *common.TokenID
|
||||||
|
if tid != nil {
|
||||||
|
tokenID = new(common.TokenID)
|
||||||
|
*tokenID = common.TokenID(*tid)
|
||||||
|
}
|
||||||
|
// Hez Eth addr
|
||||||
|
addr, err := parseQueryHezEthAddr(c)
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, nil, nil, nil, tracerr.Wrap(err)
|
||||||
|
}
|
||||||
|
// BJJ
|
||||||
|
bjj, err := parseQueryBJJ(c)
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, nil, nil, nil, tracerr.Wrap(err)
|
||||||
|
}
|
||||||
|
if addr != nil && bjj != nil {
|
||||||
|
return nil, nil, nil, nil, nil, tracerr.Wrap(errors.New("bjj and hezEthereumAddress params are incompatible"))
|
||||||
|
}
|
||||||
|
// from Idx
|
||||||
|
fromIdx, err := parseFromIdx(c)
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, nil, nil, nil, tracerr.Wrap(err)
|
||||||
|
}
|
||||||
|
// to Idx
|
||||||
|
toIdx, err := parseToIdx(c)
|
||||||
|
if err != nil {
|
||||||
|
return nil, nil, nil, nil, nil, tracerr.Wrap(err)
|
||||||
|
}
|
||||||
|
if (fromIdx != nil || toIdx != nil) && (addr != nil || bjj != nil || tokenID != nil) {
|
||||||
|
return nil, nil, nil, nil, nil, tracerr.Wrap(errors.New("accountIndex is incompatible with BJJ, hezEthereumAddress and tokenId"))
|
||||||
|
}
|
||||||
|
return tokenID, addr, bjj, fromIdx, toIdx, nil
|
||||||
|
}
|
||||||
|
|
||||||
func parseTokenFilters(c querier) ([]common.TokenID, []string, string, error) {
|
func parseTokenFilters(c querier) ([]common.TokenID, []string, string, error) {
|
||||||
idsStr := c.Query("ids")
|
idsStr := c.Query("ids")
|
||||||
symbolsStr := c.Query("symbols")
|
symbolsStr := c.Query("symbols")
|
||||||
|
|||||||
@@ -2,10 +2,12 @@ package stateapiupdater
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"database/sql"
|
"database/sql"
|
||||||
|
"fmt"
|
||||||
"sync"
|
"sync"
|
||||||
|
|
||||||
"github.com/hermeznetwork/hermez-node/common"
|
"github.com/hermeznetwork/hermez-node/common"
|
||||||
"github.com/hermeznetwork/hermez-node/db/historydb"
|
"github.com/hermeznetwork/hermez-node/db/historydb"
|
||||||
|
"github.com/hermeznetwork/hermez-node/log"
|
||||||
"github.com/hermeznetwork/tracerr"
|
"github.com/hermeznetwork/tracerr"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -17,11 +19,45 @@ type Updater struct {
|
|||||||
vars common.SCVariablesPtr
|
vars common.SCVariablesPtr
|
||||||
consts historydb.Constants
|
consts historydb.Constants
|
||||||
rw sync.RWMutex
|
rw sync.RWMutex
|
||||||
|
rfp *RecommendedFeePolicy
|
||||||
|
}
|
||||||
|
|
||||||
|
// RecommendedFeePolicy describes how the recommended fee is calculated
|
||||||
|
type RecommendedFeePolicy struct {
|
||||||
|
PolicyType RecommendedFeePolicyType `validate:"required"`
|
||||||
|
StaticValue float64
|
||||||
|
}
|
||||||
|
|
||||||
|
// RecommendedFeePolicyType describes the different available recommended fee strategies
|
||||||
|
type RecommendedFeePolicyType string
|
||||||
|
|
||||||
|
const (
|
||||||
|
// RecommendedFeePolicyTypeStatic always give the same StaticValue as recommended fee
|
||||||
|
RecommendedFeePolicyTypeStatic RecommendedFeePolicyType = "Static"
|
||||||
|
// RecommendedFeePolicyTypeAvgLastHour set the recommended fee using the average fee of the last hour
|
||||||
|
RecommendedFeePolicyTypeAvgLastHour RecommendedFeePolicyType = "AvgLastHour"
|
||||||
|
)
|
||||||
|
|
||||||
|
func (rfp *RecommendedFeePolicy) valid() bool {
|
||||||
|
switch rfp.PolicyType {
|
||||||
|
case RecommendedFeePolicyTypeStatic:
|
||||||
|
if rfp.StaticValue == 0 {
|
||||||
|
log.Warn("RcommendedFee is set to 0 USD, and the policy is static")
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
case RecommendedFeePolicyTypeAvgLastHour:
|
||||||
|
return true
|
||||||
|
default:
|
||||||
|
return false
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// NewUpdater creates a new Updater
|
// NewUpdater creates a new Updater
|
||||||
func NewUpdater(hdb *historydb.HistoryDB, config *historydb.NodeConfig, vars *common.SCVariables,
|
func NewUpdater(hdb *historydb.HistoryDB, config *historydb.NodeConfig, vars *common.SCVariables,
|
||||||
consts *historydb.Constants) *Updater {
|
consts *historydb.Constants, rfp *RecommendedFeePolicy) (*Updater, error) {
|
||||||
|
if ok := rfp.valid(); !ok {
|
||||||
|
return nil, tracerr.Wrap(fmt.Errorf("Invalid recommended fee policy: %v", rfp.PolicyType))
|
||||||
|
}
|
||||||
u := Updater{
|
u := Updater{
|
||||||
hdb: hdb,
|
hdb: hdb,
|
||||||
config: *config,
|
config: *config,
|
||||||
@@ -31,9 +67,10 @@ func NewUpdater(hdb *historydb.HistoryDB, config *historydb.NodeConfig, vars *co
|
|||||||
ForgeDelay: config.ForgeDelay,
|
ForgeDelay: config.ForgeDelay,
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
|
rfp: rfp,
|
||||||
}
|
}
|
||||||
u.SetSCVars(vars.AsPtr())
|
u.SetSCVars(vars.AsPtr())
|
||||||
return &u
|
return &u, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// Store the State in the HistoryDB
|
// Store the State in the HistoryDB
|
||||||
@@ -65,6 +102,16 @@ func (u *Updater) SetSCVars(vars *common.SCVariablesPtr) {
|
|||||||
|
|
||||||
// UpdateRecommendedFee update Status.RecommendedFee information
|
// UpdateRecommendedFee update Status.RecommendedFee information
|
||||||
func (u *Updater) UpdateRecommendedFee() error {
|
func (u *Updater) UpdateRecommendedFee() error {
|
||||||
|
switch u.rfp.PolicyType {
|
||||||
|
case RecommendedFeePolicyTypeStatic:
|
||||||
|
u.rw.Lock()
|
||||||
|
u.state.RecommendedFee = common.RecommendedFee{
|
||||||
|
ExistingAccount: u.rfp.StaticValue,
|
||||||
|
CreatesAccount: u.rfp.StaticValue,
|
||||||
|
CreatesAccountInternal: u.rfp.StaticValue,
|
||||||
|
}
|
||||||
|
u.rw.Unlock()
|
||||||
|
case RecommendedFeePolicyTypeAvgLastHour:
|
||||||
recommendedFee, err := u.hdb.GetRecommendedFee(u.config.MinFeeUSD, u.config.MaxFeeUSD)
|
recommendedFee, err := u.hdb.GetRecommendedFee(u.config.MinFeeUSD, u.config.MaxFeeUSD)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return tracerr.Wrap(err)
|
return tracerr.Wrap(err)
|
||||||
@@ -72,6 +119,10 @@ func (u *Updater) UpdateRecommendedFee() error {
|
|||||||
u.rw.Lock()
|
u.rw.Lock()
|
||||||
u.state.RecommendedFee = *recommendedFee
|
u.state.RecommendedFee = *recommendedFee
|
||||||
u.rw.Unlock()
|
u.rw.Unlock()
|
||||||
|
default:
|
||||||
|
return tracerr.New("Invalid recommende fee policy")
|
||||||
|
}
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -415,6 +415,55 @@ paths:
|
|||||||
application/json:
|
application/json:
|
||||||
schema:
|
schema:
|
||||||
$ref: '#/components/schemas/Error500'
|
$ref: '#/components/schemas/Error500'
|
||||||
|
get:
|
||||||
|
tags:
|
||||||
|
- Coordinator
|
||||||
|
summary: Get transactions that are in the pool.
|
||||||
|
operationId: getPoolTxs
|
||||||
|
parameters:
|
||||||
|
- name: state
|
||||||
|
in: query
|
||||||
|
required: false
|
||||||
|
description: State of the transactions, e.g. "pend"
|
||||||
|
schema:
|
||||||
|
$ref: '#/components/schemas/PoolL2TransactionState'
|
||||||
|
- name: fromAccountIndex
|
||||||
|
in: query
|
||||||
|
required: false
|
||||||
|
description: Id of the from account
|
||||||
|
schema:
|
||||||
|
$ref: '#/components/schemas/AccountIndex'
|
||||||
|
- name: toAccountIndex
|
||||||
|
in: query
|
||||||
|
required: false
|
||||||
|
description: Id of the to account
|
||||||
|
schema:
|
||||||
|
$ref: '#/components/schemas/AccountIndex'
|
||||||
|
responses:
|
||||||
|
'200':
|
||||||
|
description: Successful operation.
|
||||||
|
content:
|
||||||
|
application/json:
|
||||||
|
schema:
|
||||||
|
$ref: '#/components/schemas/PoolL2Transactions'
|
||||||
|
'400':
|
||||||
|
description: Bad request.
|
||||||
|
content:
|
||||||
|
application/json:
|
||||||
|
schema:
|
||||||
|
$ref: '#/components/schemas/Error400'
|
||||||
|
'404':
|
||||||
|
description: Not found.
|
||||||
|
content:
|
||||||
|
application/json:
|
||||||
|
schema:
|
||||||
|
$ref: '#/components/schemas/Error404'
|
||||||
|
'500':
|
||||||
|
description: Internal server error
|
||||||
|
content:
|
||||||
|
application/json:
|
||||||
|
schema:
|
||||||
|
$ref: '#/components/schemas/Error500'
|
||||||
'/transactions-pool/{id}':
|
'/transactions-pool/{id}':
|
||||||
get:
|
get:
|
||||||
tags:
|
tags:
|
||||||
@@ -487,10 +536,16 @@ paths:
|
|||||||
required: false
|
required: false
|
||||||
schema:
|
schema:
|
||||||
$ref: '#/components/schemas/BJJ'
|
$ref: '#/components/schemas/BJJ'
|
||||||
- name: accountIndex
|
- name: fromAccountIndex
|
||||||
in: query
|
in: query
|
||||||
required: false
|
required: false
|
||||||
description: Only get transactions sent from or to a specific account. Incompatible with the queries `tokenId`, `hezEthereumAddress` and `BJJ`.
|
description: Only get transactions sent from a specific account. Incompatible with the queries `tokenId`, `hezEthereumAddress` and `BJJ`.
|
||||||
|
schema:
|
||||||
|
$ref: '#/components/schemas/AccountIndex'
|
||||||
|
- name: toAccountIndex
|
||||||
|
in: query
|
||||||
|
required: false
|
||||||
|
description: Only get transactions sent to a specific account. Incompatible with the queries `tokenId`, `hezEthereumAddress` and `BJJ`.
|
||||||
schema:
|
schema:
|
||||||
$ref: '#/components/schemas/AccountIndex'
|
$ref: '#/components/schemas/AccountIndex'
|
||||||
- name: batchNum
|
- name: batchNum
|
||||||
@@ -1439,6 +1494,14 @@ components:
|
|||||||
- requestFee
|
- requestFee
|
||||||
- requestNonce
|
- requestNonce
|
||||||
- token
|
- token
|
||||||
|
PoolL2Transactions:
|
||||||
|
type: object
|
||||||
|
properties:
|
||||||
|
transactions:
|
||||||
|
type: array
|
||||||
|
description: List of pool l2 transactions
|
||||||
|
items:
|
||||||
|
$ref: '#/components/schemas/PoolL2Transaction'
|
||||||
TransactionId:
|
TransactionId:
|
||||||
type: string
|
type: string
|
||||||
description: Identifier for transactions. Used for any kind of transaction (both L1 and L2). More info on how the identifiers are built [here](https://idocs.hermez.io/#/spec/architecture/db/README?id=txid)
|
description: Identifier for transactions. Used for any kind of transaction (both L1 and L2). More info on how the identifiers are built [here](https://idocs.hermez.io/#/spec/architecture/db/README?id=txid)
|
||||||
|
|||||||
@@ -9,7 +9,7 @@ import (
|
|||||||
|
|
||||||
func (a *API) getHistoryTxs(c *gin.Context) {
|
func (a *API) getHistoryTxs(c *gin.Context) {
|
||||||
// Get query parameters
|
// Get query parameters
|
||||||
tokenID, addr, bjj, idx, err := parseExitFilters(c)
|
tokenID, addr, bjj, fromIdx, toIdx, err := parseTxsHistoryFilters(c)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
retBadReq(err, c)
|
retBadReq(err, c)
|
||||||
return
|
return
|
||||||
@@ -35,7 +35,7 @@ func (a *API) getHistoryTxs(c *gin.Context) {
|
|||||||
|
|
||||||
// Fetch txs from historyDB
|
// Fetch txs from historyDB
|
||||||
txs, pendingItems, err := a.h.GetTxsAPI(
|
txs, pendingItems, err := a.h.GetTxsAPI(
|
||||||
addr, bjj, tokenID, idx, batchNum, txType, fromItem, limit, order,
|
addr, bjj, tokenID, fromIdx, toIdx, batchNum, txType, fromItem, limit, order,
|
||||||
)
|
)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
retSQLErr(err, c)
|
retSQLErr(err, c)
|
||||||
|
|||||||
@@ -324,8 +324,8 @@ func TestGetHistoryTxs(t *testing.T) {
|
|||||||
idx, err := stringToIdx(idxStr, "")
|
idx, err := stringToIdx(idxStr, "")
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
path = fmt.Sprintf(
|
path = fmt.Sprintf(
|
||||||
"%s?accountIndex=%s&limit=%d",
|
"%s?fromAccountIndex=%s&toAccountIndex=%s&limit=%d",
|
||||||
endpoint, idxStr, limit,
|
endpoint, idxStr, idxStr, limit,
|
||||||
)
|
)
|
||||||
err = doGoodReqPaginated(path, historydb.OrderAsc, &testTxsResponse{}, appendIter)
|
err = doGoodReqPaginated(path, historydb.OrderAsc, &testTxsResponse{}, appendIter)
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
@@ -431,8 +431,8 @@ func TestGetHistoryTxs(t *testing.T) {
|
|||||||
assertTxs(t, []testTx{}, fetchedTxs)
|
assertTxs(t, []testTx{}, fetchedTxs)
|
||||||
// 400
|
// 400
|
||||||
path = fmt.Sprintf(
|
path = fmt.Sprintf(
|
||||||
"%s?accountIndex=%s&hezEthereumAddress=%s",
|
"%s?fromAccountIndex=%s&toAccountIndex=%s&hezEthereumAddress=%s",
|
||||||
endpoint, idx, account.EthAddr,
|
endpoint, idx, idx, account.EthAddr,
|
||||||
)
|
)
|
||||||
err = doBadReq("GET", path, nil, 400)
|
err = doBadReq("GET", path, nil, 400)
|
||||||
assert.NoError(t, err)
|
assert.NoError(t, err)
|
||||||
|
|||||||
@@ -55,6 +55,41 @@ func (a *API) getPoolTx(c *gin.Context) {
|
|||||||
c.JSON(http.StatusOK, tx)
|
c.JSON(http.StatusOK, tx)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (a *API) getPoolTxs(c *gin.Context) {
|
||||||
|
// Get from idx
|
||||||
|
fromIdx, err := parseFromIdx(c)
|
||||||
|
if err != nil {
|
||||||
|
retBadReq(err, c)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
// Get to idx
|
||||||
|
toIdx, err := parseToIdx(c)
|
||||||
|
if err != nil {
|
||||||
|
retBadReq(err, c)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
// Get state
|
||||||
|
state, err := parseQueryPoolL2TxState(c)
|
||||||
|
if err != nil {
|
||||||
|
retBadReq(err, c)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
// Fetch txs from l2DB
|
||||||
|
txs, err := a.l2.GetPoolTxs(fromIdx, toIdx, state)
|
||||||
|
if err != nil {
|
||||||
|
retSQLErr(err, c)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
|
||||||
|
// Build successful response
|
||||||
|
type txsResponse struct {
|
||||||
|
Txs []*l2db.PoolTxAPI `json:"transactions"`
|
||||||
|
}
|
||||||
|
c.JSON(http.StatusOK, &txsResponse{
|
||||||
|
Txs: txs,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
type receivedPoolTx struct {
|
type receivedPoolTx struct {
|
||||||
TxID common.TxID `json:"id" binding:"required"`
|
TxID common.TxID `json:"id" binding:"required"`
|
||||||
Type common.TxType `json:"type" binding:"required"`
|
Type common.TxType `json:"type" binding:"required"`
|
||||||
|
|||||||
@@ -47,6 +47,10 @@ type testPoolTxReceive struct {
|
|||||||
Token historydb.TokenWithUSD `json:"token"`
|
Token historydb.TokenWithUSD `json:"token"`
|
||||||
}
|
}
|
||||||
|
|
||||||
|
type testPoolTxsResponse struct {
|
||||||
|
Txs []testPoolTxReceive `json:"transactions"`
|
||||||
|
}
|
||||||
|
|
||||||
// testPoolTxSend is a struct to be used as a JSON body
|
// testPoolTxSend is a struct to be used as a JSON body
|
||||||
// when testing POST /transactions-pool
|
// when testing POST /transactions-pool
|
||||||
type testPoolTxSend struct {
|
type testPoolTxSend struct {
|
||||||
@@ -225,6 +229,24 @@ func TestPoolTxs(t *testing.T) {
|
|||||||
err = doBadReq("POST", endpoint, jsonTxReader, 400)
|
err = doBadReq("POST", endpoint, jsonTxReader, 400)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
// GET
|
// GET
|
||||||
|
// get by idx
|
||||||
|
fetchedTxs := testPoolTxsResponse{}
|
||||||
|
require.NoError(t, doGoodReq(
|
||||||
|
"GET",
|
||||||
|
endpoint+"?fromAccountIndex=hez:ETH:263",
|
||||||
|
nil, &fetchedTxs))
|
||||||
|
assert.Equal(t, 1, len(fetchedTxs.Txs))
|
||||||
|
assert.Equal(t, "hez:ETH:263", fetchedTxs.Txs[0].FromIdx)
|
||||||
|
// get by state
|
||||||
|
require.NoError(t, doGoodReq(
|
||||||
|
"GET",
|
||||||
|
endpoint+"?state=pend",
|
||||||
|
nil, &fetchedTxs))
|
||||||
|
assert.Equal(t, 4, len(fetchedTxs.Txs))
|
||||||
|
for _, v := range fetchedTxs.Txs {
|
||||||
|
assert.Equal(t, common.PoolL2TxStatePending, v.State)
|
||||||
|
}
|
||||||
|
// GET
|
||||||
endpoint += "/"
|
endpoint += "/"
|
||||||
for _, tx := range tc.poolTxsToReceive {
|
for _, tx := range tc.poolTxsToReceive {
|
||||||
fetchedTx := testPoolTxReceive{}
|
fetchedTx := testPoolTxReceive{}
|
||||||
|
|||||||
@@ -145,3 +145,11 @@ Coordinator = true
|
|||||||
BatchPath = "/tmp/iden3-test/hermez/batchesdebug"
|
BatchPath = "/tmp/iden3-test/hermez/batchesdebug"
|
||||||
LightScrypt = true
|
LightScrypt = true
|
||||||
# RollupVerifierIndex = 0
|
# RollupVerifierIndex = 0
|
||||||
|
|
||||||
|
[RecommendedFeePolicy]
|
||||||
|
# Strategy used to calculate the recommended fee that the API will expose.
|
||||||
|
# Available options:
|
||||||
|
# - Static: always return the same value (StaticValue) in USD
|
||||||
|
# - AvgLastHour: calculate using the average fee of the forged transactions during the last hour
|
||||||
|
PolicyType = "Static"
|
||||||
|
StaticValue = 0.99
|
||||||
@@ -8,6 +8,7 @@ import (
|
|||||||
|
|
||||||
"github.com/BurntSushi/toml"
|
"github.com/BurntSushi/toml"
|
||||||
ethCommon "github.com/ethereum/go-ethereum/common"
|
ethCommon "github.com/ethereum/go-ethereum/common"
|
||||||
|
"github.com/hermeznetwork/hermez-node/api/stateapiupdater"
|
||||||
"github.com/hermeznetwork/hermez-node/common"
|
"github.com/hermeznetwork/hermez-node/common"
|
||||||
"github.com/hermeznetwork/hermez-node/priceupdater"
|
"github.com/hermeznetwork/hermez-node/priceupdater"
|
||||||
"github.com/hermeznetwork/tracerr"
|
"github.com/hermeznetwork/tracerr"
|
||||||
@@ -347,6 +348,7 @@ type Node struct {
|
|||||||
// can wait to stablish a SQL connection
|
// can wait to stablish a SQL connection
|
||||||
SQLConnectionTimeout Duration
|
SQLConnectionTimeout Duration
|
||||||
} `validate:"required"`
|
} `validate:"required"`
|
||||||
|
RecommendedFeePolicy stateapiupdater.RecommendedFeePolicy `validate:"required"`
|
||||||
Debug NodeDebug `validate:"required"`
|
Debug NodeDebug `validate:"required"`
|
||||||
Coordinator Coordinator `validate:"-"`
|
Coordinator Coordinator `validate:"-"`
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -456,7 +456,7 @@ func (hdb *HistoryDB) GetTxAPI(txID common.TxID) (*TxAPI, error) {
|
|||||||
// and pagination info
|
// and pagination info
|
||||||
func (hdb *HistoryDB) GetTxsAPI(
|
func (hdb *HistoryDB) GetTxsAPI(
|
||||||
ethAddr *ethCommon.Address, bjj *babyjub.PublicKeyComp,
|
ethAddr *ethCommon.Address, bjj *babyjub.PublicKeyComp,
|
||||||
tokenID *common.TokenID, idx *common.Idx, batchNum *uint, txType *common.TxType,
|
tokenID *common.TokenID, fromIdx, toIdx *common.Idx, batchNum *uint, txType *common.TxType,
|
||||||
fromItem, limit *uint, order string,
|
fromItem, limit *uint, order string,
|
||||||
) ([]TxAPI, uint64, error) {
|
) ([]TxAPI, uint64, error) {
|
||||||
// Warning: amount_success and deposit_amount_success have true as default for
|
// Warning: amount_success and deposit_amount_success have true as default for
|
||||||
@@ -508,14 +508,32 @@ func (hdb *HistoryDB) GetTxsAPI(
|
|||||||
nextIsAnd = true
|
nextIsAnd = true
|
||||||
}
|
}
|
||||||
// idx filter
|
// idx filter
|
||||||
if idx != nil {
|
if fromIdx != nil && toIdx != nil {
|
||||||
if nextIsAnd {
|
if nextIsAnd {
|
||||||
queryStr += "AND "
|
queryStr += "AND "
|
||||||
} else {
|
} else {
|
||||||
queryStr += "WHERE "
|
queryStr += "WHERE "
|
||||||
}
|
}
|
||||||
queryStr += "(tx.effective_from_idx = ? OR tx.to_idx = ?) "
|
queryStr += "(tx.effective_from_idx = ? "
|
||||||
args = append(args, idx, idx)
|
queryStr += "OR tx.to_idx = ?) "
|
||||||
|
args = append(args, fromIdx, toIdx)
|
||||||
|
nextIsAnd = true
|
||||||
|
} else if fromIdx != nil {
|
||||||
|
if nextIsAnd {
|
||||||
|
queryStr += "AND "
|
||||||
|
} else {
|
||||||
|
queryStr += "WHERE "
|
||||||
|
}
|
||||||
|
queryStr += "tx.effective_from_idx = ? "
|
||||||
|
nextIsAnd = true
|
||||||
|
} else if toIdx != nil {
|
||||||
|
if nextIsAnd {
|
||||||
|
queryStr += "AND "
|
||||||
|
} else {
|
||||||
|
queryStr += "WHERE "
|
||||||
|
}
|
||||||
|
queryStr += "tx.to_idx = ? "
|
||||||
|
args = append(args, toIdx)
|
||||||
nextIsAnd = true
|
nextIsAnd = true
|
||||||
}
|
}
|
||||||
// batchNum filter
|
// batchNum filter
|
||||||
|
|||||||
@@ -127,3 +127,57 @@ func (l2db *L2DB) GetTxAPI(txID common.TxID) (*PoolTxAPI, error) {
|
|||||||
txID,
|
txID,
|
||||||
))
|
))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// GetPoolTxs return Txs from the pool
|
||||||
|
func (l2db *L2DB) GetPoolTxs(fromIdx, toIdx *common.Idx, state *common.PoolL2TxState) ([]*PoolTxAPI, error) {
|
||||||
|
cancel, err := l2db.apiConnCon.Acquire()
|
||||||
|
defer cancel()
|
||||||
|
if err != nil {
|
||||||
|
return nil, tracerr.Wrap(err)
|
||||||
|
}
|
||||||
|
defer l2db.apiConnCon.Release()
|
||||||
|
// Apply filters
|
||||||
|
nextIsAnd := false
|
||||||
|
queryStr := selectPoolTxAPI
|
||||||
|
var args []interface{}
|
||||||
|
if state != nil {
|
||||||
|
queryStr += "WHERE state = ? "
|
||||||
|
args = append(args, state)
|
||||||
|
nextIsAnd = true
|
||||||
|
}
|
||||||
|
|
||||||
|
if fromIdx != nil && toIdx != nil {
|
||||||
|
if nextIsAnd {
|
||||||
|
queryStr += "AND ("
|
||||||
|
} else {
|
||||||
|
queryStr += "WHERE ("
|
||||||
|
}
|
||||||
|
queryStr += "tx_pool.from_idx = ? "
|
||||||
|
queryStr += "OR tx_pool.to_idx = ?) "
|
||||||
|
args = append(args, fromIdx, toIdx)
|
||||||
|
} else if fromIdx != nil {
|
||||||
|
if nextIsAnd {
|
||||||
|
queryStr += "AND "
|
||||||
|
} else {
|
||||||
|
queryStr += "WHERE "
|
||||||
|
}
|
||||||
|
queryStr += "tx_pool.from_idx = ? "
|
||||||
|
args = append(args, fromIdx)
|
||||||
|
} else if toIdx != nil {
|
||||||
|
if nextIsAnd {
|
||||||
|
queryStr += "AND "
|
||||||
|
} else {
|
||||||
|
queryStr += "WHERE "
|
||||||
|
}
|
||||||
|
queryStr += "tx_pool.to_idx = ? "
|
||||||
|
args = append(args, toIdx)
|
||||||
|
}
|
||||||
|
queryStr += "AND NOT external_delete;"
|
||||||
|
query := l2db.dbRead.Rebind(queryStr)
|
||||||
|
txs := []*PoolTxAPI{}
|
||||||
|
err = meddler.QueryAll(
|
||||||
|
l2db.dbRead, &txs,
|
||||||
|
query,
|
||||||
|
args...)
|
||||||
|
return txs, tracerr.Wrap(err)
|
||||||
|
}
|
||||||
|
|||||||
@@ -311,6 +311,28 @@ func TestGetPending(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestL2DB_GetPoolTxs(t *testing.T) {
|
||||||
|
err := prepareHistoryDB(historyDB)
|
||||||
|
if err != nil {
|
||||||
|
log.Error("Error prepare historyDB", err)
|
||||||
|
}
|
||||||
|
poolL2Txs, err := generatePoolL2Txs()
|
||||||
|
require.NoError(t, err)
|
||||||
|
state := common.PoolL2TxState("pend")
|
||||||
|
idx := common.Idx(256)
|
||||||
|
var pendingTxs []*common.PoolL2Tx
|
||||||
|
for i := range poolL2Txs {
|
||||||
|
if poolL2Txs[i].FromIdx == idx || poolL2Txs[i].ToIdx == idx {
|
||||||
|
err := l2DB.AddTxTest(&poolL2Txs[i])
|
||||||
|
require.NoError(t, err)
|
||||||
|
pendingTxs = append(pendingTxs, &poolL2Txs[i])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
fetchedTxs, err := l2DBWithACC.GetPoolTxs(&idx, &idx, &state)
|
||||||
|
require.NoError(t, err)
|
||||||
|
assert.Equal(t, len(pendingTxs), len(fetchedTxs))
|
||||||
|
}
|
||||||
|
|
||||||
func TestStartForging(t *testing.T) {
|
func TestStartForging(t *testing.T) {
|
||||||
// Generate txs
|
// Generate txs
|
||||||
var fakeBatchNum common.BatchNum = 33
|
var fakeBatchNum common.BatchNum = 33
|
||||||
|
|||||||
@@ -245,15 +245,15 @@ func (c *EthereumClient) EthBlockByNumber(ctx context.Context, number int64) (*c
|
|||||||
if number == -1 {
|
if number == -1 {
|
||||||
blockNum = nil
|
blockNum = nil
|
||||||
}
|
}
|
||||||
block, err := c.client.BlockByNumber(ctx, blockNum)
|
header, err := c.client.HeaderByNumber(ctx, blockNum)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, tracerr.Wrap(err)
|
return nil, tracerr.Wrap(err)
|
||||||
}
|
}
|
||||||
b := &common.Block{
|
b := &common.Block{
|
||||||
Num: block.Number().Int64(),
|
Num: header.Number.Int64(),
|
||||||
Timestamp: time.Unix(int64(block.Time()), 0),
|
Timestamp: time.Unix(int64(header.Time), 0),
|
||||||
ParentHash: block.ParentHash(),
|
ParentHash: header.ParentHash,
|
||||||
Hash: block.Hash(),
|
Hash: header.Hash(),
|
||||||
}
|
}
|
||||||
return b, nil
|
return b, nil
|
||||||
}
|
}
|
||||||
|
|||||||
11
node/node.go
11
node/node.go
@@ -288,7 +288,16 @@ func NewNode(mode Mode, cfg *config.Node) (*Node, error) {
|
|||||||
return nil, tracerr.Wrap(err)
|
return nil, tracerr.Wrap(err)
|
||||||
}
|
}
|
||||||
|
|
||||||
stateAPIUpdater := stateapiupdater.NewUpdater(historyDB, &hdbNodeCfg, initSCVars, &hdbConsts)
|
stateAPIUpdater, err := stateapiupdater.NewUpdater(
|
||||||
|
historyDB,
|
||||||
|
&hdbNodeCfg,
|
||||||
|
initSCVars,
|
||||||
|
&hdbConsts,
|
||||||
|
&cfg.RecommendedFeePolicy,
|
||||||
|
)
|
||||||
|
if err != nil {
|
||||||
|
return nil, tracerr.Wrap(err)
|
||||||
|
}
|
||||||
|
|
||||||
var coord *coordinator.Coordinator
|
var coord *coordinator.Coordinator
|
||||||
if mode == ModeCoordinator {
|
if mode == ModeCoordinator {
|
||||||
|
|||||||
Reference in New Issue
Block a user