From 38148bd09cfea82f0ca3d4fc9d652a5e3fc8dde7 Mon Sep 17 00:00:00 2001 From: arnaucube Date: Sun, 26 Jan 2025 00:21:52 +0100 Subject: [PATCH] remove duplicated check in falcon verification Minor change removing a duplicated check of `h_digest==pubkey_com`at `src/dsa/rpo_falcon512/signature.rs#L100`, which is already done at `src/dsa/rpo_falcon512/signature.rs#L95`. --- CHANGELOG.md | 1 + src/dsa/rpo_falcon512/signature.rs | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8f7a0c2..caa5ec0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ ## 0.14.0 (TBD) - [BREAKING] Increment minimum supported Rust version to 1.84. +- Removed duplicated check in RpoFalcon512 verification (#368). ## 0.13.2 (2025-01-24) diff --git a/src/dsa/rpo_falcon512/signature.rs b/src/dsa/rpo_falcon512/signature.rs index 592e0d0..8bf397a 100644 --- a/src/dsa/rpo_falcon512/signature.rs +++ b/src/dsa/rpo_falcon512/signature.rs @@ -97,7 +97,7 @@ impl Signature { } let c = hash_to_point_rpo256(message, &self.nonce); - h_digest == pubkey_com && verify_helper(&c, &self.s2, self.pk_poly()) + verify_helper(&c, &self.s2, self.pk_poly()) } }