arnaucube/miden-crypto
1
0
Fork 0
mirror of https://github.com/arnaucube/miden-crypto.git synced 2026-01-12 09:01:29 +01:00
Code Issues Projects Releases Wiki Activity

bugfix: fix internal nodes of for empty leafs of a SMT

Browse Source 
The path returned by `EmptySubtreeRoots` starts at the root, and goes to
the leaf. The MerkleStore constructor assumed the other direction, so
the parent/child hashes were reversed.

This fixes the bug and adds a test.
This commit is contained in:
Augusto F. Hack
2023-03-24 20:22:55 +01:00
parent 854892ba9d
commit 9e6c8ff700
2 changed files with 80 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/merkle/store/mod.rs
View File

@@ -43,7 +43,7 @@ pub struct Node {
/// let mut store = MerkleStore::new();
///
/// // the store is initialized with the SMT empty nodes
/// assert_eq!(store.num_internal_nodes(), 64);
/// assert_eq!(store.num_internal_nodes(), 255);
///
/// // populates the store with two merkle trees, common nodes are shared
/// store.add_merkle_tree([A, B, C, D, E, F, G, H0]);
@@ -65,7 +65,7 @@ pub struct Node {
///
/// // Common internal nodes are shared, the two added trees have a total of 30, but the store has
/// // only 10 new entries, corresponding to the 10 unique internal nodes of these trees.
/// assert_eq!(store.num_internal_nodes() - 64, 10);
/// assert_eq!(store.num_internal_nodes() - 255, 10);
/// ```
#[derive(Debug, Clone, Eq, PartialEq)]
pub struct MerkleStore {
@@ -85,11 +85,12 @@ impl MerkleStore {
/// Creates an empty `MerkleStore` instance.
pub fn new() -> MerkleStore {
// pre-populate the store with the empty hashes
let subtrees = EmptySubtreeRoots::empty_hashes(64);
let subtrees = EmptySubtreeRoots::empty_hashes(255);
let nodes = subtrees
.iter()
.rev()
.copied()
.zip(subtrees.iter().skip(1).copied())
.zip(subtrees.iter().rev().skip(1).copied())
.map(|(child, parent)| {
(
parent,