You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

33 lines
1.2 KiB

  1. # Contributing to Ginkgo
  2. Your contributions to Ginkgo are essential for its long-term maintenance and improvement.
  3. - Please **open an issue first** - describe what problem you are trying to solve and give the community a forum for input and feedback ahead of investing time in writing code!
  4. - Ensure adequate test coverage:
  5. - When adding to the Ginkgo library, add unit and/or integration tests (under the `integration` folder).
  6. - When adding to the Ginkgo CLI, note that there are very few unit tests. Please add an integration test.
  7. - Update the documentation. Ginko uses `godoc` comments and documentation on the `gh-pages` branch.
  8. If relevant, please submit a docs PR to that branch alongside your code PR.
  9. Thanks for supporting Ginkgo!
  10. ## Setup
  11. Fork the repo, then:
  12. ```
  13. go get github.com/onsi/ginkgo
  14. go get github.com/onsi/gomega/...
  15. cd $GOPATH/src/github.com/onsi/ginkgo
  16. git remote add fork git@github.com:<NAME>/ginkgo.git
  17. ginkgo -r -p # ensure tests are green
  18. go vet ./... # ensure linter is happy
  19. ```
  20. ## Making the PR
  21. - go to a new branch `git checkout -b my-feature`
  22. - make your changes
  23. - run tests and linter again (see above)
  24. - `git push fork`
  25. - open PR 🎉