From e1383ff24854c60a70f2af2aae0438ea10ddb92d Mon Sep 17 00:00:00 2001 From: Srinath Setty Date: Mon, 1 Aug 2022 18:29:13 -0700 Subject: [PATCH] clippy fixes (#50) * clippy fixes * remove warning * fix clippy --- benches/nizk.rs | 1 + benches/snark.rs | 1 + examples/cubic.rs | 6 ++-- profiler/nizk.rs | 2 ++ profiler/snark.rs | 2 ++ rustfmt.toml | 1 - src/lib.rs | 1 + src/r1csinstance.rs | 2 +- src/r1csproof.rs | 23 +++++++++++++-- src/sparse_mlpoly.rs | 68 ++++++++++++++++++++------------------------ 10 files changed, 62 insertions(+), 45 deletions(-) diff --git a/benches/nizk.rs b/benches/nizk.rs index 0cdfe72..c00b825 100644 --- a/benches/nizk.rs +++ b/benches/nizk.rs @@ -1,3 +1,4 @@ +#![allow(clippy::assertions_on_result_states)] extern crate byteorder; extern crate core; extern crate criterion; diff --git a/benches/snark.rs b/benches/snark.rs index 7747f9c..9b6c67e 100644 --- a/benches/snark.rs +++ b/benches/snark.rs @@ -1,3 +1,4 @@ +#![allow(clippy::assertions_on_result_states)] extern crate libspartan; extern crate merlin; diff --git a/examples/cubic.rs b/examples/cubic.rs index 40ba361..462d1db 100644 --- a/examples/cubic.rs +++ b/examples/cubic.rs @@ -8,11 +8,9 @@ //! `(Z3 + 5) * 1 - I0 = 0` //! //! [here]: https://medium.com/@VitalikButerin/quadratic-arithmetic-programs-from-zero-to-hero-f6d558cea649 -use ark_bls12_377::Fr as Scalar; -use ark_ff::{PrimeField, BigInteger}; +use ark_std::{One, UniformRand, Zero}; use libspartan::{InputsAssignment, Instance, SNARKGens, VarsAssignment, SNARK}; use merlin::Transcript; -use ark_std::{UniformRand, One, Zero}; #[allow(non_snake_case)] fn produce_r1cs() -> ( @@ -72,7 +70,7 @@ fn produce_r1cs() -> ( let inst = Instance::new(num_cons, num_vars, num_inputs, &A, &B, &C).unwrap(); // compute a satisfying assignment -let mut rng = ark_std::rand::thread_rng(); + let mut rng = ark_std::rand::thread_rng(); let z0 = Scalar::rand(&mut rng); let z1 = z0 * z0; // constraint 0 let z2 = z1 * z0; // constraint 1 diff --git a/profiler/nizk.rs b/profiler/nizk.rs index 1e46582..3bd97b7 100644 --- a/profiler/nizk.rs +++ b/profiler/nizk.rs @@ -1,4 +1,6 @@ #![allow(non_snake_case)] +#![allow(clippy::assertions_on_result_states)] + extern crate flate2; extern crate libspartan; extern crate merlin; diff --git a/profiler/snark.rs b/profiler/snark.rs index 778f5c6..9538516 100644 --- a/profiler/snark.rs +++ b/profiler/snark.rs @@ -1,4 +1,6 @@ #![allow(non_snake_case)] +#![allow(clippy::assertions_on_result_states)] + extern crate flate2; extern crate libspartan; extern crate merlin; diff --git a/rustfmt.toml b/rustfmt.toml index d80cfda..7b20d96 100644 --- a/rustfmt.toml +++ b/rustfmt.toml @@ -1,5 +1,4 @@ edition = "2018" tab_spaces = 2 newline_style = "Unix" -report_fixme = "Always" use_try_shorthand = true diff --git a/src/lib.rs b/src/lib.rs index 2cad5f9..b9faf7e 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -3,6 +3,7 @@ #![feature(int_log)] #![doc = include_str!("../README.md")] #![deny(missing_docs)] +#![allow(clippy::assertions_on_result_states)] extern crate byteorder; extern crate core; diff --git a/src/r1csinstance.rs b/src/r1csinstance.rs index 26b7f99..53a5d3f 100644 --- a/src/r1csinstance.rs +++ b/src/r1csinstance.rs @@ -229,7 +229,7 @@ impl R1CSInstance { C: poly_C, }; - assert!(inst.is_sat(&Z[..num_vars].to_vec(), &Z[num_vars + 1..].to_vec())); + assert!(inst.is_sat(&Z[..num_vars], &Z[num_vars + 1..])); (inst, Z[..num_vars].to_vec(), Z[num_vars + 1..].to_vec()) } diff --git a/src/r1csproof.rs b/src/r1csproof.rs index 3098c80..fa264c2 100644 --- a/src/r1csproof.rs +++ b/src/r1csproof.rs @@ -278,10 +278,30 @@ impl R1CSProof { let claim_phase2 = r_A * Az_claim + r_B * Bz_claim + r_C * Cz_claim; // verify the joint claim with a sum-check protocol +<<<<<<< HEAD let (claim_post_phase2, ry) = self .sc_proof_phase2 .verify(claim_phase2, num_rounds_y, 2, transcript)?; +======= + let (comm_claim_post_phase2, ry) = self.sc_proof_phase2.verify( + &comm_claim_phase2, + num_rounds_y, + 2, + &gens.gens_sc.gens_1, + &gens.gens_sc.gens_3, + transcript, + )?; + + // verify Z(ry) proof against the initial commitment + self.proof_eval_vars_at_ry.verify( + &gens.gens_pc, + transcript, + &ry[1..], + &self.comm_vars_at_ry, + &self.comm_vars, + )?; +>>>>>>> clippy fixes (#50) let poly_input_eval = { // constant term @@ -292,8 +312,7 @@ impl R1CSProof { .map(|i| SparsePolyEntry::new(i + 1, input[i])) .collect::>(), ); - SparsePolynomial::new(n.log2() as usize, input_as_sparse_poly_entries) - .evaluate(&ry[1..].to_vec()) + SparsePolynomial::new(n.log2() as usize, input_as_sparse_poly_entries).evaluate(&ry[1..]) }; let eval_Z_at_ry = (Scalar::one() - ry[0]) * self.eval_vars_at_ry + ry[0] * poly_input_eval; diff --git a/src/sparse_mlpoly.rs b/src/sparse_mlpoly.rs index cb503d6..4d10a8c 100644 --- a/src/sparse_mlpoly.rs +++ b/src/sparse_mlpoly.rs @@ -967,16 +967,13 @@ impl HashLayerProof { let mut r_joint_ops = challenges_ops; r_joint_ops.extend(rand_ops); joint_claim_eval_ops.append_to_transcript(b"joint_claim_eval_ops", transcript); - assert!(self - .proof_ops - .verify_plain( - &gens.gens_ops, - transcript, - &r_joint_ops, - &joint_claim_eval_ops, - &comm.comm_comb_ops - ) - .is_ok()); + self.proof_ops.verify_plain( + &gens.gens_ops, + transcript, + &r_joint_ops, + &joint_claim_eval_ops, + &comm.comm_comb_ops, + )?; // verify proof-mem using comm_comb_mem at rand_mem // form a single decommitment using comb_comb_mem at rand_mem @@ -1408,33 +1405,30 @@ impl PolyEvalNetworkProof { let (claims_ops_col_read, claims_ops_col_write) = claims_ops_col.split_at_mut(num_instances); // verify the proof of hash layer - assert!(self - .proof_hash_layer - .verify( - (&rand_mem, &rand_ops), - &( - claims_mem[0], - claims_ops_row_read.to_vec(), - claims_ops_row_write.to_vec(), - claims_mem[1], - ), - &( - claims_mem[2], - claims_ops_col_read.to_vec(), - claims_ops_col_write.to_vec(), - claims_mem[3], - ), - &claims_dotp, - comm, - gens, - comm_derefs, - rx, - ry, - r_hash, - r_multiset_check, - transcript - ) - .is_ok()); + self.proof_hash_layer.verify( + (&rand_mem, &rand_ops), + &( + claims_mem[0], + claims_ops_row_read.to_vec(), + claims_ops_row_write.to_vec(), + claims_mem[1], + ), + &( + claims_mem[2], + claims_ops_col_read.to_vec(), + claims_ops_col_write.to_vec(), + claims_mem[3], + ), + &claims_dotp, + comm, + gens, + comm_derefs, + rx, + ry, + r_hash, + r_multiset_check, + transcript, + )?; timer.stop(); Ok(())