use ark_ec::AffineRepr; use ark_std::{One, Zero}; use std::marker::PhantomData; use crate::pedersen::{Commitment, Params as PedersenParams, Pedersen}; use crate::r1cs::*; use crate::transcript::Transcript; use crate::utils::*; use ark_std::{ rand::{Rng, RngCore}, UniformRand, }; // Phi: φ in the paper (later 𝖴), a folded instance pub struct Phi { cmE: Commitment, u: C::ScalarField, cmW: Commitment, x: Vec, } // FWit: Folded Witness pub struct FWit { E: Vec, rE: C::ScalarField, W: Vec, rW: C::ScalarField, } impl FWit { pub fn new(z: Vec, e_len: usize) -> Self { FWit:: { E: vec![C::ScalarField::zero(); e_len], rE: C::ScalarField::one(), W: z, rW: C::ScalarField::one(), } } pub fn commit(&self, params: &PedersenParams) -> Phi { let cmE = Pedersen::commit(¶ms, &self.E, &self.rE); let cmW = Pedersen::commit(¶ms, &self.W, &self.rW); Phi { cmE, u: C::ScalarField::one(), cmW, x: self.W.clone(), } } } pub struct NIFS { _phantom: PhantomData, } impl NIFS { pub fn comp_T( cs1: &RelaxedR1CS, cs2: &RelaxedR1CS, z1: &Vec, z2: &Vec, ) -> Vec { // assuming cs1.R1CS == cs2.R1CS let (A, B, C) = (cs1.ABC.A.clone(), cs1.ABC.B.clone(), cs1.ABC.C.clone()); // this is parallelizable (for the future) let Az1 = matrix_vector_product(&A, &z1); let Bz1 = matrix_vector_product(&B, &z1); let Cz1 = matrix_vector_product(&C, &z1); let Az2 = matrix_vector_product(&A, &z2); let Bz2 = matrix_vector_product(&B, &z2); let Cz2 = matrix_vector_product(&C, &z2); let Az1_Bz2 = hadamard_product(Az1, Bz2); let Az2_Bz1 = hadamard_product(Az2, Bz1); let u1Cz2 = vector_elem_product(&Cz2, &cs1.u); let u2Cz1 = vector_elem_product(&Cz1, &cs2.u); // let T = vec_sub(vec_sub(vec_add(Az1_Bz2, Az2_Bz1), u1Cz2), u2Cz1); let T = ((Ve(Az1_Bz2) + Ve(Az2_Bz1)) - Ve(u1Cz2)) - Ve(u2Cz1); T.0 } pub fn fold_witness( r: C::ScalarField, fw1: &FWit, fw2: &FWit, T: Vec, rT: C::ScalarField, ) -> FWit { // TODO compute T inside this method, and output cmT to be later inputed into fold_instance let r2 = r * r; let E: Vec = vec_add( // this syntax will be simplified with future operators impl (or at least a method // for r-lin) &vec_add(&fw1.E, &vector_elem_product(&T, &r)), &vector_elem_product(&fw2.E, &r2), ); let rE = fw1.rE + r * rT + r2 * fw2.rE; let W = vec_add(&fw1.W, &vector_elem_product(&fw2.W, &r)); let rW = fw1.rW + r * fw2.rW; FWit:: { E: E.into(), rE, W: W.into(), rW, } } pub fn fold_instance( r: C::ScalarField, phi1: Phi, phi2: Phi, cmT: Commitment, ) -> Phi { let r2 = r * r; let cmE = phi1.cmE.0 + cmT.0.mul(r) + phi2.cmE.0.mul(r2); let u = phi1.u + r * phi2.u; let cmW = phi1.cmW.0 + phi2.cmW.0.mul(r); let x = vec_add(&phi1.x, &vector_elem_product(&phi2.x, &r)); // let x = rlin(phi1.x, phi2.x, r); Phi:: { cmE: Commitment(cmE.into()), u, cmW: Commitment(cmW.into()), x, } } } #[cfg(test)] mod tests { use super::*; use crate::pedersen::Pedersen; use ark_bn254::{g1::G1Affine, Fr}; use ark_ec::CurveGroup; use ark_std::{ rand::{Rng, RngCore}, UniformRand, }; use ark_std::{One, Zero}; use std::ops::Mul; fn gen_test_values( rng: &mut R, ) -> ( RelaxedR1CS, RelaxedR1CS, Vec, Vec, Vec, Vec, Vec, Vec, ) { // R1CS for: x^3 + x + 5 = y (example from article // https://www.vitalik.ca/general/2016/12/10/qap.html ) let A = to_F_matrix::(vec![ vec![0, 1, 0, 0, 0, 0], vec![0, 0, 0, 1, 0, 0], vec![0, 1, 0, 0, 1, 0], vec![5, 0, 0, 0, 0, 1], ]); let B = to_F_matrix::(vec![ vec![0, 1, 0, 0, 0, 0], vec![0, 1, 0, 0, 0, 0], vec![1, 0, 0, 0, 0, 0], vec![1, 0, 0, 0, 0, 0], ]); let C = to_F_matrix::(vec![ vec![0, 0, 0, 1, 0, 0], vec![0, 0, 0, 0, 1, 0], vec![0, 0, 0, 0, 0, 1], vec![0, 0, 1, 0, 0, 0], ]); // TODO in the future update this method to generate witness, and generate n witnesses // instances let z1 = to_F_vec::(vec![1, 3, 35, 9, 27, 30]); let x1 = to_F_vec::(vec![35]); let z2 = to_F_vec::(vec![1, 4, 73, 16, 64, 68]); let x2 = to_F_vec::(vec![73]); // let z3 = to_F_vec::(vec![1, 4, 73, 16, 64, 68]); // let x3 = to_F_vec::(vec![73]); let z3 = to_F_vec::(vec![1, 5, 135, 25, 125, 130]); let x3 = to_F_vec::(vec![135]); let relaxed_r1cs_1 = R1CS:: { A: A.clone(), B: B.clone(), C: C.clone(), } .relax(); let relaxed_r1cs_2 = R1CS:: { A: A.clone(), B: B.clone(), C: C.clone(), } .relax(); (relaxed_r1cs_1, relaxed_r1cs_2, z1, z2, z3, x1, x2, x3) } // fold 2 instances into one #[test] fn test_one_fold() { let mut rng = ark_std::test_rng(); let (relaxed_r1cs_1, relaxed_r1cs_2, z1, z2, _, x1, x2, _) = gen_test_values(&mut rng); let (A, B, C) = ( relaxed_r1cs_1.ABC.A.clone(), relaxed_r1cs_1.ABC.B.clone(), relaxed_r1cs_1.ABC.C.clone(), ); let T = NIFS::::comp_T(&relaxed_r1cs_1, &relaxed_r1cs_2, &z1, &z2); let pedersen_params = Pedersen::::new_params(&mut rng, 100); // 100 is wip, will get it from actual vec let rT: Fr = Fr::rand(&mut rng); let cmT = Pedersen::commit(&pedersen_params, &T, &rT); let r = Fr::rand(&mut rng); // this would come from the transcript let fw1 = FWit::::new(z1, A.len()); let fw2 = FWit::::new(z2, A.len()); // fold witness let fw3 = NIFS::::fold_witness(r, &fw1, &fw2, T, rT); // get committed instances let phi1 = fw1.commit(&pedersen_params); // wip let phi2 = fw2.commit(&pedersen_params); // fold instance let phi3 = NIFS::::fold_instance(r, phi1, phi2, cmT); // naive check that the folded witness satisfies the relaxed r1cs let Az = matrix_vector_product(&A, &fw3.W); let Bz = matrix_vector_product(&B, &fw3.W); let Cz = matrix_vector_product(&C, &fw3.W); assert_eq!( hadamard_product(Az, Bz), vec_add(&vector_elem_product(&Cz, &phi3.u), &fw3.E) ); // check that folded commitments from folded instance (phi) are equal to folding the // use folded rE, rW to commit fw3 let phi3_expected = fw3.commit(&pedersen_params); assert_eq!(phi3_expected.cmE.0, phi3.cmE.0); assert_eq!(phi3_expected.cmW.0, phi3.cmW.0); // init Prover's transcript let mut transcript_p: Transcript = Transcript::::new(); // init Verifier's transcript let mut transcript_v: Transcript = Transcript::::new(); // check openings of phi3.cmE and phi3.cmW let phi3_cmE_proof = Pedersen::prove( &pedersen_params, &mut transcript_p, &phi3.cmE, fw3.E, fw3.rE, ); let v = Pedersen::verify( &pedersen_params, &mut transcript_v, phi3.cmE, phi3_cmE_proof, ); let phi3_cmW_proof = Pedersen::prove( &pedersen_params, &mut transcript_p, &phi3.cmW, fw3.W, fw3.rW, ); let v = Pedersen::verify( &pedersen_params, &mut transcript_v, phi3.cmW, phi3_cmW_proof, ); } // fold i_1, i_2 instances into i_12, and then i_12, i_3 into i_123 #[test] fn test_two_fold() { let mut rng = ark_std::test_rng(); let pedersen_params = Pedersen::::new_params(&mut rng, 6); let (relaxed_r1cs_1, relaxed_r1cs_2, z1, z2, z3, x1, x2, x3) = gen_test_values(&mut rng); let T_12 = NIFS::::comp_T(&relaxed_r1cs_1, &relaxed_r1cs_2, &z1, &z2); let rT_12: Fr = Fr::rand(&mut rng); let cmT_12 = Pedersen::commit(&pedersen_params, &T_12, &rT_12); // let r = Fr::rand(&mut rng); // this would come from the transcript let r = Fr::from(3_u32); let fw1 = FWit::::new(z1, T_12.len()); let fw2 = FWit::::new(z2, T_12.len()); // fold witness let fw_12 = NIFS::::fold_witness(r, &fw1, &fw2, T_12, rT_12); // get committed instances let phi1 = fw1.commit(&pedersen_params); // wip let phi2 = fw2.commit(&pedersen_params); // fold instance let phi_12 = NIFS::::fold_instance(r, phi1, phi2, cmT_12); // 2nd fold // tmp: set relaxed_r1cs instances let relaxed_r1cs_12 = RelaxedR1CS:: { ABC: relaxed_r1cs_1.ABC, u: phi_12.u, E: Fr::zero(), // not used in comp_T. TODO update RelaxedR1CS & comp_T to work different }; let relaxed_r1cs_3 = RelaxedR1CS:: { ABC: relaxed_r1cs_2.ABC, u: Fr::one(), // as this is a non-yet-folded instance E: Fr::zero(), }; let fw3 = FWit::::new(z3, relaxed_r1cs_3.ABC.A.len()); // compute cross terms let T_123 = NIFS::::comp_T(&relaxed_r1cs_12, &relaxed_r1cs_3, &fw_12.W, &fw3.W); // let rT_123: Fr = Fr::rand(&mut rng); let rT_123: Fr = rT_12.clone(); // TMP TODO let cmT_123 = Pedersen::commit(&pedersen_params, &T_123, &rT_123); // V sets rand challenge r // let r = Fr::rand(&mut rng); // this would come from the transcript // fold witness let fw_123 = NIFS::::fold_witness(r, &fw_12, &fw3, T_123, rT_123); // get committed instances // phi_12 is already known for Verifier from folding phi1, phi2 // rm: let phi_12 = fw_12.commit(&pedersen_params); // wip let phi3 = fw3.commit(&pedersen_params); // fold instance let phi_123 = NIFS::::fold_instance(r, phi_12, phi3, cmT_123); // naive check that the folded witness satisfies the relaxed r1cs let Az = matrix_vector_product(&relaxed_r1cs_3.ABC.A, &fw_123.W); let Bz = matrix_vector_product(&relaxed_r1cs_3.ABC.B, &fw_123.W); let Cz = matrix_vector_product(&relaxed_r1cs_3.ABC.C, &fw_123.W); assert_eq!( hadamard_product(Az, Bz), vec_add(&vector_elem_product(&Cz, &phi_123.u), &fw_123.E) ); // check that folded commitments from folded instance (phi) are equal to folding the // use folded rE, rW to commit fw3 let phi_123_expected = fw_123.commit(&pedersen_params); assert_eq!(phi_123_expected.cmE.0, phi_123.cmE.0); assert_eq!(phi_123_expected.cmW.0, phi_123.cmW.0); // init Prover's transcript let mut transcript_p: Transcript = Transcript::::new(); // init Verifier's transcript let mut transcript_v: Transcript = Transcript::::new(); // check openings of phi_123.cmE and phi_123.cmW let phi_123_cmE_proof = Pedersen::prove( &pedersen_params, &mut transcript_p, &phi_123.cmE, fw_123.E, fw_123.rE, ); let v = Pedersen::verify( &pedersen_params, &mut transcript_v, phi_123.cmE, phi_123_cmE_proof, ); let phi_123_cmW_proof = Pedersen::prove( &pedersen_params, &mut transcript_p, &phi_123.cmW, fw_123.W, fw_123.rW, ); let v = Pedersen::verify( &pedersen_params, &mut transcript_v, phi_123.cmW, phi_123_cmW_proof, ); } }