sonobe/folding-schemes/src/folding/nova/nifs.rs
folding-schemes/src/folding/nova/nifs.rsRaw
1use ark_crypto_primitives::sponge::Absorb;
2use ark_ec::{CurveGroup, Group};
3use ark_std::Zero;
4use std::marker::PhantomData;
5
6use super::{CommittedInstance, Witness};
7use crate::arith::r1cs::R1CS;
8use crate::commitment::CommitmentScheme;
9use crate::transcript::Transcript;
10use crate::utils::vec::{hadamard, mat_vec_mul, vec_add, vec_scalar_mul, vec_sub};
11use crate::Error;
12
13/// Implements the Non-Interactive Folding Scheme described in section 4 of
14/// [Nova](https://eprint.iacr.org/2021/370.pdf)
15pub struct NIFS<C: CurveGroup, CS: CommitmentScheme<C>> {
16 _c: PhantomData<C>,
17 _cp: PhantomData<CS>,
18}
19
20impl<C: CurveGroup, CS: CommitmentScheme<C>> NIFS<C, CS>
21where
22 <C as Group>::ScalarField: Absorb,
23{
24 // compute_T: compute cross-terms T
25 pub fn compute_T(
26 r1cs: &R1CS<C::ScalarField>,
27 u1: C::ScalarField,
28 u2: C::ScalarField,
29 z1: &[C::ScalarField],
30 z2: &[C::ScalarField],
31 ) -> Result<Vec<C::ScalarField>, Error> {
32 let (A, B, C) = (r1cs.A.clone(), r1cs.B.clone(), r1cs.C.clone());
33
34 // this is parallelizable (for the future)
35 let Az1 = mat_vec_mul(&A, z1)?;
36 let Bz1 = mat_vec_mul(&B, z1)?;
37 let Cz1 = mat_vec_mul(&C, z1)?;
38 let Az2 = mat_vec_mul(&A, z2)?;
39 let Bz2 = mat_vec_mul(&B, z2)?;
40 let Cz2 = mat_vec_mul(&C, z2)?;
41
42 let Az1_Bz2 = hadamard(&Az1, &Bz2)?;
43 let Az2_Bz1 = hadamard(&Az2, &Bz1)?;
44 let u1Cz2 = vec_scalar_mul(&Cz2, &u1);
45 let u2Cz1 = vec_scalar_mul(&Cz1, &u2);
46
47 vec_sub(&vec_sub(&vec_add(&Az1_Bz2, &Az2_Bz1)?, &u1Cz2)?, &u2Cz1)
48 }
49
50 pub fn fold_witness(
51 r: C::ScalarField,
52 w1: &Witness<C>,
53 w2: &Witness<C>,
54 T: &[C::ScalarField],
55 rT: C::ScalarField,
56 ) -> Result<Witness<C>, Error> {
57 let r2 = r * r;
58 let E: Vec<C::ScalarField> = vec_add(
59 &vec_add(&w1.E, &vec_scalar_mul(T, &r))?,
60 &vec_scalar_mul(&w2.E, &r2),
61 )?;
62 let rE = w1.rE + r * rT + r2 * w2.rE;
63 let W: Vec<C::ScalarField> = w1.W.iter().zip(&w2.W).map(|(a, b)| *a + (r * b)).collect();
64
65 let rW = w1.rW + r * w2.rW;
66 Ok(Witness::<C> { E, rE, W, rW })
67 }
68
69 pub fn fold_committed_instance(
70 r: C::ScalarField,
71 ci1: &CommittedInstance<C>, // U_i
72 ci2: &CommittedInstance<C>, // u_i
73 cmT: &C,
74 ) -> CommittedInstance<C> {
75 let r2 = r * r;
76 let cmE = ci1.cmE + cmT.mul(r) + ci2.cmE.mul(r2);
77 let u = ci1.u + r * ci2.u;
78 let cmW = ci1.cmW + ci2.cmW.mul(r);
79 let x = ci1
80 .x
81 .iter()
82 .zip(&ci2.x)
83 .map(|(a, b)| *a + (r * b))
84 .collect::<Vec<C::ScalarField>>();
85
86 CommittedInstance::<C> { cmE, u, cmW, x }
87 }
88
89 /// NIFS.P is the consecutive combination of compute_cmT with fold_instances
90
91 /// compute_cmT is part of the NIFS.P logic
92 pub fn compute_cmT(
93 cs_prover_params: &CS::ProverParams,
94 r1cs: &R1CS<C::ScalarField>,
95 w1: &Witness<C>,
96 ci1: &CommittedInstance<C>,
97 w2: &Witness<C>,
98 ci2: &CommittedInstance<C>,
99 ) -> Result<(Vec<C::ScalarField>, C), Error> {
100 let z1: Vec<C::ScalarField> = [vec![ci1.u], ci1.x.to_vec(), w1.W.to_vec()].concat();
101 let z2: Vec<C::ScalarField> = [vec![ci2.u], ci2.x.to_vec(), w2.W.to_vec()].concat();
102
103 // compute cross terms
104 let T = Self::compute_T(r1cs, ci1.u, ci2.u, &z1, &z2)?;
105 // use r_T=0 since we don't need hiding property for cm(T)
106 let cmT = CS::commit(cs_prover_params, &T, &C::ScalarField::zero())?;
107 Ok((T, cmT))
108 }
109 pub fn compute_cyclefold_cmT(
110 cs_prover_params: &CS::ProverParams,
111 r1cs: &R1CS<C::ScalarField>, // R1CS over C2.Fr=C1.Fq (here C=C2)
112 w1: &Witness<C>,
113 ci1: &CommittedInstance<C>,
114 w2: &Witness<C>,
115 ci2: &CommittedInstance<C>,
116 ) -> Result<(Vec<C::ScalarField>, C), Error>
117 where
118 <C as ark_ec::CurveGroup>::BaseField: ark_ff::PrimeField,
119 {
120 let z1: Vec<C::ScalarField> = [vec![ci1.u], ci1.x.to_vec(), w1.W.to_vec()].concat();
121 let z2: Vec<C::ScalarField> = [vec![ci2.u], ci2.x.to_vec(), w2.W.to_vec()].concat();
122
123 // compute cross terms
124 let T = Self::compute_T(r1cs, ci1.u, ci2.u, &z1, &z2)?;
125 // use r_T=0 since we don't need hiding property for cm(T)
126 let cmT = CS::commit(cs_prover_params, &T, &C::ScalarField::zero())?;
127 Ok((T, cmT))
128 }
129
130 /// fold_instances is part of the NIFS.P logic described in
131 /// [Nova](https://eprint.iacr.org/2021/370.pdf)'s section 4. It returns the folded Committed
132 /// Instances and the Witness.
133 pub fn fold_instances(
134 r: C::ScalarField,
135 w1: &Witness<C>,
136 ci1: &CommittedInstance<C>,
137 w2: &Witness<C>,
138 ci2: &CommittedInstance<C>,
139 T: &[C::ScalarField],
140 cmT: C,
141 ) -> Result<(Witness<C>, CommittedInstance<C>), Error> {
142 // fold witness
143 // use r_T=0 since we don't need hiding property for cm(T)
144 let w3 = NIFS::<C, CS>::fold_witness(r, w1, w2, T, C::ScalarField::zero())?;
145
146 // fold committed instances
147 let ci3 = NIFS::<C, CS>::fold_committed_instance(r, ci1, ci2, &cmT);
148
149 Ok((w3, ci3))
150 }
151
152 /// verify implements NIFS.V logic described in [Nova](https://eprint.iacr.org/2021/370.pdf)'s
153 /// section 4. It returns the folded Committed Instance
154 pub fn verify(
155 // r comes from the transcript, and is a n-bit (N_BITS_CHALLENGE) element
156 r: C::ScalarField,
157 ci1: &CommittedInstance<C>,
158 ci2: &CommittedInstance<C>,
159 cmT: &C,
160 ) -> CommittedInstance<C> {
161 NIFS::<C, CS>::fold_committed_instance(r, ci1, ci2, cmT)
162 }
163
164 /// Verify committed folded instance (ci) relations. Notice that this method does not open the
165 /// commitments, but just checks that the given committed instances (ci1, ci2) when folded
166 /// result in the folded committed instance (ci3) values.
167 pub fn verify_folded_instance(
168 r: C::ScalarField,
169 ci1: &CommittedInstance<C>,
170 ci2: &CommittedInstance<C>,
171 ci3: &CommittedInstance<C>,
172 cmT: &C,
173 ) -> Result<(), Error> {
174 let expected = Self::fold_committed_instance(r, ci1, ci2, cmT);
175 if ci3.cmE != expected.cmE
176 || ci3.u != expected.u
177 || ci3.cmW != expected.cmW
178 || ci3.x != expected.x
179 {
180 return Err(Error::NotSatisfied);
181 }
182 Ok(())
183 }
184
185 pub fn prove_commitments(
186 tr: &mut impl Transcript<C>,
187 cs_prover_params: &CS::ProverParams,
188 w: &Witness<C>,
189 ci: &CommittedInstance<C>,
190 T: Vec<C::ScalarField>,
191 cmT: &C,
192 ) -> Result<[CS::Proof; 3], Error> {
193 let cmE_proof = CS::prove(cs_prover_params, tr, &ci.cmE, &w.E, &w.rE, None)?;
194 let cmW_proof = CS::prove(cs_prover_params, tr, &ci.cmW, &w.W, &w.rW, None)?;
195 let cmT_proof = CS::prove(cs_prover_params, tr, cmT, &T, &C::ScalarField::zero(), None)?; // cm(T) is committed with rT=0
196 Ok([cmE_proof, cmW_proof, cmT_proof])
197 }
198}
199
200#[cfg(test)]
201pub mod tests {
202 use super::*;
203 use ark_crypto_primitives::sponge::poseidon::PoseidonConfig;
204 use ark_ff::{BigInteger, PrimeField};
205 use ark_pallas::{Fr, Projective};
206 use ark_std::{ops::Mul, UniformRand};
207
208 use crate::arith::r1cs::tests::{get_test_r1cs, get_test_z};
209 use crate::commitment::pedersen::{Params as PedersenParams, Pedersen};
210 use crate::folding::nova::circuits::ChallengeGadget;
211 use crate::folding::nova::traits::NovaR1CS;
212 use crate::transcript::poseidon::{poseidon_canonical_config, PoseidonTranscript};
213
214 #[allow(clippy::type_complexity)]
215 pub(crate) fn prepare_simple_fold_inputs<C>() -> (
216 PedersenParams<C>,
217 PoseidonConfig<C::ScalarField>,
218 R1CS<C::ScalarField>,
219 Witness<C>, // w1
220 CommittedInstance<C>, // ci1
221 Witness<C>, // w2
222 CommittedInstance<C>, // ci2
223 Witness<C>, // w3
224 CommittedInstance<C>, // ci3
225 Vec<C::ScalarField>, // T
226 C, // cmT
227 Vec<bool>, // r_bits
228 C::ScalarField, // r_Fr
229 )
230 where
231 C: CurveGroup,
232 <C as CurveGroup>::BaseField: PrimeField,
233 C::ScalarField: Absorb,
234 {
235 let r1cs = get_test_r1cs();
236 let z1 = get_test_z(3);
237 let z2 = get_test_z(4);
238 let (w1, x1) = r1cs.split_z(&z1);
239 let (w2, x2) = r1cs.split_z(&z2);
240
241 let w1 = Witness::<C>::new(w1.clone(), r1cs.A.n_rows);
242 let w2 = Witness::<C>::new(w2.clone(), r1cs.A.n_rows);
243
244 let mut rng = ark_std::test_rng();
245 let (pedersen_params, _) = Pedersen::<C>::setup(&mut rng, r1cs.A.n_cols).unwrap();
246
247 // compute committed instances
248 let ci1 = w1
249 .commit::<Pedersen<C>>(&pedersen_params, x1.clone())
250 .unwrap();
251 let ci2 = w2
252 .commit::<Pedersen<C>>(&pedersen_params, x2.clone())
253 .unwrap();
254
255 // NIFS.P
256 let (T, cmT) =
257 NIFS::<C, Pedersen<C>>::compute_cmT(&pedersen_params, &r1cs, &w1, &ci1, &w2, &ci2)
258 .unwrap();
259
260 let poseidon_config = poseidon_canonical_config::<C::ScalarField>();
261
262 let pp_hash = C::ScalarField::from(42u32); // only for test
263 let r_bits = ChallengeGadget::<C>::get_challenge_native(
264 &poseidon_config,
265 pp_hash,
266 ci1.clone(),
267 ci2.clone(),
268 cmT,
269 )
270 .unwrap();
271 let r_Fr = C::ScalarField::from_bigint(BigInteger::from_bits_le(&r_bits)).unwrap();
272
273 let (w3, ci3) =
274 NIFS::<C, Pedersen<C>>::fold_instances(r_Fr, &w1, &ci1, &w2, &ci2, &T, cmT).unwrap();
275
276 (
277 pedersen_params,
278 poseidon_config,
279 r1cs,
280 w1,
281 ci1,
282 w2,
283 ci2,
284 w3,
285 ci3,
286 T,
287 cmT,
288 r_bits,
289 r_Fr,
290 )
291 }
292
293 // fold 2 dummy instances and check that the folded instance holds the relaxed R1CS relation
294 #[test]
295 fn test_nifs_fold_dummy() {
296 let r1cs = get_test_r1cs::<Fr>();
297 let z1 = get_test_z(3);
298 let (w1, x1) = r1cs.split_z(&z1);
299
300 let mut rng = ark_std::test_rng();
301 let (pedersen_params, _) = Pedersen::<Projective>::setup(&mut rng, r1cs.A.n_cols).unwrap();
302
303 // dummy instance, witness and public inputs zeroes
304 let w_dummy = Witness::<Projective>::new(vec![Fr::zero(); w1.len()], r1cs.A.n_rows);
305 let mut u_dummy = w_dummy
306 .commit::<Pedersen<Projective>>(&pedersen_params, vec![Fr::zero(); x1.len()])
307 .unwrap();
308 u_dummy.u = Fr::zero();
309
310 let w_i = w_dummy.clone();
311 let u_i = u_dummy.clone();
312 let W_i = w_dummy.clone();
313 let U_i = u_dummy.clone();
314 r1cs.check_relaxed_instance_relation(&w_i, &u_i).unwrap();
315 r1cs.check_relaxed_instance_relation(&W_i, &U_i).unwrap();
316
317 let r_Fr = Fr::from(3_u32);
318
319 let (T, cmT) = NIFS::<Projective, Pedersen<Projective>>::compute_cmT(
320 &pedersen_params,
321 &r1cs,
322 &w_i,
323 &u_i,
324 &W_i,
325 &U_i,
326 )
327 .unwrap();
328 let (W_i1, U_i1) = NIFS::<Projective, Pedersen<Projective>>::fold_instances(
329 r_Fr, &w_i, &u_i, &W_i, &U_i, &T, cmT,
330 )
331 .unwrap();
332 r1cs.check_relaxed_instance_relation(&W_i1, &U_i1).unwrap();
333 }
334
335 // fold 2 instances into one
336 #[test]
337 fn test_nifs_one_fold() {
338 let (pedersen_params, poseidon_config, r1cs, w1, ci1, w2, ci2, w3, ci3, T, cmT, _, r) =
339 prepare_simple_fold_inputs();
340
341 // NIFS.V
342 let ci3_v = NIFS::<Projective, Pedersen<Projective>>::verify(r, &ci1, &ci2, &cmT);
343 assert_eq!(ci3_v, ci3);
344
345 // check that relations hold for the 2 inputted instances and the folded one
346 r1cs.check_relaxed_instance_relation(&w1, &ci1).unwrap();
347 r1cs.check_relaxed_instance_relation(&w2, &ci2).unwrap();
348 r1cs.check_relaxed_instance_relation(&w3, &ci3).unwrap();
349
350 // check that folded commitments from folded instance (ci) are equal to folding the
351 // use folded rE, rW to commit w3
352 let ci3_expected = w3
353 .commit::<Pedersen<Projective>>(&pedersen_params, ci3.x.clone())
354 .unwrap();
355 assert_eq!(ci3_expected.cmE, ci3.cmE);
356 assert_eq!(ci3_expected.cmW, ci3.cmW);
357
358 // next equalities should hold since we started from two cmE of zero-vector E's
359 assert_eq!(ci3.cmE, cmT.mul(r));
360 assert_eq!(w3.E, vec_scalar_mul(&T, &r));
361
362 // NIFS.Verify_Folded_Instance:
363 NIFS::<Projective, Pedersen<Projective>>::verify_folded_instance(r, &ci1, &ci2, &ci3, &cmT)
364 .unwrap();
365
366 // init Prover's transcript
367 let mut transcript_p = PoseidonTranscript::<Projective>::new(&poseidon_config);
368 // init Verifier's transcript
369 let mut transcript_v = PoseidonTranscript::<Projective>::new(&poseidon_config);
370
371 // prove the ci3.cmE, ci3.cmW, cmT commitments
372 let cm_proofs = NIFS::<Projective, Pedersen<Projective>>::prove_commitments(
373 &mut transcript_p,
374 &pedersen_params,
375 &w3,
376 &ci3,
377 T,
378 &cmT,
379 )
380 .unwrap();
381
382 // verify the ci3.cmE, ci3.cmW, cmT commitments
383 assert_eq!(cm_proofs.len(), 3);
384 Pedersen::<Projective>::verify(
385 &pedersen_params,
386 &mut transcript_v,
387 &ci3.cmE,
388 &cm_proofs[0].clone(),
389 )
390 .unwrap();
391 Pedersen::<Projective>::verify(
392 &pedersen_params,
393 &mut transcript_v,
394 &ci3.cmW,
395 &cm_proofs[1].clone(),
396 )
397 .unwrap();
398 Pedersen::<Projective>::verify(
399 &pedersen_params,
400 &mut transcript_v,
401 &cmT,
402 &cm_proofs[2].clone(),
403 )
404 .unwrap();
405 }
406
407 #[test]
408 fn test_nifs_fold_loop() {
409 let r1cs = get_test_r1cs();
410 let z = get_test_z(3);
411 let (w, x) = r1cs.split_z(&z);
412
413 let mut rng = ark_std::test_rng();
414 let (pedersen_params, _) = Pedersen::<Projective>::setup(&mut rng, r1cs.A.n_cols).unwrap();
415
416 // prepare the running instance
417 let mut running_instance_w = Witness::<Projective>::new(w.clone(), r1cs.A.n_rows);
418 let mut running_committed_instance = running_instance_w
419 .commit::<Pedersen<Projective>>(&pedersen_params, x)
420 .unwrap();
421
422 r1cs.check_relaxed_instance_relation(&running_instance_w, &running_committed_instance)
423 .unwrap();
424
425 let num_iters = 10;
426 for i in 0..num_iters {
427 // prepare the incoming instance
428 let incoming_instance_z = get_test_z(i + 4);
429 let (w, x) = r1cs.split_z(&incoming_instance_z);
430 let incoming_instance_w = Witness::<Projective>::new(w.clone(), r1cs.A.n_rows);
431 let incoming_committed_instance = incoming_instance_w
432 .commit::<Pedersen<Projective>>(&pedersen_params, x)
433 .unwrap();
434 r1cs.check_relaxed_instance_relation(
435 &incoming_instance_w,
436 &incoming_committed_instance,
437 )
438 .unwrap();
439
440 let r = Fr::rand(&mut rng); // folding challenge would come from the RO
441
442 // NIFS.P
443 let (T, cmT) = NIFS::<Projective, Pedersen<Projective>>::compute_cmT(
444 &pedersen_params,
445 &r1cs,
446 &running_instance_w,
447 &running_committed_instance,
448 &incoming_instance_w,
449 &incoming_committed_instance,
450 )
451 .unwrap();
452 let (folded_w, _) = NIFS::<Projective, Pedersen<Projective>>::fold_instances(
453 r,
454 &running_instance_w,
455 &running_committed_instance,
456 &incoming_instance_w,
457 &incoming_committed_instance,
458 &T,
459 cmT,
460 )
461 .unwrap();
462
463 // NIFS.V
464 let folded_committed_instance = NIFS::<Projective, Pedersen<Projective>>::verify(
465 r,
466 &running_committed_instance,
467 &incoming_committed_instance,
468 &cmT,
469 );
470
471 r1cs.check_relaxed_instance_relation(&folded_w, &folded_committed_instance)
472 .unwrap();
473
474 // set running_instance for next loop iteration
475 running_instance_w = folded_w;
476 running_committed_instance = folded_committed_instance;
477 }
478 }
479}