Commit history

ac8db9983543b85da4412d43bfb979384b5eb2f6

update the dependencies & code clean (#196)

liquan.eth committed on Jul 11, 2023

3for committed on Jul 7, 2023

Reorganize various Spartan SNARKs and make the direct interface more generic (#195) * reorganize different variants of spartan and make direct snark more generic * cargo fmt

Srinath Setty committed on Jul 6, 2023

e76e6bc

update README.md and version (#194) * update README.md and version * move multiexp code to provider/mod.rs * update README.md * small edits * small edits

Srinath Setty committed on Jul 6, 2023

4087cab

Fix comment typo (#192)

JunheeLee committed on Jul 7, 2023

ba06404

refactor: Refactor Keccak256Transcript and update tests (#191) * refactor: change the order of Keccak Squeeze's input - Redefine the input sequence for the `compute_updated_state` within the `squeeze` method in `Keccak256Transcript`. - Modify the expected hash outcomes in the `test_keccak_transcript_with` function in `keccak.rs`. * refactor: Refactor Keccak256Transcript - Replaced the transcript vector with a `Keccak256` instance, improving data handling and memory usage. - Refactored `compute_updated_state` to work directly on a given `Keccak256` instance, reducing unnecessary object creation. - this change roughly amounts to putting the transcript at the start of squeeze's input array * refactor: simplify hasher_lo, hasher_hi * test: Enhance Keccak transcript with backward compatibility test - Introduces new helper functions to assist with the backward-compatibility intesting process (`compute_updated_state_for_testing`, `squeeze_for_testing`) - Adds a new test `test_keccak_transcript_incremental_vs_explicit` that checks for consistency between incremental and independent explicit transcript computations

François Garillot committed on Jul 6, 2023

0664244

Add Grumpkin cycle implementation (#181) * bn256+grumpkin from halo2curves * chore: Integrate halo2curves more extensively - Extend existing tests with additional test cases using the new curve types * fix: Assign correct orders to bn256 and grumpkin scalar fields - Swap scalar orders between grumpkin and bn256 in `impl_traits!` implementation * test: Finish improving test integration with halo2curves - Enhances test coverage for `pasta_curves` and `halo2curves` - Cleans up commented code in `test_ivc_nontrivial` and `test_ivc_nontrivial_with_compression` tests - Updates relevant test cases in `src/lib.rs` to include new curve tests * chore: Remove commented-out/uneeded code in bn254_grumpkin.rs * test: reproduce test_from_label for bn254_grumpkin - Implement the `from_label_serial` function in bn254_grumpkin provider - Add a test to compare parallel and serial implementations of `from_label` function * refactor: Clean up to_coordinate & summarize changes * refactor: rename bn254_grumpkin -> bn256_grumpkin * test: Expand testing for public params digest using bn256 and grumpkin * chore: Update halo2curves dependency in Cargo.toml - Updated the `halo2curves` dependency in `Cargo.toml` to the latest version `0.1.0` from a specific git branch. * refactor: Refactor multi-exponentiation methods across providers - Updated bn256_grumpkin.rs to use the cpu_best_multiexp function from pasta provider instead of its native function. - Modified visibility of cpu_best_multiexp function in pasta.rs from private to crate level. * chore: set up dependencies to import the correct getrandom feature on Wasm --------- Co-authored-by: Leo Alt <leo@ethereum.org>

François Garillot committed on Jul 5, 2023

4b077bc

Add a Sha256 bench (#188) * add sha256 bench * feat: Refactor sha256 benchmark and update dependencies - Refactored the `sha256.rs` benchmarking file by replacing the former `hex_literal::hex` usage with a newly created `decode_hex` function. - Updated the "Test vectors" section to work with the new `decode_hex` function to compute digests in `Sha256Circuit` instances. - adapted to new APIs for RecursiveSNARK - Amended the `Cargo.toml` file to include the `sha2` package dependency, version `0.10.7`. - added the bench target * cargo fmt --------- Co-authored-by: Srinath Setty <srinath@microsoft.com>

François Garillot committed on Jun 28, 2023

905ec2d

remove a padded witness (#187)

Srinath Setty committed on Jun 21, 2023

bfbd786

[refactorings] Leftovers (pot-pourri?) (#184) * test: compute_path * refactor: path computation - Improve path concatenation by utilizing built-in `join` method * refactor: replace `PartialEq` with derived instance - Derive `PartialEq` for `SatisfyingAssignment` struct - Remove redundant manual implementation of `PartialEq` Cargo-expand generates: ``` #[automatically_derived] impl<G: ::core::cmp::PartialEq + Group> ::core::cmp::PartialEq for SatisfyingAssignment<G> where G::Scalar: PrimeField, G::Scalar: ::core::cmp::PartialEq, G::Scalar: ::core::cmp::PartialEq, G::Scalar: ::core::cmp::PartialEq, G::Scalar: ::core::cmp::PartialEq, G::Scalar: ::core::cmp::PartialEq, { #[inline] fn eq(&self, other: &SatisfyingAssignment<G>) -> bool { self.a_aux_density == other.a_aux_density && self.b_input_density == other.b_input_density && self.b_aux_density == other.b_aux_density && self.a == other.a && self.b == other.b && self.c == other.c && self.input_assignment == other.input_assignment && self.aux_assignment == other.aux_assignment } } ``` * refactor: avoid default for PhantomData Unit type * refactor: replace fold with sum where applicable - Simplify code by replacing `fold` with `sum` in various instances * refactor: decompression method in sumcheck.rs * refactor: test functions to use slice instead of vector conversion * refactor: use more references in functions - Update parameter types to use references instead of owned values in various functions that do not need them - Replace cloning instances with references

François Garillot committed on Jun 19, 2023

1e6bf94

Add the ability to profile the benchmarks w/ a flamegraph feature (#183) * feat: Integrate flamegraph profiling in benchmarks - Introduce "flamegraph" feature flag for optional profiling integration - Add benchmark profiling support in `compressed_snark` and `recursive_snark` groups - Update Cargo.toml with `pprof` and `cfg-if` dependencies * ci: Build benches to make sure they don't bit-rot - Integrate bench build step into GitHub Actions workflow

François Garillot committed on Jun 19, 2023

ff0370f

Improve performance of recursive (#163) * Improve performance of recursive * Fix the test after rebase * Fix CI/CD warnings * Update benchmark to work with new interface of RecursiveSNARK * Fix example to make sure step 1 is correct * refactor: Removes unneeded pass-by value in verification - Update function arguments to use borrowing instead of passing ownership * Resolve the conflict with upstream branch * refactor: Avoid extra input cloning in RecursiveSNARK::new * Update criterion to 0.5.1 to prevent the panic with its plot * Fix benchmark issue with new recursive_snark instance * Fix CI/CD warning with * refactor: Make mutation easier to observe - Utilize mutable references to Points for better memory management * chore: Downgrade clippy dependency for compatibility --------- Co-authored-by: François Garillot <francois@garillot.net>

Chiro Hiro committed on Jun 20, 2023

af886d6

Remove Zlib compression in public parameter computation (#182) * test: add test for pp computation * bench: add a digest computation bench * refactor: Optimize digest computation and update tests - Remove flate2 dependency from codebase - Replace ZlibEncoder with bincode::serialize in compute_digest function - Update test_pp_digest expected results to align with compute_digest changes Bench results: ``` compute_digest time: [1.4451 s 1.4571 s 1.4689 s] change: [-29.357% -27.854% -26.573%] (p = 0.00 < 0.05) Performance has improved. ```

François Garillot committed on Jun 12, 2023

031738d

[test, chore]: Fix clippy and genericize one more test (#180) * genericize test_tiny_r1cs * chore: remove redundant clone in scalar_mul Makes clippy happy

François Garillot committed on Jun 9, 2023

bef4226

Update README.md with release flag (#173)

Michele Orrù committed on May 26, 2023

7193483

chore: Update neptune dependency (#172) - Update neptune dependency to version 10.0.0

François Garillot committed on May 26, 2023

261fd19

[test-only] More genericity in tests (#171) * refactor: make circuit tests generic wrt curves - Improve modularity by introducing generic `test_recursive_circuit_with` function in `src/circuit.rs` - Refactor `test_recursive_circuit` to utilize the new function - Implement type constraints for `test_recursive_circuit_with` function * refactor: make bellperson tests generic in type of group - Introduce `test_alloc_bit_with` function utilizing generic types - Adapt existing `test_alloc_bit` function to use the new `test_alloc_bit_with` function with correct types * refactor: make the nifs test generic in the type of group * refactor: make the ivc tests generic in the type of curve * refactor: simplify generics in tests * make the keccak tests generic * make the poseidon tests generic * make the spartan tests generic

François Garillot committed on May 26, 2023

54f758e

release candidate (#169)

Srinath Setty committed on May 18, 2023

58fc746

Fix cross-curve check and then eliminate an unnecessary instance on the primary curve (#167) * add a cross-curve consistency check * eliminate the unused instance in RecursiveSNARK

Srinath Setty committed on May 18, 2023

afd7403

hash of public parameters in the transcript (#168)

Srinath Setty committed on May 18, 2023

b28aaf7

make ecc tests generic (#165)

Leo committed on May 10, 2023

f16fa1e

chore: update to ff/group 0.13 (#166) * chore: update to ff/group 0.13 and associated dependencies Updates: - zkcrypto/ff, zkcrypto/group to 0.13, - bellperson to 0.25, - pasta_curves to 0.5.1, and removes the fil_pasta_curves fork - pasta-msm should no longer need a fork (WIP) Adapts source in function, mostly for const usage and API updates. * expose the portable feature of pasta-MSM * update pointer to pasta-msm * Clippy --------- Co-authored-by: François Garillot <francois@garillot.net>

Samuel Burnham committed on May 10, 2023

cddd707

batch sum-checks (#161)

Srinath Setty committed on Apr 10, 2023

b76d7aa

serde for types (#160)

Srinath Setty committed on Apr 3, 2023

21d4092

support proving step circuits with final snark (#159)

Srinath Setty committed on Apr 3, 2023

83f2e07

A more optimal preprocessing SNARK (#158) * a more optimal preprocessing SNARK * update version * cleanup; address clippy

Srinath Setty committed on Mar 31, 2023

3b3ae70

Batch polynomial evaluations (#154) * Ability to collect evaluation claims * defer polynomial evaluation claims * address cargo clippy

Srinath Setty committed on Mar 27, 2023

4aab459

spark-based commitments to R1CS matrices (#152) * spark-based commitments to R1CS matrices * small fixes

Srinath Setty committed on Mar 20, 2023

7b1bb44

Fix padding logic (#151) * fix padding * update version

Srinath Setty committed on Mar 13, 2023

eb97499

Generalize TranscriptRepr implementation for slices (#150) * generalize the slice implementation * bump the version

Srinath Setty committed on Mar 10, 2023

cbbc1c6

simplify commitmentengine (#149)

Srinath Setty committed on Mar 9, 2023

0e86f9a

minor typo fix (#147) * typo fix * Comment typos fix * Update README.md * Comment typo fix

JunheeLee committed on Mar 10, 2023

6ba2044

Simplify TranscriptEngine usage (#148) * simplify transcript engine usage * update version

Srinath Setty committed on Mar 9, 2023

03710db

Separate prover and verifier keys in CompressedSNARK (#145) * checkpoint * simplify further * checkpoint * gens --> ck * update benches * address clippy * cleanup * update version

Srinath Setty committed on Mar 2, 2023

1e49952

pass only one multilinear polynomial to EE (#144) * pass only one multilinear polynomial to EE * update version

Srinath Setty committed on Mar 1, 2023

01ae644

simplify trait requirements (#143) * simplify trait requirements * update version

Srinath Setty committed on Feb 28, 2023

d53b3e0

Feature to enable Neptune GPU Poseidon (#141) * enable neptune gpu hashing * Disable clippy on GPU

Nalin committed on Feb 22, 2023

621fda5

Small optimizations (#142)

Srinath Setty committed on Feb 13, 2023

b5874df

allow the provider to provide byte representation of a scalar (#140)

Srinath Setty committed on Feb 10, 2023

c4b07f0

Make code generic over a TranscriptEngine (#139)

Srinath Setty committed on Feb 9, 2023

8faffd3

move IPA-specific methods to the provider (#138)

Srinath Setty committed on Feb 6, 2023

b97786d

fix wasm build (#137)

Srinath Setty committed on Feb 3, 2023

0315bd1

traits for a vector commitment engine and a polynomial evaluation engine (#136) make spartan generic over the evaluation engine update version disable Wasm CI check

Srinath Setty committed on Feb 2, 2023

603c1e2

use thiserror (#135)

Srinath Setty committed on Jan 31, 2023

e7f8d11

add Wasm build to CI (#134)

Srinath Setty committed on Jan 31, 2023

0ae8d15

release candidate (#133)

Srinath Setty committed on Jan 31, 2023

4163665

Clippy formatting (#131) * Clippy with Rust 1.67 * Clippy/Rustfmt with Rust 1.66.1

Samuel Burnham committed on Jan 31, 2023

b2adab6

parallel and batch_normalize (#129) use a macro to remove redundant code add a test case

Srinath Setty committed on Jan 31, 2023

7450193

use serde feature to compute the digest of the shape (#132)

Srinath Setty committed on Jan 31, 2023

746af53

Add serde proof serialization (#123) * Bump commit. * Bump commit. * (WIP) Add serde support * Minor fixes * Use neptune const generics * Use git patches * Impl serde for CompressedSNARK * Update dependencies, revert to typenum * Formatting * Update bellperson-nonnative patch * Cleanup * Remove bellperson-nonnative fork * Switch back to fil_pasta_curves * Update forked dependencies * Cleanup * Remove unnecessary patch * Update to lurk-pasta-msm --------- Co-authored-by: porcuquine <porcuquine@users.noreply.github.com>

Samuel Burnham committed on Jan 31, 2023

13964b6

release version (#130)

Srinath Setty committed on Jan 30, 2023

0b2b984

Add Wasm support (#125) * Add Wasm support * Use SeedableRng for Wasm randomness * Fix tests * Formatting

Samuel Burnham committed on Jan 30, 2023

55f6736

Speed up MSMs for non-GPU accelerated MSMs and architectures that don't support GPU/semolina (#126) * WASM target support * fast multiexp for WASM * add parallelisation for MSM https://github.com/zcash/halo2/blob/main/halo2_proofs/src/arithmetic.rs

Nalin committed on Jan 27, 2023

6c6a874

release version (#124)

Srinath Setty committed on Jan 18, 2023

d35604f

A simplified version of the nonnative gadgets (#122)

Srinath Setty committed on Jan 18, 2023

23178ff

Delete outdated comment to avoid confusion (#117)

Nalin committed on Dec 21, 2022

fa9064a

Update crate versions (#119) * update crate versions * fix clippy issues * cargo fmt

Srinath Setty committed on Nov 21, 2022

6044aff

Make Nova's ecc gadgets read curve parameters from the group trait (#115) * make ecc gadgets defined over Group rather than PrimeField * use curve parameters from Group trait

Srinath Setty committed on Sep 22, 2022

f9672fa

update benches (#111)

Srinath Setty committed on Aug 23, 2022

d284408

optimize ECC ops (#110) * optimize ECC ops * update version

Srinath Setty committed on Aug 23, 2022

7ec2f57

optimize point add constraints (#106) * optimize add constraints * optimize double by rewriting a constraint involving an inverted element

Srinath Setty committed on Aug 18, 2022

3c68673

simplify signature gadget (#109)

Srinath Setty committed on Aug 16, 2022

6e408d0

update version (#108)

Srinath Setty committed on Aug 16, 2022

faf28e7

Support for arbitrary arity for step circuit's IO (#107) * support for arbitrary arity for F * revive MinRoot example * revive tests * revive ecdsa * remove unused code * use None instead of Some(1u32) * revive benches * fix clippy warning

Srinath Setty committed on Aug 16, 2022

ccc6ccd

integrate with neptune's sponge (#105) * integrate with neptune's sponge * fix clippy warning * add checks to ensure at most one squeeze * add checks to ensure at most one squeeze

Srinath Setty committed on Aug 11, 2022

0a7cbf9

Update crate versions (#104) * update crates to their latest version * use latest pasta-msm

Srinath Setty committed on Aug 10, 2022

ddd90f7

pad two IPA instances to the same size when folding (#103)

Srinath Setty committed on Jul 27, 2022

c7e8782

optimize the non-native arithmetic and hashing costs by using 4 limbs instead of 8 (#102)

Srinath Setty committed on Jul 27, 2022

a56f823

optimize MinRoot constraint system (#101) * optimize MinRoot constraint system to not allocate unneeded advice variables run with multiple MinRoot iterations per Nova step in a loop * fix clippy warnings

Srinath Setty committed on Jul 27, 2022

111abca

Optimizations (#100) * avoid creating commitments to zero vectors * reduce the number of constraints in each iteration from 4 to 3

Srinath Setty committed on Jul 27, 2022

06192ac

Simplifications in Nova's RO (#98) * rename methods for better clarity * rename * Bump version

Srinath Setty committed on Jul 25, 2022

3dc26fd

Fix benches so it varies the number of constraints in the augmented circuit in powers of 2 (#97) * vary the number of constraints in the step circuit * use a different starting state

Srinath Setty committed on Jul 21, 2022

c6fa4d4

Fix bench name (#95) * fix name * Add 14

Srinath Setty committed on Jul 20, 2022

5d5b9aa

update benches (#94)

Srinath Setty committed on Jul 20, 2022

7d54d99

name changes for improved clarity (#93)

Srinath Setty committed on Jul 20, 2022

87a5b07

ecdsa signature proof (#92) * ecdsa signature proof * use the library-provided default circuit * small reorg Co-authored-by: Srinath Setty <srinath@microsoft.com>

Arthur Greef committed on Jul 19, 2022

ed915b2

reorganize traits into a module; cut boilerplate code (#91) use a default implementation for step circuit

Srinath Setty committed on Jul 14, 2022

35cb03f

update to the latest pasta-msm crate (#89)

Srinath Setty committed on Jul 13, 2022

704d48b

edits to address clippy with the latest Rust (#90)

Srinath Setty committed on Jul 13, 2022

e373f46

MinRoot example improvements (#88) * support multiple iterations of MinRoot per Nova step * small edits to println * fix declaration

Srinath Setty committed on Jul 11, 2022

a04566b

Nova-based VDF using MinRoot as an example (#86) * add the MinRoot VDF example * optimize a bit * optimization and cleanup * clippy * add examples to CI * use inbuilt pow_vartime

Srinath Setty committed on Jul 7, 2022

ff40d17

Support non-determinism with a minimal API (#85) * support non-determinism with small changes to the interface * update benches to use the new API * add an example that exercises non-deterministic advice at each step of recursion * tiny rename * Address clippy; update version

Srinath Setty committed on Jul 7, 2022

63f08c0

Abstract the RO used in the circuit with traits (#84) * cleanup RO usage inside the circuit: use traits * Add a note * rename types for clarity

Srinath Setty committed on Jul 5, 2022

6667d2f

Add asserts for constraint count (#83) * Add asserts for constraint count * switch to Standard strength

Srinath Setty committed on Jul 5, 2022

0863a73

Release Candidate (#82) * update version and README * move tests to bellperson adapter and remove tests folder; make bellperson adapter private

Srinath Setty committed on Jul 1, 2022

c29030b

Spartan variant with an IPA-based polynomial commitment scheme for compressing IVC proofs (#80) * cleanup code * compiles * additional plumbing * add padding * Add missing file * integrate * add a separate test * cleanup * cleanup * add checks for outer sum-check * sum-checks pass * sum-checks pass * sum-checks pass * Add polycommit checks to the end * switch to pasta_msm * clippy * remove int_log * switch to pasta_curves * clippy * clippy * add a special case for bases.len() = 1 * use naive MSM to avoid SIGFE error for smaller MSMs * add rayon parallelism to naive MSM * update comment since we already implement it * address clippy * cleanup map and reduce code * add parallelism to final SNARK creation and verification * add par * add par * add par * add par * store padded shapes in the parameters * Address clippy * pass padded shape in params * pass padded shape in params * cargo fmt * add par * add par * Add par * cleanup with a reorg * factor out spartan-based snark into a separate module * create traits for RelaxedR1CSSNARK * make CompressedSNARK parameterized by a SNARK satisfying our new trait * fix benches * cleanup code * remove unused * move code to Spartan-based SNARK * make unused function private * rename IPA types for clarity * cleanup * return error types; rename r_j to r_i * fix duplicate code

Srinath Setty committed on Jul 1, 2022

0ff2e57

Add benches (#79) * add benches * fix error * put snark in a black_box when benchmarking verification time * fix error in benches

iontzialla committed on Jun 14, 2022

81b1223

Complete addition: handle addition of equal numbers and addition of negation (#78) * make addition complete. test addition corner cases. optimizations * optimization and comment * fix errors * all tests pass

iontzialla committed on Jun 9, 2022

bf35556

IVC proof compression APIs and implementation (#77) We currently implement a constant-factor compression, but in the future we will provide an exponential reduction in proof sizes

Srinath Setty committed on May 27, 2022

a7da105

use pasta_msm crate for MSM (#75) * use pasta_msm crate for MSM * add repr-c to pasta_curves * add +stable * update pasta-msm version

Srinath Setty committed on May 26, 2022

8308c29

Verifier's checks (#73) * begin adding verification checks * add verifier checks * remove unnecessary dead_code

Srinath Setty committed on May 18, 2022

0154358

Update README.md (#72)

Srinath Setty committed on May 18, 2022

b080bac

small cleanup (#71)

Srinath Setty committed on May 18, 2022

4970826

Fix Wasm support (#64) * Fix dependencies * Replace rug with num-bigint

Samuel Burnham committed on May 17, 2022

25cd5ec

Update README.md (#70) * Update README.md * Update README.md

Srinath Setty committed on May 17, 2022

dbe8837

Add a non-trivial step circuit (#66)

Srinath Setty committed on May 17, 2022

188a7c5

Recursion implementation (#65) * recursion attempt * address clippy * initialize the running instance and witness of the primary correctly * add asserts for debugging * fix a bug in AllocatedPoint * add debug statements * fix an issue with how we inputize hashes; remove debug statements * rename * cleanup * speedup tests * require step_circuit implementors to provide a way to execute step computation

Srinath Setty committed on May 17, 2022

1fd4eee

cleanup trivial (#63)

Srinath Setty committed on May 15, 2022

4311ad1

Recursion APIs (#62) * recursion APIs (WIP) * PublicParams struct and associated new * fix build * draft of APIs * start with tests * add a test case for the base case of recursion

Srinath Setty committed on May 15, 2022

07b3c42

move StepSNARK to nifs.rs in prep for recursion APIs (#61) * move StepSNARK to nifs.rs in prep for recursion APIs * clippy

Srinath Setty committed on May 15, 2022

e8a6e45

Base case for second circuit (#60) * output the incoming instance as the running instance in one of the circuits * Make some verifier circuit inputs optional (for base case)

iontzialla committed on May 14, 2022

9f7c12d

delegate sampling of generators to trait implementors (#59)

Srinath Setty committed on May 14, 2022

3193d67

take ro_constants as a parameter (#58)

Srinath Setty committed on May 14, 2022

36d4be2

precompute R1CSShape's digest (#57)