mirror of
https://github.com/arnaucube/ark-r1cs-std.git
synced 2026-01-09 07:21:29 +01:00
Fix mul_by_inverse for constants
This commit is contained in:
@@ -160,14 +160,18 @@ pub trait FieldVar<F: Field, ConstraintF: Field>:
|
||||
/// It is up to the caller to ensure that denominator is non-zero,
|
||||
/// since in that case the result is unconstrained.
|
||||
fn mul_by_inverse(&self, denominator: &Self) -> Result<Self, SynthesisError> {
|
||||
let result = Self::new_witness(self.cs(), || {
|
||||
let denominator_inv_native = denominator.value()?.inverse().get()?;
|
||||
let result = self.value()? * &denominator_inv_native;
|
||||
Ok(result)
|
||||
})?;
|
||||
result.mul_equals(&denominator, &self)?;
|
||||
if self.is_constant() && denominator.is_constant() {
|
||||
Ok(self.clone() * denominator.value()?.inverse().unwrap())
|
||||
} else {
|
||||
let result = Self::new_witness(self.cs(), || {
|
||||
let denominator_inv_native = denominator.value()?.inverse().get()?;
|
||||
let result = self.value()? * &denominator_inv_native;
|
||||
Ok(result)
|
||||
})?;
|
||||
result.mul_equals(&denominator, &self)?;
|
||||
|
||||
Ok(result)
|
||||
Ok(result)
|
||||
}
|
||||
}
|
||||
|
||||
/// Computes the frobenius map over `self`.
|
||||
|
||||
Reference in New Issue
Block a user