arnaucube/ark-r1cs-std
1
0
Fork 0
mirror of https://github.com/arnaucube/ark-r1cs-std.git synced 2026-01-09 23:41:33 +01:00
Code Issues Projects Releases Wiki Activity

Fix mul_by_inverse for constants

Browse Source
This commit is contained in:
Pratyush Mishra
2021-01-08 16:53:56 -08:00
parent f52b866e59
commit a44643ed76
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/fields/mod.rs
View File

@@ -160,14 +160,18 @@ pub trait FieldVar<F: Field, ConstraintF: Field>:
/// It is up to the caller to ensure that denominator is non-zero, /// It is up to the caller to ensure that denominator is non-zero,
/// since in that case the result is unconstrained. /// since in that case the result is unconstrained.
fn mul_by_inverse(&self, denominator: &Self) -> Result<Self, SynthesisError> { fn mul_by_inverse(&self, denominator: &Self) -> Result<Self, SynthesisError> {
let result = Self::new_witness(self.cs(), || { if self.is_constant() && denominator.is_constant() {
let denominator_inv_native = denominator.value()?.inverse().get()?; Ok(self.clone() * denominator.value()?.inverse().unwrap())
let result = self.value()? * &denominator_inv_native; } else {
Ok(result) let result = Self::new_witness(self.cs(), || {
})?; let denominator_inv_native = denominator.value()?.inverse().get()?;
result.mul_equals(&denominator, &self)?; let result = self.value()? * &denominator_inv_native;
Ok(result)
})?;
result.mul_equals(&denominator, &self)?;
Ok(result) Ok(result)
}
} }
/// Computes the frobenius map over `self`. /// Computes the frobenius map over `self`.