Browse Source
fix: Support range checking non aligned bitwidth values (#47)
* initial commit * most of the code done * made global poseidon chip * changed decompSize and added some panics * made all gl chip as pointers * working code * revert go.mod and go.sum * cleanup and comments * cleaned up range checker selection * renamed gnarkRangeCheckSelector to gnarkRangeCheckerSelector * addressed PR comment * addressed overflow issue identified by Veridise * added some comments * fixed some comment typos * restore change made from commit hashmain85d20ceand9617141
Kevin Jue
1 year ago
committed by
GitHub
GitHub
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
24 changed files with 222 additions and 39 deletions
Split View
Diff Options
-
+2 -2fri/fri.go
-
+108 -14goldilocks/base.go
-
+1 -1goldilocks/quadratic_extension_algebra.go
-
+89 -0goldilocks/range_checker_utils.go
-
+1 -1plonk/gates/arithmetic_extension_gate.go
-
+1 -1plonk/gates/arithmetic_gate.go
-
+1 -1plonk/gates/base_sum_gate.go
-
+1 -1plonk/gates/constant_gate.go
-
+1 -1plonk/gates/coset_interpolation_gate.go
-
+1 -1plonk/gates/evaluate_gates.go
-
+1 -1plonk/gates/exponentiation_gate.go
-
+1 -1plonk/gates/gates.go
-
+1 -1plonk/gates/gates_test.go
-
+1 -1plonk/gates/multiplication_extension_gate.go
-
+1 -1plonk/gates/noop_gate.go
-
+1 -1plonk/gates/poseidon_gate.go
-
+1 -1plonk/gates/poseidon_mds_gate.go
-
+1 -1plonk/gates/public_input_gate.go
-
+1 -1plonk/gates/random_access_gate.go
-
+1 -1plonk/gates/reducing_extension_gate.go
-
+1 -1plonk/gates/reducing_gate.go
-
+2 -2poseidon/bn254.go
-
+2 -2poseidon/goldilocks.go
-
+1 -1poseidon/public_inputs_hash_test.go
@ -0,0 +1,89 @@ |
|||
package goldilocks |
|||
|
|||
import ( |
|||
"math" |
|||
|
|||
"github.com/consensys/gnark/frontend" |
|||
) |
|||
|
|||
// The types, structs, and functions in this file were ported over from the gnark library
|
|||
// https://github.com/Consensys/gnark/blob/3421eaa7d544286abf3de8c46282b8d4da6d5da0/std/rangecheck/rangecheck_commit.go
|
|||
type Type int |
|||
|
|||
const ( |
|||
R1CS Type = iota |
|||
SCS |
|||
) |
|||
|
|||
type FrontendTyper interface { |
|||
FrontendType() Type |
|||
} |
|||
|
|||
type checkedVariable struct { |
|||
v frontend.Variable |
|||
bits int |
|||
} |
|||
|
|||
func getOptimalBasewidth(api frontend.API, collected []checkedVariable) int { |
|||
if ft, ok := api.(FrontendTyper); ok { |
|||
switch ft.FrontendType() { |
|||
case R1CS: |
|||
return optimalWidth(nbR1CSConstraints, collected) |
|||
case SCS: |
|||
return optimalWidth(nbPLONKConstraints, collected) |
|||
} |
|||
} |
|||
return optimalWidth(nbR1CSConstraints, collected) |
|||
} |
|||
|
|||
func optimalWidth(countFn func(baseLength int, collected []checkedVariable) int, collected []checkedVariable) int { |
|||
min := math.MaxInt64 |
|||
minVal := 0 |
|||
for j := 2; j < 18; j++ { |
|||
current := countFn(j, collected) |
|||
if current < min { |
|||
min = current |
|||
minVal = j |
|||
} |
|||
} |
|||
|
|||
return minVal |
|||
} |
|||
|
|||
func decompSize(varSize int, limbSize int) int { |
|||
return (varSize + limbSize - 1) / limbSize |
|||
} |
|||
|
|||
func nbR1CSConstraints(baseLength int, collected []checkedVariable) int { |
|||
nbDecomposed := 0 |
|||
for i := range collected { |
|||
nbDecomposed += int(decompSize(collected[i].bits, baseLength)) |
|||
} |
|||
eqs := len(collected) // correctness of decomposition
|
|||
nbRight := nbDecomposed // inverse per decomposed
|
|||
nbleft := (1 << baseLength) // div per table
|
|||
return nbleft + nbRight + eqs + 1 |
|||
} |
|||
|
|||
func nbPLONKConstraints(baseLength int, collected []checkedVariable) int { |
|||
nbDecomposed := 0 |
|||
for i := range collected { |
|||
nbDecomposed += int(decompSize(collected[i].bits, baseLength)) |
|||
} |
|||
eqs := nbDecomposed // check correctness of every decomposition. this is nbDecomp adds + eq cost per collected
|
|||
nbRight := 3 * nbDecomposed // denominator sub, inv and large sum per table entry
|
|||
nbleft := 3 * (1 << baseLength) // denominator sub, div and large sum per table entry
|
|||
return nbleft + nbRight + eqs + 1 // and the final assert
|
|||
} |
|||
|
|||
func gnarkRangeCheckerSelector(api frontend.API) RangeCheckerType { |
|||
// Emulate the logic within rangecheck.New
|
|||
// https://github.com/Consensys/gnark/blob/3421eaa7d544286abf3de8c46282b8d4da6d5da0/std/rangecheck/rangecheck.go#L24
|
|||
if _, ok := api.(frontend.Rangechecker); ok { |
|||
return NATIVE_RANGE_CHECKER |
|||
} else if _, ok := api.(frontend.Committer); ok { |
|||
return COMMIT_RANGE_CHECKER |
|||
} else { |
|||
return BIT_DECOMP_RANGE_CHECKER |
|||
} |
|||
} |
|||