cleaned up qe api (#21)
Kevin Jue kjue235@gmail.com
Tue, 06 Jun 2023 17:56:10 -0700
8 files changed,
9 insertions(+),
14 deletions(-)
M
field/quadratic_extension.go
→
field/quadratic_extension.go
@@ -25,9 +25,7 @@
ZERO_QE_ALGEBRA QEAlgebra } -func NewQuadraticExtensionAPI(api frontend.API, fieldAPI FieldAPI, degreeBits uint64) *QuadraticExtensionAPI { - // TODO: Should degreeBits be verified that it fits within the field and that degree is within uint64? - +func NewQuadraticExtensionAPI(api frontend.API, fieldAPI FieldAPI) *QuadraticExtensionAPI { var ZERO_QE = QuadraticExtension{ZERO_F, ZERO_F} var ZERO_QE_ALGEBRA QEAlgebra
M
field/quadratic_extension_test.go
→
field/quadratic_extension_test.go
@@ -20,8 +20,7 @@ }
func (c *TestQuadraticExtensionMulCircuit) Define(api frontend.API) error { fieldAPI := NewFieldAPI(api) - degreeBits := 3 - c.qeAPI = NewQuadraticExtensionAPI(api, fieldAPI, uint64(degreeBits)) + c.qeAPI = NewQuadraticExtensionAPI(api, fieldAPI) actualRes := c.qeAPI.MulExtension(c.Operand1, c.Operand2)@@ -54,8 +53,7 @@ }
func (c *TestQuadraticExtensionDivCircuit) Define(api frontend.API) error { fieldAPI := NewFieldAPI(api) - degreeBits := 3 - c.qeAPI = NewQuadraticExtensionAPI(api, fieldAPI, uint64(degreeBits)) + c.qeAPI = NewQuadraticExtensionAPI(api, fieldAPI) actualRes := c.qeAPI.DivExtension(c.Operand1, c.Operand2)
M
poseidon/poseidon_test.go
→
poseidon/poseidon_test.go
@@ -18,7 +18,7 @@ }
func (circuit *TestPoseidonCircuit) Define(api frontend.API) error { goldilocksApi := field.NewFieldAPI(api) - qeAPI := field.NewQuadraticExtensionAPI(api, goldilocksApi, 3) + qeAPI := field.NewQuadraticExtensionAPI(api, goldilocksApi) var input PoseidonState for i := 0; i < 12; i++ {
M
verifier/internal/fri/fri_test.go
→
verifier/internal/fri/fri_test.go
@@ -25,7 +25,7 @@ commonCircuitData := utils.DeserializeCommonCircuitData(circuit.commonCircuitDataFilename)
verifierOnlyCircuitData := utils.DeserializeVerifierOnlyCircuitData(circuit.verifierOnlyCircuitDataFilename) fieldAPI := field.NewFieldAPI(api) - qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI, commonCircuitData.DegreeBits) + qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI) poseidonChip := poseidon.NewPoseidonChip(api, fieldAPI, qeAPI) poseidonBN128Chip := poseidon.NewPoseidonBN128Chip(api, fieldAPI) friChip := fri.NewFriChip(api, fieldAPI, qeAPI, poseidonBN128Chip, &commonCircuitData.FriParams)
M
verifier/internal/gates/gate_test.go
→
verifier/internal/gates/gate_test.go
@@ -688,7 +688,7 @@ commonCircuitData := utils.DeserializeCommonCircuitData("../../data/decode_block/common_circuit_data.json")
numSelectors := commonCircuitData.SelectorsInfo.NumSelectors() fieldAPI := field.NewFieldAPI(api) - qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI, commonCircuitData.DegreeBits) + qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI) vars := gates.NewEvaluationVars(localConstants[numSelectors:], localWires, publicInputsHash)
M
verifier/internal/plonk/challenger_test.go
→
verifier/internal/plonk/challenger_test.go
@@ -20,8 +20,7 @@ }
func (circuit *TestChallengerCircuit) Define(api frontend.API) error { fieldAPI := field.NewFieldAPI(api) - degreeBits := 3 - qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI, uint64(degreeBits)) + qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI) poseidonChip := poseidon.NewPoseidonChip(api, fieldAPI, qeAPI) poseidonBN128Chip := poseidon.NewPoseidonBN128Chip(api, fieldAPI) challengerChip := NewChallengerChip(api, fieldAPI, poseidonChip, poseidonBN128Chip)
M
verifier/internal/plonk/plonk_test.go
→
verifier/internal/plonk/plonk_test.go
@@ -27,7 +27,7 @@ publicInputsHash := verifierChip.GetPublicInputsHash(proofWithPis.PublicInputs)
proofChallenges := verifierChip.GetChallenges(proofWithPis, publicInputsHash, commonCircuitData, verifierOnlyCircuitData) fieldAPI := field.NewFieldAPI(api) - qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI, commonCircuitData.DegreeBits) + qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI) plonkChip := plonk.NewPlonkChip( api, qeAPI,
M
verifier/verifier.go
→
verifier/verifier.go
@@ -22,7 +22,7 @@
func NewVerifierChip(api frontend.API, commonCircuitData common.CommonCircuitData) *VerifierChip { fieldAPI := field.NewFieldAPI(api) - qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI, commonCircuitData.DegreeBits) + qeAPI := field.NewQuadraticExtensionAPI(api, fieldAPI) poseidonBN128Chip := poseidon.NewPoseidonBN128Chip(api, fieldAPI) friChip := fri.NewFriChip(api, fieldAPI, qeAPI, poseidonBN128Chip, &commonCircuitData.FriParams)