arnaucube
arnaucube/go-iden3-cryptoPublic Self-hosted repository

Commit history

71dbddb5f119865bf9d1bb774c993c09d8e7241e
a
Abstract & expose CompressedPointToSignAndY
arnaucube committed on Dec 21, 2020
71dbddb
E
Merge pull request #33 from iden3/feature/pkcomp-scanvalue Add scanner/valuer interface to babyjub.PublicKeyComp
Eduard S committed on Dec 21, 2020
0a5c6ac
E
Merge pull request #32 from iden3/feature/upgrade-linters Upgrade linters
Eduard S committed on Dec 18, 2020
a2015ad
E
Merge pull request #31 from iden3/feature/update-bbjjeddsa Update BabyJubJub EdDSA to last circomlib version
Eduard S committed on Dec 3, 2020
821a601
a
Merge pull request #30 from iden3/feature/signaturecomp-scanner Add scanner/valuer interface to babyjub.SignatureComp
arnau committed on Oct 16, 2020
94e92e8
a
Merge pull request #29 from iden3/feature/babyjubjub-optimization - Add `add-2008-bbjlp` for point addition - Add `goff` to BabyJubJub point addition ``` Benchmarks (On a Intel(R) Core(TM) i7-8705G CPU @ 3.10GHz, with 32 GB of RAM): - Old (commit: e04ca5764a153717d7966e523a9cc8d7305bfcf8): BenchmarkBabyjub/AddConst-8 1000000 1072 ns/op BenchmarkBabyjub/AddRnd-8 93417 12943 ns/op BenchmarkBabyjub/MulRnd-8 252 4797810 ns/op BenchmarkBabyjub/Compress-8 7291580 166 ns/op BenchmarkBabyjub/InCurve-8 611137 1999 ns/op BenchmarkBabyjub/InSubGroup-8 615792 2021 ns/op BenchmarkBabyjubEddsa/SignMimc7-8 126 9358542 ns/op BenchmarkBabyjubEddsa/VerifyMimc7-8 124 9484005 ns/op BenchmarkBabyjubEddsa/SignPoseidon-8 126 9486484 ns/op BenchmarkBabyjubEddsa/VerifyPoseidon-8 126 9622807 ns/op - With new point addition algorithm (commit: aab1a681dd4b00cab49f39f9e30d6f28034589c1): BenchmarkBabyjub/AddConst-8 1356836 881 ns/op BenchmarkBabyjub/AddRnd-8 274112 4220 ns/op BenchmarkBabyjub/MulRnd-8 492 2474412 ns/op BenchmarkBabyjub/Compress-8 6964855 197 ns/op BenchmarkBabyjub/InCurve-8 608169 2008 ns/op BenchmarkBabyjub/InSubGroup-8 618772 1954 ns/op BenchmarkBabyjubEddsa/SignMimc7-8 238 4962397 ns/op BenchmarkBabyjubEddsa/VerifyMimc7-8 235 5234883 ns/op BenchmarkBabyjubEddsa/SignPoseidon-8 240 5028720 ns/op BenchmarkBabyjubEddsa/VerifyPoseidon-8 243 5226654 ns/op Point Addition: ~3x Point scalar Mul: ~1.9x Signature (poseidon): ~1.88x Verification (poseidon): ~1.84x - With new point addition algorithm & goff (current commit): BenchmarkBabyjub/AddConst-8 3000531 400 ns/op BenchmarkBabyjub/AddRnd-8 2770335 428 ns/op BenchmarkBabyjub/MulRnd-8 6636 175522 ns/op BenchmarkBabyjub/Compress-8 7358768 180 ns/op BenchmarkBabyjub/InCurve-8 539193 1950 ns/op BenchmarkBabyjub/InSubGroup-8 601402 1958 ns/op BenchmarkBabyjubEddsa/SignMimc7-8 2940 409487 ns/op BenchmarkBabyjubEddsa/VerifyMimc7-8 2908 414407 ns/op BenchmarkBabyjubEddsa/SignPoseidon-8 2395 493165 ns/op BenchmarkBabyjubEddsa/VerifyPoseidon-8 2491 494849 ns/op Point Addition: ~9.86x Point scalar Mul: ~14x Signature (poseidon): ~10.2x Verification (poseidon): ~10.56x --- Total improvement (from old to current): Point Addition: ~30.24x Point scalar Mul: ~27.33x Signature (poseidon): ~19.24x Verification (poseidon): ~19.44x ```
arnau committed on Sep 13, 2020
59d8c7a
a
Update Poseidon to new circomlib version & https://extgit.iaik.tugraz.at/krypto/hadeshash
arnaucube committed on Aug 18, 2020
e04ca57
E
Merge pull request #28 from iden3/feature/signature-sql-interface Fix value sql interface
Eduard S committed on Aug 14, 2020
70841d7
a
Merge pull request #27 from iden3/feature/signature-sql-interface Add scanner/valuer interface to signature
arnau committed on Aug 13, 2020
6651912
E
Merge pull request #26 from iden3/feature/pointfromsigny Babyjubjub separate PointFromSignAndY from p.Decompress
Eduard S committed on Aug 6, 2020
327a817
E
Merge pull request #25 from iden3/feature/poseidon-update Update Poseidon Hash function names, rm HashBytes
Eduard S committed on Jul 23, 2020
29a6645
E
Merge pull request #24 from iden3/fix/hashbytes-err Poseidon & MiMC7 HashBytes remove return of err
Eduard S committed on May 25, 2020
2c471ab
E
Merge pull request #23 from iden3/feature/expose-method Expose SkToBigInt for usage from other packages & repos
Eduard S committed on Apr 28, 2020
b1468fc
E
Merge pull request #22 from iden3/feature/utils-elembigintconv Add utils.ElementArrayToBigIntArray
Eduard S committed on Apr 21, 2020
14c3144
a
Merge pull request #21 from iden3/feature/githubactions Add github actions and remove travis
arnau committed on Apr 14, 2020
4d1bbac
a
Merge pull request #18 from iden3/feature/fix32bits Fix compat with 32 bit arch
arnau committed on Mar 18, 2020
eb41fe0
E
Merge pull request #16 from iden3/feature/mimc7-goff Feature/mimc7 goff
Eduard S committed on Mar 6, 2020
ee467c6
a
Merge pull request #15 from iden3/feature/poseidon-opt-goff Feature/poseidon opt goff
arnau committed on Mar 4, 2020
e8be761
E
Merge pull request #13 from iden3/feature/update-bbjj-sig Update BabyJubJub signature with Poseidon
Eduard S committed on Mar 3, 2020
5d88f7c
a
Merge pull request #12 from iden3/feature/optimizeposeidon Optimize Poseidon
arnau committed on Dec 22, 2019
937500b
E
Merge pull request #11 from iden3/fix/issue-9 Fix/issue #9
Eduard S committed on Dec 18, 2019
8d5a7a7
E
Add test that breaks poseidion due to padding
Eduard S committed on Dec 16, 2019
7c61704
E
Add test that breaks poseidon due to a security issue
Eduard S committed on Dec 16, 2019
27ec5b2
E
Add babujub eddsa benchmarks
Eduard S committed on Dec 16, 2019
53b9050
E
Add poseidon and babyjub benchmarks
Eduard S committed on Dec 16, 2019
a5b6afc
a
Merge pull request #6 from iden3/feature/testBJPKField Test that babyjub pk is always < Q
arnau committed on Dec 9, 2019
4356f44
E
Merge pull request #5 from iden3/decompress-modsqrt return error if no ModSqrt(x, q) exist in babyjubjub decompress point
Eduard S committed on Sep 10, 2019
eb7d86c
a
add Poseidon multihash ([]*big.Int), add HashBytes for MiMC7 & Poseidon
arnaucube committed on Aug 30, 2019
c95c95b
a
MiMC7 finite field over R comprovation moved inside hash, same approach as Poseidon impl
arnaucube committed on Aug 30, 2019
2b19352
a
add babyjub-eddsa Poseidon sign & verify
arnaucube committed on Aug 29, 2019
0bac1c8
a
update babyjub B8, clean unused funcs & errs in mimc7, small update in mimc7 tests
arnaucube committed on Aug 3, 2019
c4b3b7a
E
Merge pull request #1 from iden3/feature/poseidon add Poseidon
Eduard S committed on Jul 1, 2019
16423cc
a
add travis, add go.mod go.sum, update babyjub hex encoders to avoid importing go-iden3
arnaucube committed on Jun 25, 2019
7b219e1
a
add mimc7 & fields
arnaucube committed on Jun 25, 2019
e92a15d
E
Add babyjub from go-iden3/crypto/babyjub
Eduard S committed on Jun 25, 2019
0f93c8c
a
Initial commit
arnau committed on Jun 25, 2019
eea7579
E
Move constants and utils to package, apply small fixes
Eduard S committed on Jul 1, 2019
5b79ded
a
add Poseidon
arnaucube committed on Jun 30, 2019
09c29da
a
return error if no ModSqrt(x, q) exist in babyjubjub decompress point
arnaucube committed on Sep 10, 2019
a60e154
E
Test that babyjub pk is always < Q
Eduard S committed on Dec 9, 2019
5ade04e
a
poseidon consistent use of T
arnaucube committed on Dec 17, 2019
c754d01
a
fix #9
arnaucube committed on Dec 17, 2019
fcb5865
E
Optimize Poseidon
Eduard S committed on Dec 18, 2019
c0c4ff2
a
Update BabyJubJub signature with Poseidon
arnaucube committed on Mar 3, 2020
97c76ce
a
Adapt babyjub/eddsa to new Poseidon methods
arnaucube committed on Mar 3, 2020
2a3f0d9
a
Optimize Poseidon migrating from *big.Int to goff Optimize Poseidon migrating from *big.Int to goff generated finite field operations. Benchmarks: Tested on a Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz, with 16GB of RAM. - Before the optimizations: ``` BenchmarkPoseidon-4 470 2489678 ns/op BenchmarkPoseidonLarge-4 476 2530568 ns/op ``` - With the optimizations of #12: ``` BenchmarkPoseidon-4 766 1550013 ns/op BenchmarkPoseidonLarge-4 782 1547572 ns/op ``` - With the changes of this PR, where uses goff generated code instead of *big.Int: ``` BenchmarkPoseidon-4 9638 121651 ns/op BenchmarkPoseidonLarge-4 9781 119921 ns/op ```
arnaucube committed on Mar 3, 2020
b45d8a5
a
Resolve #4
arnaucube committed on Mar 3, 2020
83f87bf
a
Add goff generated finite field arithmetic code for used field
arnaucube committed on Mar 3, 2020
17bad75
a
Remove field package which is no longer used
arnaucube committed on Mar 5, 2020
4750e9c
a
Optimize MiMC7 migrating from *big.Int to goff Optimize MiMC7 migrating from *big.Int to goff generated finite field operations. There is still a lot of room for optimization for MiMC7 in the way that is done internally, but will be done in the future. Benchmarks: Tested on a Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz, with 16GB of RAM. - Before: ``` BenchmarkMIMC7-4 1026 1160298 ns/op ``` - After this commit: ``` BenchmarkMIMC7-4 19263 61651 ns/op ```
arnaucube committed on Mar 5, 2020
16a8a18
E
Fix compat with 32 bit arch
Eduard S committed on Mar 17, 2020
e10db81
E
Fix linters errors
Eduard S committed on Apr 14, 2020
0ac8b46
E
Add github actions and remove travis
Eduard S committed on Apr 14, 2020
14d0991
a
Add utils.ElementArrayToBigIntArray
arnaucube committed on Apr 20, 2020
b98a9fe
a
Expose SkToBigInt for usage from other packages & repos
arnaucube committed on Apr 22, 2020
d189a6b
a
Rm .travis.yml
arnaucube committed on May 22, 2020
e134988
a
Poseidon & MiMC7 HashBytes remove return of err
arnaucube committed on May 22, 2020
3a91710
a
Update Poseidon Hash function names, rm HashBytes Since Poseidon Hash is used because of compatibility in zkSNARK circuits, due circuit constraints number, the hash method of [T]*big.Int is the one directly compatible with the circuits, is the method which have the `Hash` name on it. The method that can take arbitrary length of []*big.Int putting them in chunks of [T]*big.Int and iterating, is called `HashSlice`. The `HashBytes` has been removed, as is a method that will not be used in zkSNARK circuits due high constraints number. For zkSNARK circuits, should be used `poseidon.Hash([poseidon.T]*big.Int)`.
arnaucube committed on Jul 23, 2020
f22be3c
a
Babyjubjub separate PointFromSignAndY from p.Decompress
arnaucube committed on Aug 6, 2020
833f68a
a
Add scanner/valuer interface to PublicKey
a_bennassar committed on Aug 13, 2020
a86308c
a
Add scanner/valuer interface to signature
a_bennassar committed on Aug 11, 2020
d91a426
a
Fix value sql interface
a_bennassar committed on Aug 14, 2020
674e8a6
a
Add goff to BabyJubJub point addition ``` Benchmarks (On a Intel(R) Core(TM) i7-8705G CPU @ 3.10GHz, with 32 GB of RAM): - Old (commit: e04ca5764a153717d7966e523a9cc8d7305bfcf8): BenchmarkBabyjub/AddConst-8 1000000 1072 ns/op BenchmarkBabyjub/AddRnd-8 93417 12943 ns/op BenchmarkBabyjub/MulRnd-8 252 4797810 ns/op BenchmarkBabyjub/Compress-8 7291580 166 ns/op BenchmarkBabyjub/InCurve-8 611137 1999 ns/op BenchmarkBabyjub/InSubGroup-8 615792 2021 ns/op BenchmarkBabyjubEddsa/SignMimc7-8 126 9358542 ns/op BenchmarkBabyjubEddsa/VerifyMimc7-8 124 9484005 ns/op BenchmarkBabyjubEddsa/SignPoseidon-8 126 9486484 ns/op BenchmarkBabyjubEddsa/VerifyPoseidon-8 126 9622807 ns/op - With new point addition algorithm (commit: aab1a681dd4b00cab49f39f9e30d6f28034589c1): BenchmarkBabyjub/AddConst-8 1356836 881 ns/op BenchmarkBabyjub/AddRnd-8 274112 4220 ns/op BenchmarkBabyjub/MulRnd-8 492 2474412 ns/op BenchmarkBabyjub/Compress-8 6964855 197 ns/op BenchmarkBabyjub/InCurve-8 608169 2008 ns/op BenchmarkBabyjub/InSubGroup-8 618772 1954 ns/op BenchmarkBabyjubEddsa/SignMimc7-8 238 4962397 ns/op BenchmarkBabyjubEddsa/VerifyMimc7-8 235 5234883 ns/op BenchmarkBabyjubEddsa/SignPoseidon-8 240 5028720 ns/op BenchmarkBabyjubEddsa/VerifyPoseidon-8 243 5226654 ns/op Point Addition: ~3x Point scalar Mul: ~1.9x Signature (poseidon): ~1.88x Verification (poseidon): ~1.84x - With new point addition algorithm & goff (current commit): BenchmarkBabyjub/AddConst-8 3000531 400 ns/op BenchmarkBabyjub/AddRnd-8 2770335 428 ns/op BenchmarkBabyjub/MulRnd-8 6636 175522 ns/op BenchmarkBabyjub/Compress-8 7358768 180 ns/op BenchmarkBabyjub/InCurve-8 539193 1950 ns/op BenchmarkBabyjub/InSubGroup-8 601402 1958 ns/op BenchmarkBabyjubEddsa/SignMimc7-8 2940 409487 ns/op BenchmarkBabyjubEddsa/VerifyMimc7-8 2908 414407 ns/op BenchmarkBabyjubEddsa/SignPoseidon-8 2395 493165 ns/op BenchmarkBabyjubEddsa/VerifyPoseidon-8 2491 494849 ns/op Point Addition: ~9.86x Point scalar Mul: ~14x Signature (poseidon): ~10.2x Verification (poseidon): ~10.56x --- Total improvement (from old to current): Point Addition: ~30.24x Point scalar Mul: ~27.33x Signature (poseidon): ~19.24x Verification (poseidon): ~19.44x ```
arnaucube committed on Sep 5, 2020
91767c7
a
Add add-2008-bbjlp for point addition Add `add-2008-bbjlp` for point addition Benchmarks (On a Intel(R) Core(TM) i7-8705G CPU @ 3.10GHz, with 32 GB of RAM): ``` - Old: BenchmarkBabyjub/AddConst-8 1000000 1072 ns/op BenchmarkBabyjub/AddRnd-8 93417 12943 ns/op BenchmarkBabyjub/MulRnd-8 252 4797810 ns/op BenchmarkBabyjub/Compress-8 7291580 166 ns/op BenchmarkBabyjub/InCurve-8 611137 1999 ns/op BenchmarkBabyjub/InSubGroup-8 615792 2021 ns/op BenchmarkBabyjubEddsa/SignMimc7-8 126 9358542 ns/op BenchmarkBabyjubEddsa/VerifyMimc7-8 124 9484005 ns/op BenchmarkBabyjubEddsa/SignPoseidon-8 126 9486484 ns/op BenchmarkBabyjubEddsa/VerifyPoseidon-8 126 9622807 ns/op - With new point addition algorithm: BenchmarkBabyjub/AddConst-8 1356836 881 ns/op BenchmarkBabyjub/AddRnd-8 274112 4220 ns/op BenchmarkBabyjub/MulRnd-8 492 2474412 ns/op BenchmarkBabyjub/Compress-8 6964855 197 ns/op BenchmarkBabyjub/InCurve-8 608169 2008 ns/op BenchmarkBabyjub/InSubGroup-8 618772 1954 ns/op BenchmarkBabyjubEddsa/SignMimc7-8 238 4962397 ns/op BenchmarkBabyjubEddsa/VerifyMimc7-8 235 5234883 ns/op BenchmarkBabyjubEddsa/SignPoseidon-8 240 5028720 ns/op BenchmarkBabyjubEddsa/VerifyPoseidon-8 243 5226654 ns/op ``` Point Addition: ~3x Point scalar Mul: ~1.9x Signature (poseidon): ~1.88x Verification (poseidon): ~1.84x
arnaucube committed on Sep 5, 2020
aab1a68
A
Add scanner/valuer interface to babyjub.SignatureComp
Arnau B committed on Oct 15, 2020
5ef832f
a
Update BabyJubJub EdDSA to last circomlib version - Update BabyJubJub EdDSA signature to last circomlib version (Poseidon usage) - Remove panic on hash error inside verification, to avoid panic due field overflow of BabyJubJub signature verification
arnaucube committed on Dec 2, 2020
5dd19b4
a
Upgrade linters
arnaucube committed on Dec 16, 2020
6d75396
a
Add scanner/valuer interface to babyjub.PublicKeyComp
arnaucube committed on Dec 18, 2020
a366175