arnaucube
arnaucube/hermez-nodePublic Self-hosted repository
Merge pull request #315 from hermeznetwork/feature/rm-ethvar

Rm unused ETHCLIENT_DIAL_URL
Eduard S eduard@iden3.io
Mon, 30 Nov 2020 15:59:16 +0100
commit

16d04de489e25375188fe0f00bcfa52bb415b2d4

parent

a8c9b7a6044b0d015a09422ea6f3c5840ee21118

2 files changed, 2 insertions(+), 3 deletions(-)

jump to
M .github/workflows/test.yml → .github/workflows/test.yml

@@ -21,6 +21,5 @@ run: docker run --rm --name hermez-db-test -p 5432:5432 -e POSTGRES_DB=hermez -e POSTGRES_USER=hermez -e POSTGRES_PASSWORD="${{ secrets.POSTGRES_PASS }}" -d postgres

- name: Test env: POSTGRES_PASS: ${{ secrets.POSTGRES_PASS }} - ETHCLIENT_DIAL_URL: ${{ secrets.ETHCLIENT_DIAL_URL }} GOARCH: ${{ matrix.goarch }} run: go test -p 1 ./...
M README.md → README.md

@@ -13,14 +13,14 @@

- Then, run the tests with the password as env var ``` -POSTGRES_PASS=yourpasswordhere ETHCLIENT_DIAL_URL=yourethereumurlhere go test -p 1 ./... +POSTGRES_PASS=yourpasswordhere go test -p 1 ./... ``` NOTE: `-p 1` forces execution of package test in serial. Otherwise they may be executed in paralel and the test may find unexpected entries in the SQL databse because it's shared among all tests. -- There is an extra temporal option that allows to run the API server through the Go tests. This should be removed once the API can be properly initialized, with data from the synchronizer and so on. To use this, run `FAKE_SERVER=yes POSTGRES_PASS=yourpasswordhere ETHCLIENT_DIAL_URL=yourethereumurlhere go test -timeout 0 ./api -p 1 -count 1 -v` +- There is an extra temporal option that allows to run the API server through the Go tests. This should be removed once the API can be properly initialized, with data from the synchronizer and so on. To use this, run `FAKE_SERVER=yes POSTGRES_PASS=yourpasswordhere go test -timeout 0 ./api -p 1 -count 1 -v` ## Lint