Loosen restrictions

This commit is contained in:
Pratyush Mishra
2021-01-08 21:02:30 -08:00
parent a44643ed76
commit 262fac3e83

View File

@@ -160,8 +160,8 @@ pub trait FieldVar<F: Field, ConstraintF: Field>:
/// It is up to the caller to ensure that denominator is non-zero,
/// since in that case the result is unconstrained.
fn mul_by_inverse(&self, denominator: &Self) -> Result<Self, SynthesisError> {
if self.is_constant() && denominator.is_constant() {
Ok(self.clone() * denominator.value()?.inverse().unwrap())
if denominator.is_constant() {
Ok(denominator.inverse()? * self)
} else {
let result = Self::new_witness(self.cs(), || {
let denominator_inv_native = denominator.value()?.inverse().get()?;